RFR: 8322708: Global HTML attributes are not allowed [v4]
Chen Liang
liach at openjdk.org
Fri Jun 14 19:12:12 UTC 2024
On Fri, 14 Jun 2024 19:00:41 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> Simplify method
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 670:
> 668: public AttrKind getAttrKind(Name attrName) {
> 669: Attr attr = getAttr(attrName);
> 670: if (attr==null){
Suggestion:
if (attr == null) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1640233115
More information about the javadoc-dev
mailing list