RFR: 8325690: The scrollable element <div> with non-interactive content is not tabbable [v38]

Hannes Wallnöfer hannesw at openjdk.org
Mon Jun 17 16:06:23 UTC 2024


On Fri, 14 Jun 2024 12:50:44 GMT, psoujany <duke at openjdk.org> wrote:

>> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 42 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into remove-overflow
>  - Add table role to summary tables
>  - Add table role to summary tables
>  - Add table role to summary tables
>  - Add table role to summary tables
>  - Add grid role to tables
>  - Add grid role to tables
>  - Merge branch 'remove-overflow' of github.com:psoujany/jdk into remove-overflow
>  - Merge branch 'openjdk:master' into remove-overflow
>  - Add grid role to tables
>  - ... and 32 more: https://git.openjdk.org/jdk/compare/a6fa4c6a...8748de2a

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java line 341:

> 339:                 cell.addStyle(tabClass);
> 340:                 if (!matchFound) {
> 341:                     cell.put(HtmlAttr.ROLE, "row")

We now use [CSS Grid layout](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout) for tables. Unfortunately, this implies that we do not have HTML elements representing rows. Tables are represented by an unstructured stream of table cells. This means that [`role="cell"`](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/cell_role) would probably be the right attribute to use here.

Once [Subgrid](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Subgrid) is well enough supported in browsers (which may be soon), we will be able to introduce elements representing table rows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1643053878


More information about the javadoc-dev mailing list