RFR: 8322708: Global HTML attributes are not allowed [v6]
Nizar Benalla
nbenalla at openjdk.org
Thu Jun 20 10:14:16 UTC 2024
On Wed, 19 Jun 2024 09:59:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>
> - Merge branch 'master' into html-attributes
> - whitespace
> - Simplify method
> - Null safety
> - Merge branch 'master' into html-attributes
> - remove trailing whitespace
> - -Add a boolean attribute to the enum type
> -Simply regex in `visitAttribute`
> -Simplified the Test
> -Added a negative test
> - no longer print summary
> - no longer print summary
> - Add small comment
> - ... and 2 more: https://git.openjdk.org/jdk/compare/c8be277e...aa2f2d89
Passes tier 1-3, I'll backport this once it's merged
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19652#issuecomment-2180311303
More information about the javadoc-dev
mailing list