Integrated: 8325433: Type annotations on primitive types are not linked

Chen Liang liach at openjdk.org
Tue Mar 12 12:15:20 UTC 2024


On Sun, 10 Mar 2024 20:19:44 GMT, Chen Liang <liach at openjdk.org> wrote:

> Please review this patch that fixes the issue where type annotations on primitive types are not linked.
> 
> Tested with file https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
> 
> import java.lang.annotation.*;
> 
> public class ArrayAnno {
> 	@Retention(RetentionPolicy.RUNTIME)
> 	@Target(ElementType.TYPE_USE)
> 	@Documented
> 	public @interface Anno { int value(); }
> 
> 	public void method(@Anno(1) int @Anno(2) [] @Anno(3) [] arg) {}
> 	public void method(@Anno(1) String @Anno(2) [] @Anno(3) [] arg) {}
> }
> 
> JDK 21: https://cr.openjdk.org/~liach/8325433-arrayanno/old/ArrayAnno.html
> This patch: https://cr.openjdk.org/~liach/8325433-arrayanno/new/ArrayAnno.html
> 
> Note that a bug within javac (reported in https://bugs.openjdk.org/browse/JDK-8327824) causes the annotations to become `@Anno(1) String @Anno(3) [] @Anno(2) []` in the output files; this bug also affects output class files so I assume this is a bug within javac's tree building. (Intersting, the buggy javadoc output was copied wholesale in the original `TestTypeAnnotations` output for `array2Deep` cases, but no one paid attention to it)

This pull request has now been integrated.

Changeset: 2cf35246
Author:    Chen Liang <liach at openjdk.org>
Committer: Pavel Rappo <prappo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2cf35246e6041e3c721efc24441545deb7a671a8
Stats:     53 lines in 5 files changed: 44 ins; 0 del; 9 mod

8325433: Type annotations on primitive types are not linked

Reviewed-by: gli, prappo

-------------

PR: https://git.openjdk.org/jdk/pull/18179


More information about the javadoc-dev mailing list