RFR: JDK-8328006: refactor large anonymous inner class in HtmlDocletWriter

[Hannes Wallnöfer]

On Tue, 12 Mar 2024 20:09:37 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a conceptually simple change, to move a large anonymous inner class to be a named inner class.
> 
> While most of the code is simply moved, two simple changes were necessary.  In `visitEscape` and `visitText` the variable `result` from the enclosing lexical scope was accessed directly. The change is simply to use the equivalent value `content` which is passed to each `visit...` call.
> 
> No tests needed updating. All javadoc tests pass.

Looks good except for a duplicate semicolon.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 1295:

> 1293:             }
> 1294: 
> 1295:             var docTreeVisitor = new InlineVisitor(element, tag, isLastNode, context, ch, trees);;

Duplicate semicolon

-------------

Marked as reviewed by hannesw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18252#pullrequestreview-1933364693
PR Review Comment: https://git.openjdk.org/jdk/pull/18252#discussion_r1522689134