RFR: JDK-8325874: Improve checkbox-based interface in summary pages

[Pavel Rappo]

On Mon, 11 Mar 2024 13:37:54 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

> Please review a change to improve the user experience and implementation for the checkbox-based interface to selectively display content on API summary pages:
> 
>  - Add a checkbox to toggle (select/unselect) all checkboxes in the page.
>  - Remove the `Table.setAlwaysShowDefaultTab(boolean)` setter as it is redundant and can be replaced by `!renderTabs`.
>  - Consolidate the code to generate checkboxes into a new protected `SummaryListWriter.getCheckbox` method.

Looks okay.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NewAPIListWriter.java line 86:

> 84:             Content tabs = HtmlTree.DIV(HtmlStyle.checkboxes,
> 85:                     contents.getContent("doclet.New_API_Checkbox_Label"));
> 86:             // Table column ids are 1-based

On line 82, which I cannot add a comment to on GitHub, there's this:

    List<String> releases = configuration.newAPIPageBuilder.releases;

It might be better to change it to this:

    List<String> releases = builder.releases;

-------------

Marked as reviewed by prappo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18194#pullrequestreview-1934169258
PR Review Comment: https://git.openjdk.org/jdk/pull/18194#discussion_r1523251733