RFR: JDK-8325690: The scrollable element <div> with non-interactive content is not tabbable [v2]

[psoujany]

On Wed, 6 Mar 2024 16:25:39 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> @hns Could you please validate my comment. Thank you.
>
> After having spent spent some time researching the problem and the proposed solution, I find that the premise of this issue is wrong. With current versions of supported browsers on my computer (Firefox, Chrome, Safari) the scrollable tabs can be focused using the tab key (in Safari the "press tab to highlight items" option has to be enabled in the advanced settings). It may be that this is a new addition in Chrome and Safari, and that they did not support this at the time when the issue was detected and filed.
> 
> Apart from that, I don't think that the proposed change would be a good fix for the problem. By removing the `overflow: auto` declarations in the given `<div>s`, overflow becomes invisible, or overflows the layout in the case of the rightmost column. Making content inaccessible for all users is not a good solution for the problem of content being inaccessible to keyboard users, and breaking the layout of the page is not desirable either.
> 
> Given that mainstream browsers seem to have followed Firefox and converted on making scrollable elements tabbable I would not consider this a problem in our documentation.

@hns Thank You for reviewing the change. We tested our change by adding/removing `overflow:auto` by feeding the `<div>`s with larger data and found column had expanded without scroll in both the cases and data was not stripped. After your review we extended our testing and found giving larger string in a line got stripped when there's no `overflow:auto`. Larger string was clearly visible with `overflow:auto` as it added horizontal scroll. 

We've fixed the issue by adding `tabindex=0` to the grid elements. We're testing the fix in various scenarios. Thank you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1540754342