Integrated: 8329537: Nested and enclosing classes should be linked separately in breadcrumb navigation

Hannes Wallnöfer hannesw at openjdk.org
Fri May 31 13:14:16 UTC 2024


On Wed, 29 May 2024 19:39:14 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

> Please review a patch to change the breadcrumb sub-navigation in API docs to display nested classes as separate links. 
> 
> The change itself is simple, I replaced the `getBreadCrumbLink` method in `HtmlDocletWriter` which returned a link for a single element with a new `addBreadCrumbLinks` method in `Navigation` which recursively adds all breadcrumb links to a list. Moving the code from `HtmlDocletWriter` to `Navigation` allowed me to remove a lot of code because it is no longer necessary to override the `getNavBar` method in a lot of writer subclasses.
> 
> I compared the JDI API documentation with and without this patch and there were no changes except for the breadcrumb links for nested classes.

This pull request has now been integrated.

Changeset: e930bc1f
Author:    Hannes Wallnöfer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e930bc1fbbbb0f2f8a4d03bfe7a8f4420335a8a2
Stats:     196 lines in 10 files changed: 66 ins; 128 del; 2 mod

8329537: Nested and enclosing classes should be linked separately in breadcrumb navigation

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/jdk/pull/19466


More information about the javadoc-dev mailing list