RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

[Sean Mullan]

On Tue, 29 Oct 2024 17:07:56 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> src/java.desktop/share/classes/java/awt/Font.java line 1613:
>> 
>>> 1611:      * interpreted as a {@code Font} object according to the
>>> 1612:      * specification of {@code Font.decode(String)}
>>> 1613:      * If the specified property is not found then null is returned instead.
>> 
>> Suggestion:
>> 
>>      * If the specified property is not found, null is returned instead.
>> 
>> The old description didn't have ‘then’, it can be dropped. A comma to separate the conditional clause from the main one makes the sentence easier to read.
>
> Updated on jep486 branch

Fixed in https://github.com/openjdk/jdk/pull/21498/commits/90469c2e42d0259d032a7bdf3be20d81e9fb8fac

>> src/java.desktop/share/classes/java/awt/Font.java line 1781:
>> 
>>> 1779:      * The property value should be one of the forms accepted by
>>> 1780:      * {@code Font.decode(String)}
>>> 1781:      * If the specified property is not found then the {@code font}
>> 
>> Suggestion:
>> 
>>      * If the specified property is not found, the {@code font}
>
> Updated on jep486 branch

Fixed in https://github.com/openjdk/jdk/pull/21498/commits/90469c2e42d0259d032a7bdf3be20d81e9fb8fac

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1823297079
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1823297577