RFR: 8338133: Cleanup direct use of `new HtmlTree` [v2]

Jonathan Gibbons jjg at openjdk.org
Tue Sep 3 20:31:34 UTC 2024


> Please review an update to "clean up" the direct use of HtmlTree constructors.
> 
> Hitherto, many/most instances of `HtmlTree` were created by static factory methods.  This update extends that convention.
> In most cases, this is by providing either simple no-arg factory methods or commonly used overloads that take an `HtmlId` or `HtmlStyle`.
> 
> For some tags, (`br`, `hr`, `wbr`) this allows a singleton instance to be used.
> For some of the more obscure cases, a more generic `HtmlTree.of(HtmlTag)` method was used.
> 
> Notes:
> * some significant block-level nodes, like `pre`, should probably always set a style, which could be enforced by suitable factory methods. That is currently not the case and could be a future cleanup.
> * some lists put the same style info on each list item, but might be better placed on the enclosing list. That could be a future cleanup

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  adddress review feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20778/files
  - new: https://git.openjdk.org/jdk/pull/20778/files/2245c726..a8cd49fe

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20778&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20778&range=00-01

  Stats: 10 lines in 3 files changed: 3 ins; 1 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/20778.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20778/head:pull/20778

PR: https://git.openjdk.org/jdk/pull/20778


More information about the javadoc-dev mailing list