Integrated: 8338133: Cleanup direct use of `new HtmlTree`
Jonathan Gibbons
jjg at openjdk.org
Thu Sep 5 15:49:02 UTC 2024
On Thu, 29 Aug 2024 20:10:13 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> Please review an update to "clean up" the direct use of HtmlTree constructors.
>
> Hitherto, many/most instances of `HtmlTree` were created by static factory methods. This update extends that convention.
> In most cases, this is by providing either simple no-arg factory methods or commonly used overloads that take an `HtmlId` or `HtmlStyle`.
>
> For some tags, (`br`, `hr`, `wbr`) this allows a singleton instance to be used.
> For some of the more obscure cases, a more generic `HtmlTree.of(HtmlTag)` method was used.
>
> Notes:
> * some significant block-level nodes, like `pre`, should probably always set a style, which could be enforced by suitable factory methods. That is currently not the case and could be a future cleanup.
> * some lists put the same style info on each list item, but might be better placed on the enclosing list. That could be a future cleanup
This pull request has now been integrated.
Changeset: 98020e47
Author: Jonathan Gibbons <jjg at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/98020e47996c0c6870e406bd513c8f503a336a73
Stats: 314 lines in 28 files changed: 197 ins; 25 del; 92 mod
8338133: Cleanup direct use of `new HtmlTree`
Reviewed-by: hannesw
-------------
PR: https://git.openjdk.org/jdk/pull/20778
More information about the javadoc-dev
mailing list