RFR: 8325090: javadoc fails when -subpackages option is used with non-modular -source [v2]

[Jonathan Gibbons]

On Thu, 26 Sep 2024 09:48:52 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Please review a simple fix to prevent `java.lang.AssertionError` to be thrown when the `javadoc` `-subpackages` option is used with a `-source` release that doesn't support modules.
>
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Align indentation

I must be missing something here. `-subpackages` is an old option that predates JDK 9/modules, so is reasonable to be used with code that does not use modules.  Either the code is wrong or the explanation here is wrong or I'm misunderstanding the issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21201#issuecomment-2377139080