RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v2]
Leo Korinth
lkorinth at openjdk.org
Wed Aug 13 14:22:10 UTC 2025
On Wed, 13 Aug 2025 13:25:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>>
>> After suggestions from Erik and Andrey
>
> make/RunTests.gmk line 939:
>
>> 937:
>> 938: JTREG_AUTO_PROBLEM_LISTS :=
>> 939: JTREG_AUTO_TIMEOUT_FACTOR := 1 # IT MAKES NO SENCE TO CHANGE IT. Fix individual test cases that time out instead.
>
> I'm not sure about this comment, but if we keep it, please move it to the line above and break lines as appropriate.
I updated it to "Please reach consensus before changing this. It was not easy changing it to a `1`. " I also did not break the comment as it was shorter than line 933 above it. Is it acceptable now?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26749#discussion_r2273621868
More information about the javadoc-dev
mailing list