RFR: 8365394: Stylesheet must not load fonts on --no-fonts output
Hannes Wallnöfer
hannesw at openjdk.org
Fri Aug 22 09:42:56 UTC 2025
On Tue, 19 Aug 2025 14:01:48 GMT, Marc Philipp <duke at openjdk.org> wrote:
> While copying `resources/stylesheet.css` to the target location, the
> line containing the CSS import statement for `fonts/dejavu.css` is now
> removed from the output in case the `--no-fonts` option is enabled.
Thanks for this cleanup of javadoc output. The changes look good, but there are two very long lines that should be wrapped.
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocFile.java line 220:
> 218: * @throws ResourceIOException if there is a problem while reading the resource
> 219: */
> 220: public void copyResource(DocPath resource, URL url, UnaryOperator<String> lineTransformer) throws DocFileIOException, ResourceIOException {
Please wrap the throws clauses on this method and the method below.
-------------
Changes requested by hannesw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26843#pullrequestreview-3143813462
PR Review Comment: https://git.openjdk.org/jdk/pull/26843#discussion_r2293225084
More information about the javadoc-dev
mailing list