RFR: 8346659: SnippetTaglet should report an error if provided ambiguous links [v3]
Hannes Wallnöfer
hannesw at openjdk.org
Wed Feb 19 14:58:54 UTC 2025
On Tue, 18 Feb 2025 17:28:48 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Hmm, I thought this means "the link you have encountered" and didn't raise a point during review.
>
> I thought of this as referring to link we've encountered, but I can change the name for clarity
Agreed it's not wrong, but you changed the type of the variable and kept the name. I think naming is important, even for local vars.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23328#discussion_r1961836868
More information about the javadoc-dev
mailing list