RFR: 8346659: SnippetTaglet should report an error if provided ambiguous links [v9]

Chen Liang liach at openjdk.org
Wed Feb 26 15:33:54 UTC 2025


On Wed, 26 Feb 2025 15:03:46 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Some javadoc snippets can match multiple links to the same content, leading to different results in different javadoc runs.
>> This patch proposes emitting an error when such cases are encountered.
>> 
>> There is a very trivial, unrelated change in `TestGlobalHtml.java` because I noticed some whitespace wasn't right.
>
> Nizar Benalla has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "Improve error message by pointing to location of links"
>    
>    This reverts commit 9b2107d90203febd9615e7622816432751c3f9e2.
>  - Revert "trim error message"
>    
>    This reverts commit e0d70a410a1149efa07f6486334fdcad3e31a3c9.

The rolled back version looks good. Please wait for @hns to review too.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23328#pullrequestreview-2644943623


More information about the javadoc-dev mailing list