From hannesw at openjdk.org Mon Jan 13 14:08:57 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Mon, 13 Jan 2025 14:08:57 GMT Subject: RFR: 8347381: Upgrade jQuery UI to version 1.14.1 Message-ID: <13B3RBFdfnG89LNgU-QVLThgIWAqqJJBvlJnHNfTxuU=.74932262-ed64-44fb-acf0-c25325deb8e4@github.com> Please review a javadoc update for jQuery UI from release 1.13.2 to 1.14.1. Tests are fine, and I also tested search functionality of generated documentation in the browser without encountering any problems. Copyright owner changed from jQuery Foundation to OpenJS Foundation in this release. ------------- Commit messages: - 8347381: Upgrade jQuery UI to version 1.14.1 Changes: https://git.openjdk.org/jdk/pull/23073/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23073&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347381 Stats: 135 lines in 5 files changed: 3 ins; 70 del; 62 mod Patch: https://git.openjdk.org/jdk/pull/23073.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23073/head:pull/23073 PR: https://git.openjdk.org/jdk/pull/23073 From liach at openjdk.org Tue Jan 14 13:44:44 2025 From: liach at openjdk.org (Chen Liang) Date: Tue, 14 Jan 2025 13:44:44 GMT Subject: RFR: 8347381: Upgrade jQuery UI to version 1.14.1 In-Reply-To: <13B3RBFdfnG89LNgU-QVLThgIWAqqJJBvlJnHNfTxuU=.74932262-ed64-44fb-acf0-c25325deb8e4@github.com> References: <13B3RBFdfnG89LNgU-QVLThgIWAqqJJBvlJnHNfTxuU=.74932262-ed64-44fb-acf0-c25325deb8e4@github.com> Message-ID: On Mon, 13 Jan 2025 14:03:32 GMT, Hannes Walln?fer wrote: > Please review a javadoc update for jQuery UI from release 1.13.2 to 1.14.1. > > Tests are fine, and I also tested search functionality of generated documentation in the browser without encountering any problems. > > Copyright owner changed from jQuery Foundation to OpenJS Foundation in this release. Looks innocuous to me. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23073#pullrequestreview-2549734749 From hannesw at openjdk.org Tue Jan 14 14:03:48 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Tue, 14 Jan 2025 14:03:48 GMT Subject: Integrated: 8347381: Upgrade jQuery UI to version 1.14.1 In-Reply-To: <13B3RBFdfnG89LNgU-QVLThgIWAqqJJBvlJnHNfTxuU=.74932262-ed64-44fb-acf0-c25325deb8e4@github.com> References: <13B3RBFdfnG89LNgU-QVLThgIWAqqJJBvlJnHNfTxuU=.74932262-ed64-44fb-acf0-c25325deb8e4@github.com> Message-ID: On Mon, 13 Jan 2025 14:03:32 GMT, Hannes Walln?fer wrote: > Please review a javadoc update for jQuery UI from release 1.13.2 to 1.14.1. > > Tests are fine, and I also tested search functionality of generated documentation in the browser without encountering any problems. > > Copyright owner changed from jQuery Foundation to OpenJS Foundation in this release. This pull request has now been integrated. Changeset: 56c78007 Author: Hannes Walln?fer URL: https://git.openjdk.org/jdk/commit/56c780078f84a2571b779d90f528d5bcab2a9dfd Stats: 135 lines in 5 files changed: 3 ins; 70 del; 62 mod 8347381: Upgrade jQuery UI to version 1.14.1 Reviewed-by: liach ------------- PR: https://git.openjdk.org/jdk/pull/23073 From duke at openjdk.org Wed Jan 15 22:30:45 2025 From: duke at openjdk.org (duke) Date: Wed, 15 Jan 2025 22:30:45 GMT Subject: Withdrawn: 8344191: Build code should not have classpath exception In-Reply-To: References: Message-ID: On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote: > In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. > > I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data. > > The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception. > > This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk/pull/22104 From nbenalla at openjdk.org Thu Jan 23 12:57:56 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Thu, 23 Jan 2025 12:57:56 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears Message-ID: When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. Example when auto-translating the page to Arabic `` This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. TIA ------------- Commit messages: - Add a new attribute to the link tag (use to link stylesheets) to stop browsers from translating it Changes: https://git.openjdk.org/jdk/pull/23263/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23263&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347058 Stats: 34 lines in 7 files changed: 3 ins; 0 del; 31 mod Patch: https://git.openjdk.org/jdk/pull/23263.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23263/head:pull/23263 PR: https://git.openjdk.org/jdk/pull/23263 From nbenalla at openjdk.org Thu Jan 23 13:51:48 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Thu, 23 Jan 2025 13:51:48 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears In-Reply-To: References: Message-ID: On Thu, 23 Jan 2025 11:28:19 GMT, Nizar Benalla wrote: > When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. > Example when auto-translating the page to Arabic `` > > This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. > > TIA Passes tier 1 on linux-x64 ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2609857814 From nbenalla at openjdk.org Thu Jan 23 14:30:51 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Thu, 23 Jan 2025 14:30:51 GMT Subject: RFR: 8331873: Improve/expand info in `New API In` on Help page In-Reply-To: References: Message-ID: On Mon, 13 May 2024 23:08:51 GMT, Jonathan Gibbons wrote: > Please review a relatively simple update to the generated Help page, as part of the ongoing campaign to improve the documentation around the overall use of `@since` tags. This PR has been superseded by #23269. Please continue the discussion and review there. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19222#issuecomment-2609954487 From nbenalla at openjdk.org Thu Jan 23 14:36:59 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Thu, 23 Jan 2025 14:36:59 GMT Subject: RFR: 8331873: Improve/expand info in `New API In` on Help page Message-ID: This PR supersedes #19222, I've resolved the merge conflicts and updated the text based on review comments. ------------- Commit messages: - Update according to feedback - Merge branch 'master' into new-api-help-page - QOL change - change "all" to "toggle all" in the new-list and deprecated-list pages - fix merge conflicts and slight refactor due to 8335122 - 8331873: Improve/expand info in `New API In` on Help page. Changes: https://git.openjdk.org/jdk/pull/23269/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23269&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331873 Stats: 42 lines in 3 files changed: 34 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/23269.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23269/head:pull/23269 PR: https://git.openjdk.org/jdk/pull/23269 From nbenalla at openjdk.org Thu Jan 23 16:04:13 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Thu, 23 Jan 2025 16:04:13 GMT Subject: RFR: 8331873: Improve/expand info in `New API In` on Help page [v2] In-Reply-To: References: Message-ID: > This PR supersedes #19222, I've resolved the merge conflicts and updated the text based on review comments. Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: Update TestNewApiList ------------- Changes: - all: https://git.openjdk.org/jdk/pull/23269/files - new: https://git.openjdk.org/jdk/pull/23269/files/f45df69b..128ada03 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=23269&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23269&range=00-01 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/23269.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23269/head:pull/23269 PR: https://git.openjdk.org/jdk/pull/23269 From hannesw at openjdk.org Mon Jan 27 10:36:51 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Mon, 27 Jan 2025 10:36:51 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears In-Reply-To: References:

Message-ID: <6gToyqD0fa-V-jGm8Do_Q9-2U03_dIHMoFBW764EW8Y=.8cb35b91-6704-44be-b5cd-87a5161ca730@github.com> On Thu, 23 Jan 2025 13:49:04 GMT, Nizar Benalla wrote: >> When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. >> Example when auto-translating the page to Arabic `` >> >> This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. >> >> TIA > > Passes tier 1 on linux-x64 So the stylesheeet stops working because the translation service changes the `title` attribute? I find that quite weird. Can you point me to some external discussion of this problem, @nizarbenalla? If the `title` attribute is indeed the problem, I think I would prefer to get rid of the title attribute (with it's rather useless "Style" value) rather than adding the `translate="no"` attribute. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2615385516 From nbenalla at openjdk.org Mon Jan 27 13:49:46 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Mon, 27 Jan 2025 13:49:46 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears In-Reply-To: References: Message-ID: On Thu, 23 Jan 2025 11:28:19 GMT, Nizar Benalla wrote: > When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. > Example when auto-translating the page to Arabic `` > > This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. > > TIA Here are stackoverflow discussions on the [issue](https://stackoverflow.com/questions/8226165/google-translate-is-removing-css) and on how [to solve it](https://stackoverflow.com/questions/12238396/how-to-disable-google-translate-from-html-in-chrome). Removing the `title` attribute might be better than asking google translate to ignore the tag. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2615808752 From hannesw at openjdk.org Mon Jan 27 13:57:47 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Mon, 27 Jan 2025 13:57:47 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears In-Reply-To: References: Message-ID: On Thu, 23 Jan 2025 11:28:19 GMT, Nizar Benalla wrote: > When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. > Example when auto-translating the page to Arabic `` > > This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. > > TIA +1 for removing the `title` attribute. We're using the same attribute value for all style links, so there is no benefit from these attributes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2615827409 From nbenalla at openjdk.org Mon Jan 27 14:35:30 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Mon, 27 Jan 2025 14:35:30 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears [v2] In-Reply-To: References: Message-ID: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> > When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. > Example when auto-translating the page to Arabic `` > > This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. > > TIA Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: respond to feedback ------------- Changes: - all: https://git.openjdk.org/jdk/pull/23263/files - new: https://git.openjdk.org/jdk/pull/23263/files/09aaa5e4..16675e7c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=23263&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23263&range=00-01 Stats: 24 lines in 7 files changed: 0 ins; 5 del; 19 mod Patch: https://git.openjdk.org/jdk/pull/23263.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23263/head:pull/23263 PR: https://git.openjdk.org/jdk/pull/23263 From nbenalla at openjdk.org Mon Jan 27 14:35:30 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Mon, 27 Jan 2025 14:35:30 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears In-Reply-To: References: Message-ID: On Thu, 23 Jan 2025 11:28:19 GMT, Nizar Benalla wrote: > When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. > Example when auto-translating the page to Arabic `` > > This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. > > TIA I wasn't sure if we had alternate stylesheets. The generated Javadoc looks fine after the change. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2615921672 From hannesw at openjdk.org Mon Jan 27 14:59:47 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Mon, 27 Jan 2025 14:59:47 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears [v2] In-Reply-To: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> References: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> Message-ID: On Mon, 27 Jan 2025 14:35:30 GMT, Nizar Benalla wrote: >> When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. >> Example when auto-translating the page to Arabic `` >> >> This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: > > respond to feedback Looks good. We may have to revisit this when we add support for multiple themes, as it may make sense to to have `title` attributes with acutally useful values then. ------------- Marked as reviewed by hannesw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23263#pullrequestreview-2575672612 From liach at openjdk.org Mon Jan 27 15:44:50 2025 From: liach at openjdk.org (Chen Liang) Date: Mon, 27 Jan 2025 15:44:50 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears [v2] In-Reply-To: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> References: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> Message-ID: On Mon, 27 Jan 2025 14:35:30 GMT, Nizar Benalla wrote: >> When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. >> Example when auto-translating the page to Arabic `` >> >> This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: > > respond to feedback Why was the title attribute present in the first place? Was it a remainder from the HTML 4 times? ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2616107543 From hannesw at openjdk.org Mon Jan 27 16:30:49 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Mon, 27 Jan 2025 16:30:49 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears [v2] In-Reply-To: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> References: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> Message-ID: On Mon, 27 Jan 2025 14:35:30 GMT, Nizar Benalla wrote: >> When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. >> Example when auto-translating the page to Arabic `` >> >> This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: > > respond to feedback It is part of the [alternative style sheets](https://developer.mozilla.org/en-US/docs/Web/CSS/Alternative_style_sheets) mechanism, but alternative style sheets are not widely supported (see [browser support table](https://developer.mozilla.org/en-US/docs/Web/CSS/Alternative_style_sheets#browser_compatibility)), and we were not making proper use of the feature anyway (stylesheet title was same hard-coded value for all style sheets, even for custom style sheets). I also learned that today, btw. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2616286791 From liach at openjdk.org Mon Jan 27 16:36:55 2025 From: liach at openjdk.org (Chen Liang) Date: Mon, 27 Jan 2025 16:36:55 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears [v2] In-Reply-To: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> References: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> Message-ID: <-fQXedkh5PHp0wXVoUk2yV7m4eeqUXULHM-hGXjjv3w=.f941c473-bc41-4bdf-bd9c-d665c1f215cf@github.com> On Mon, 27 Jan 2025 14:35:30 GMT, Nizar Benalla wrote: >> When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. >> Example when auto-translating the page to Arabic `` >> >> This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: > > respond to feedback Marked as reviewed by liach (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/23263#pullrequestreview-2575944307 From hannesw at openjdk.org Tue Jan 28 09:13:45 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Tue, 28 Jan 2025 09:13:45 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears [v2] In-Reply-To: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> References: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> Message-ID: On Mon, 27 Jan 2025 14:35:30 GMT, Nizar Benalla wrote: >> When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. >> Example when auto-translating the page to Arabic `` >> >> This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: > > respond to feedback BTW the alternative style sheet specification also explains the browser bug that makes styles disappear when the `title` attribute is changed. The browser tries to switch to a style sheet with the translated title, while the style sheet was registered with its original title. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2618376487 From nbenalla at openjdk.org Tue Jan 28 11:16:57 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Tue, 28 Jan 2025 11:16:57 GMT Subject: RFR: 8347058: When automatically translating the page to pt-br, all CSS styling disappears [v2] In-Reply-To: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> References: <2N-lAqK_yF7zY0TStEUEwOSVbr9j5wEsbvT2yLaoEeQ=.71fdb65b-4746-4c1f-a9a6-71102db8c411@github.com> Message-ID: On Mon, 27 Jan 2025 14:35:30 GMT, Nizar Benalla wrote: >> When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. >> Example when auto-translating the page to Arabic `` >> >> This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: > > respond to feedback Thanks for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23263#issuecomment-2618696923 From nbenalla at openjdk.org Tue Jan 28 11:16:58 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Tue, 28 Jan 2025 11:16:58 GMT Subject: Integrated: 8347058: When automatically translating the page to pt-br, all CSS styling disappears In-Reply-To: References: Message-ID: <4leNLnE8O1YP_IJI5YExE4Jbp1aW9XCPLZzT50hBfHA=.ff137d0a-7265-4647-976e-876d61d83af4@github.com> On Thu, 23 Jan 2025 11:28:19 GMT, Nizar Benalla wrote: > When translating to some languages like Portuguese or Arabic google translate will modify the HTML and changes the value of the HTML title Attribute. > Example when auto-translating the page to Arabic `` > > This patch to add a `translate="no"` attribute to the HTML `link` tag used to link CSS stylesheets, this seems to prevent the translation of the `title` property by google chrome on my local machine. > > TIA This pull request has now been integrated. Changeset: 3a8680e9 Author: Nizar Benalla URL: https://git.openjdk.org/jdk/commit/3a8680e919fb2505ff0e05e6ea6ae39ef25c81b2 Stats: 33 lines in 7 files changed: 0 ins; 2 del; 31 mod 8347058: When automatically translating the page to pt-br, all CSS styling disappears Reviewed-by: hannesw, liach ------------- PR: https://git.openjdk.org/jdk/pull/23263 From nbenalla at openjdk.org Tue Jan 28 11:34:44 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Tue, 28 Jan 2025 11:34:44 GMT Subject: RFR: 8346659: SnippetTaglet should report an error if provided ambiguous links Message-ID: Some javadoc snippets can match multiple links to the same content, leading to different results in different javadoc runs. This patch proposes emitting an error when such cases are encountered. There is a very trivial, unrelated change in `TestGlobalHtml.java` because I noticed some whitespace wasn't right. ------------- Commit messages: - emit error when encountering ambigious link Changes: https://git.openjdk.org/jdk/pull/23328/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23328&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346659 Stats: 111 lines in 4 files changed: 82 ins; 12 del; 17 mod Patch: https://git.openjdk.org/jdk/pull/23328.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23328/head:pull/23328 PR: https://git.openjdk.org/jdk/pull/23328 From liach at openjdk.org Tue Jan 28 16:23:52 2025 From: liach at openjdk.org (Chen Liang) Date: Tue, 28 Jan 2025 16:23:52 GMT Subject: RFR: 8346659: SnippetTaglet should report an error if provided ambiguous links In-Reply-To: References: Message-ID: On Tue, 28 Jan 2025 11:23:36 GMT, Nizar Benalla wrote: > Some javadoc snippets can match multiple links to the same content, leading to different results in different javadoc runs. > This patch proposes emitting an error when such cases are encountered. > > There is a very trivial, unrelated change in `TestGlobalHtml.java` because I noticed some whitespace wasn't right. test/langtools/jdk/javadoc/doclet/TestGlobalHtml/TestGlobalHtml.java line 29: > 27: * @summary Test to make sure global tags work properly > 28: * @library /tools/lib ../../lib > 29: * @modules jdk.javadoc/jdk.javadoc.internal.tool Redundant change? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23328#discussion_r1932476957 From nbenalla at openjdk.org Tue Jan 28 16:35:53 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Tue, 28 Jan 2025 16:35:53 GMT Subject: RFR: 8346659: SnippetTaglet should report an error if provided ambiguous links In-Reply-To: References:

Message-ID: On Tue, 28 Jan 2025 16:21:08 GMT, Chen Liang wrote: >> Some javadoc snippets can match multiple links to the same content, leading to different results in different javadoc runs. >> This patch proposes emitting an error when such cases are encountered. >> >> There is a very trivial, unrelated change in `TestGlobalHtml.java` because I noticed some whitespace wasn't right. > > test/langtools/jdk/javadoc/doclet/TestGlobalHtml/TestGlobalHtml.java line 29: > >> 27: * @summary Test to make sure global tags work properly >> 28: * @library /tools/lib ../../lib >> 29: * @modules jdk.javadoc/jdk.javadoc.internal.tool > > Redundant change? > There is a very trivial, unrelated change in TestGlobalHtml.java because I noticed some whitespace wasn't right. I noticed the missing space because I copied the jtreg comment from it, seems harmful to fix. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23328#discussion_r1932501296 From liach at openjdk.org Tue Jan 28 16:35:52 2025 From: liach at openjdk.org (Chen Liang) Date: Tue, 28 Jan 2025 16:35:52 GMT Subject: RFR: 8331873: Improve/expand info in `New API In` on Help page [v2] In-Reply-To: References:

Message-ID: On Thu, 23 Jan 2025 16:04:13 GMT, Nizar Benalla wrote: >> This PR supersedes #19222, I've resolved the merge conflicts and updated the text based on review comments. > > Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: > > Update TestNewApiList src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 393: > 391: normally include the release in which the declaration was introduced. > 392: doclet.help.releases.body.specify.member=\ > 393: When a member is added after the initial introduction of the enclosing class or interface, the details of the member include the release in which it was introduced. Why do you wrap other lines but not this long one? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23269#discussion_r1932499580 From nbenalla at openjdk.org Wed Jan 29 15:16:33 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Wed, 29 Jan 2025 15:16:33 GMT Subject: RFR: 8331873: Improve/expand info in `New API In` on Help page [v3] In-Reply-To: References: Message-ID: > This PR supersedes #19222, I've resolved the merge conflicts and updated the text based on review comments. Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: - wrap lines - Merge remote-tracking branch 'upstream/master' into new-api-help-page - Update TestNewApiList - Update according to feedback - Merge branch 'master' into new-api-help-page - QOL change - change "all" to "toggle all" in the new-list and deprecated-list pages - fix merge conflicts and slight refactor due to 8335122 - 8331873: Improve/expand info in `New API In` on Help page. ------------- Changes: - all: https://git.openjdk.org/jdk/pull/23269/files - new: https://git.openjdk.org/jdk/pull/23269/files/128ada03..e38d1ffd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=23269&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23269&range=01-02 Stats: 10472 lines in 895 files changed: 6347 ins; 995 del; 3130 mod Patch: https://git.openjdk.org/jdk/pull/23269.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23269/head:pull/23269 PR: https://git.openjdk.org/jdk/pull/23269 From nbenalla at openjdk.org Wed Jan 29 15:16:34 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Wed, 29 Jan 2025 15:16:34 GMT Subject: RFR: 8331873: Improve/expand info in `New API In` on Help page [v2] In-Reply-To: References:

Message-ID: <8ssWSPc49ibSbLk6X3AgGWE-SfdLhPi95mcHi1Sx24s=.d803e130-a5c4-4e94-8c16-345bbf4e2f91@github.com> On Tue, 28 Jan 2025 16:32:26 GMT, Chen Liang wrote: >> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: >> >> Update TestNewApiList > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 393: > >> 391: normally include the release in which the declaration was introduced. >> 392: doclet.help.releases.body.specify.member=\ >> 393: When a member is added after the initial introduction of the enclosing class or interface, the details of the member include the release in which it was introduced. > > Why do you wrap other lines but not this long one? I should have wrapped the line, I've fixed it in [e38d1ff](https://github.com/openjdk/jdk/pull/23269/commits/e38d1ffddb0657cd3984502302c8eb2b0563d364). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23269#discussion_r1934076739 From liach at openjdk.org Wed Jan 29 20:31:48 2025 From: liach at openjdk.org (Chen Liang) Date: Wed, 29 Jan 2025 20:31:48 GMT Subject: RFR: 8331873: Improve/expand info in `New API In` on Help page [v3] In-Reply-To: References:

Message-ID: <98UFe5xmYCQg24TNmru1kBu8SMSFJCfgmC0l8dFa2NA=.1595b258-cb1a-4953-bcbf-ed9559ca7632@github.com> On Wed, 29 Jan 2025 15:16:33 GMT, Nizar Benalla wrote: >> This PR supersedes #19222, I've resolved the merge conflicts and updated the text based on review comments. > > Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: > > - wrap lines > - Merge remote-tracking branch 'upstream/master' into new-api-help-page > - Update TestNewApiList > - Update according to feedback > - Merge branch 'master' into new-api-help-page > - QOL change - change "all" to "toggle all" in the new-list and deprecated-list pages > - fix merge conflicts and slight refactor due to 8335122 > - 8331873: Improve/expand info in `New API In` on Help page. Looks good; maybe @hns can take a look too. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23269#pullrequestreview-2582167338 From hannesw at openjdk.org Thu Jan 30 13:47:55 2025 From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=) Date: Thu, 30 Jan 2025 13:47:55 GMT Subject: RFR: 8331873: Improve/expand info in `New API In` on Help page [v3] In-Reply-To: References:

Message-ID: On Wed, 29 Jan 2025 15:16:33 GMT, Nizar Benalla wrote: >> This PR supersedes #19222, I've resolved the merge conflicts and updated the text based on review comments. > > Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: > > - wrap lines > - Merge remote-tracking branch 'upstream/master' into new-api-help-page > - Update TestNewApiList > - Update according to feedback > - Merge branch 'master' into new-api-help-page > - QOL change - change "all" to "toggle all" in the new-list and deprecated-list pages > - fix merge conflicts and slight refactor due to 8335122 > - 8331873: Improve/expand info in `New API In` on Help page. I've wanted to do the "Toggle all" change for a while. Thanks for the reviews. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23269#issuecomment-2626072314 From nbenalla at openjdk.org Fri Jan 31 01:19:58 2025 From: nbenalla at openjdk.org (Nizar Benalla) Date: Fri, 31 Jan 2025 01:19:58 GMT Subject: Integrated: 8331873: Improve/expand info in `New API In` on Help page In-Reply-To: References: Message-ID: On Thu, 23 Jan 2025 14:13:36 GMT, Nizar Benalla wrote: > This PR supersedes #19222, I've resolved the merge conflicts and updated the text based on review comments. This pull request has now been integrated. Changeset: 8986cb27 Author: Nizar Benalla URL: https://git.openjdk.org/jdk/commit/8986cb2772469fa8fe30bbe7407eeb35545af1a3 Stats: 48 lines in 4 files changed: 35 ins; 2 del; 11 mod 8331873: Improve/expand info in `New API In` on Help page Co-authored-by: Jonathan Gibbons Reviewed-by: liach, hannesw ------------- PR: https://git.openjdk.org/jdk/pull/23269