RFR: 8356975: Provide alternative way to generate preview API docs [v2]

Hannes Wallnöfer hannesw at openjdk.org
Tue Jul 15 11:04:05 UTC 2025


On Sat, 12 Jul 2025 22:09:42 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add warning for multiple preview notes
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 2506:
> 
>> 2504:                     previewDiv.setId(htmlIds.forPreviewSection(forWhat));
>> 2505:                     previewDiv.add(HtmlTree.DIV(HtmlStyles.previewComment,
>> 2506:                             commentTagsToContent(forWhat, tags.getFirst().getContent(), false)));
> 
> Should we add a check to assert there is exactly one occurrence of such a preview note tag?

Makes sense. I don't think it's serious enough to generate an error though. I'm adding a change to trigger a warning.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26267#discussion_r2207153789


More information about the javadoc-dev mailing list