RFR: 8359760: Remove the jdk.jsobject module
Roger Riggs
rriggs at openjdk.org
Tue Jul 22 18:51:55 UTC 2025
On Tue, 22 Jul 2025 18:44:40 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> test/langtools/jdk/javadoc/doclet/testModules/jdk/element-list line 305:
>>
>>> 303: jdk.jshell.spi
>>> 304: jdk.jshell.tool
>>> 305: module:jdk.jsobject
>>
>> There is a similar pair in test/langtools/jdk/javadoc/doclet/testRecordTypes/jdk17/element-list.
>> Can it be removed? Unless it causes a test failure.
>
> I wondered about that, and originally was going to remove it, but then noticed that the test in question parses the JDK 17 API docs (which does have the `jdk.jsobject` module).
>
> https://github.com/openjdk/jdk/blob/e70c702d6f864b494dc7df3eea4f1a317a3bc981/test/langtools/jdk/javadoc/doclet/testRecordTypes/TestRecordTypes.java#L55-56
>
>
> private static final String externalDocs =
> "https://docs.oracle.com/en/java/javase/17/docs/api";
>
>
> I suspect that the test will run just fine if I remove it. I don't mind either way. What would you recommend?
I ran the test and then removed those lines and the test still passed.
I'd remove them to avoiding leaving a (little) mess behind.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26393#discussion_r2223524163
More information about the javadoc-dev
mailing list