From mbaesken at openjdk.org  Sun Jun  1 09:09:02 2025
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Sun, 1 Jun 2025 09:09:02 GMT
Subject: RFR: 8358136: Make
 langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java
 intermittent
In-Reply-To: <ngpvzxYtSAnoIl-BHFrfhhjq5JWTUspQ49I9LY0efBc=.633adceb-d094-41b0-bd1a-4b0cc6ce426c@github.com>
References: <ngpvzxYtSAnoIl-BHFrfhhjq5JWTUspQ49I9LY0efBc=.633adceb-d094-41b0-bd1a-4b0cc6ce426c@github.com>
Message-ID: <99wyI7XP5l9YQ0dUs8s2po8XxidBZSsWvCpNm04w75I=.654b2624-5bb9-40e8-bef7-02f9379f2804@github.com>

On Fri, 30 May 2025 09:51:23 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java intermittent, add the respective keyword.
> The test fails sometimes, see e.g. JDK-8338439 .

Thanks for the reviews !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25540#issuecomment-2926860710

From mbaesken at openjdk.org  Sun Jun  1 09:09:02 2025
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Sun, 1 Jun 2025 09:09:02 GMT
Subject: Integrated: 8358136: Make
 langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java
 intermittent
In-Reply-To: <ngpvzxYtSAnoIl-BHFrfhhjq5JWTUspQ49I9LY0efBc=.633adceb-d094-41b0-bd1a-4b0cc6ce426c@github.com>
References: <ngpvzxYtSAnoIl-BHFrfhhjq5JWTUspQ49I9LY0efBc=.633adceb-d094-41b0-bd1a-4b0cc6ce426c@github.com>
Message-ID: <fvsBNv6V9P81gCTC8kWA8kloRl67GCYmFVCgGjBkomI=.10fec172-511c-4abc-b6de-d49d8557c802@github.com>

On Fri, 30 May 2025 09:51:23 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java intermittent, add the respective keyword.
> The test fails sometimes, see e.g. JDK-8338439 .

This pull request has now been integrated.

Changeset: c1b5f62a
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c1b5f62a8c30038d3b1a14d184535ba0642d51c9
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8358136: Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java intermittent

Reviewed-by: jpai, nbenalla, syan

-------------

PR: https://git.openjdk.org/jdk/pull/25540

From hannesw at openjdk.org  Mon Jun  2 07:23:51 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Mon, 2 Jun 2025 07:23:51 GMT
Subject: RFR: 8357796: Stylesheet adjustments after JDK-8357452
In-Reply-To: <L4k3Fe7FKURlJXvWK3ZZnjxCDInkNjupSqvLhHbG18E=.449a8f72-3edc-4887-a8b3-53622eb78036@github.com>
References: <L4k3Fe7FKURlJXvWK3ZZnjxCDInkNjupSqvLhHbG18E=.449a8f72-3edc-4887-a8b3-53622eb78036@github.com>
Message-ID: <th5LOZwDoOzjGQqU6ozAvPQ1rpJDoFwBJ4jVMmKhSY4=.39d7194a-faca-40b3-afaa-81eb47edfd69@github.com>

On Mon, 26 May 2025 16:52:13 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a simple stylesheet change to adjust for the removal of code span highlights in [JDK-8357452](https://bugs.openjdk.org/browse/JDK-8357452).
> 
> Both of the (subtle) changes undone in this PR were introduced with code span highlights and are no longer needed.

Thanks for the reviews. Sorry for not providing screenshots in the first place, screenshots and description of changes below.

 - Code font had been reduced to accomodate for code span highlights, this changes it back to original size (most noticable in method signatures)
 - Not enough distance between multiple items in "See Also" list due to removed code span highlight, now is back to using code font space.

Before:
<img width="1051" alt="8357796-before" src="https://github.com/user-attachments/assets/d0c705be-a320-437b-b137-a681a07252af" />

After: 
<img width="1050" alt="8357796-after" src="https://github.com/user-attachments/assets/bf1e8e05-5a19-445e-b95f-fa58c64f4f24" />

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25454#issuecomment-2929177930

From nbenalla at openjdk.org  Mon Jun  2 14:31:17 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Mon, 2 Jun 2025 14:31:17 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v6]
In-Reply-To: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
Message-ID: <dRu4Em1UTxysLY47dgjbhmMTcc5Mkg0hXbrkAWLAjUY=.e9d4dd86-b799-46b7-a622-5f5830c60e04@github.com>

> Please review this patch to fix a bug where a method can be documented multiple times 
> Consider these 4 classes
> 
>                     A       (interface)
>                    / \
>                   /   \
> (abstract class)  C     B   ( interface)
>                   \   /
>                    \ /
>                     D       (class)
> 
> 
> Where `A` declares `testA()`, `C` implements it `public final void testA()`, `B` extends `A` but does *not* override it, `D` extends `C` and implements `B`
> 
> In the generated javadoc, `testA()` is documented twice.
> 
> ![Screenshot 2025-05-08 at 15 51 19](https://github.com/user-attachments/assets/46538e61-1546-4128-8041-296d8491406f)
> 
> After the patch, `testA()` is only documented once:
> 
> ![Screenshot 2025-05-08 at 15 52 16](https://github.com/user-attachments/assets/a6b86a21-7104-460c-8f3f-36cee5962eed)

Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

 - revert back to simple earlier fix
 - revert back to master
 - Merge branch 'master' into duplicate-APIs
 - Merge branch 'master' into duplicate-APIs
 - rename test to be more accurate and simplify code
 - update javadoc
 - Merge branch 'master' into duplicate-APIs
 - new approach - make sure there is no negative effect on JDK doc output
 - revert VisibleMemberTable back to master
 - fix comment
 - ... and 2 more: https://git.openjdk.org/jdk/compare/e6258c6a...b53817df

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25123/files
  - new: https://git.openjdk.org/jdk/pull/25123/files/4c645c7b..b53817df

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25123&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25123&range=04-05

  Stats: 135722 lines in 2162 files changed: 74850 ins; 42446 del; 18426 mod
  Patch: https://git.openjdk.org/jdk/pull/25123.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25123/head:pull/25123

PR: https://git.openjdk.org/jdk/pull/25123

From nbenalla at openjdk.org  Mon Jun  2 15:10:03 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Mon, 2 Jun 2025 15:10:03 GMT
Subject: Withdrawn: 8139744: Types referred in @link/@linkplain tags are not
 always hyperlinks
In-Reply-To: <8jpSUqhl0kuV3xBG5zrZSRq07fTXoHEtfjiYbg2rxQg=.76d4d253-9890-4f8e-853c-bf7fef95d577@github.com>
References: <8jpSUqhl0kuV3xBG5zrZSRq07fTXoHEtfjiYbg2rxQg=.76d4d253-9890-4f8e-853c-bf7fef95d577@github.com>
Message-ID: <5ZS4VCIyxv_xcm8OlYMnVv1XTncCB2WNgFlvjVUaGtk=.9f353ee2-d7a8-4ee7-ad3b-e5088862f121@github.com>

On Mon, 12 May 2025 15:58:11 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this patch to emit a new warning if the reference element cannot be linked. This is intended to prevent links to private member in the JDK docs (see https://bugs.openjdk.org/browse/JDK-8310868).
> 
> Here is a [clear example](https://download.java.net/java/early_access/jdk25/docs/api/java.base/java/net/Socket.html#shutdownOutput()) of this bug:
> 
> <img width="1071" alt="Screenshot 2025-05-12 at 16 55 26" src="https://github.com/user-attachments/assets/9bbca975-7f41-4970-9735-95906b402534" />
> 
> We should link to `sInputShutdown()` instead.
> 
> 
> Some private fields are [documented](https://download.java.net/java/early_access/jdk25/docs/api/serialized-form.html#java.awt.Frame) on the Serialization page if the class is serializable. After this patch, warnings will be emitted if a there is an incorrect link in their javadoc. 
> 
> Similar to the image below where the there is no hypertext and the link is rendered as plain text, because the linked method is private.
> <img width="422" alt="Screenshot 2025-05-12 at 16 53 56" src="https://github.com/user-attachments/assets/847a2acc-f289-4048-b239-77baa87a01ea" />
> 
> This bug can also creep in later without the author noticing, if they add a new method and javadoc matches it instead.
> 
> 
> Note: This PR can only be integrated after all site bugs are fixed in [JDK-8356549.](https://bugs.openjdk.org/browse/JDK-8356549)

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/25187

From nbenalla at openjdk.org  Mon Jun  2 15:10:03 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Mon, 2 Jun 2025 15:10:03 GMT
Subject: RFR: 8139744: Types referred in @link/@linkplain tags are not
 always hyperlinks
In-Reply-To: <8jpSUqhl0kuV3xBG5zrZSRq07fTXoHEtfjiYbg2rxQg=.76d4d253-9890-4f8e-853c-bf7fef95d577@github.com>
References: <8jpSUqhl0kuV3xBG5zrZSRq07fTXoHEtfjiYbg2rxQg=.76d4d253-9890-4f8e-853c-bf7fef95d577@github.com>
Message-ID: <K5z9qKYqfe5kqkchP6fVbTRitZCp_5TW2bvEBa_GyCA=.d58dfaa9-6a9e-4703-9afb-2f69ea69f3b8@github.com>

On Mon, 12 May 2025 15:58:11 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this patch to emit a new warning if the reference element cannot be linked. This is intended to prevent links to private member in the JDK docs (see https://bugs.openjdk.org/browse/JDK-8310868).
> 
> Here is a [clear example](https://download.java.net/java/early_access/jdk25/docs/api/java.base/java/net/Socket.html#shutdownOutput()) of this bug:
> 
> <img width="1071" alt="Screenshot 2025-05-12 at 16 55 26" src="https://github.com/user-attachments/assets/9bbca975-7f41-4970-9735-95906b402534" />
> 
> We should link to `sInputShutdown()` instead.
> 
> 
> Some private fields are [documented](https://download.java.net/java/early_access/jdk25/docs/api/serialized-form.html#java.awt.Frame) on the Serialization page if the class is serializable. After this patch, warnings will be emitted if a there is an incorrect link in their javadoc. 
> 
> Similar to the image below where the there is no hypertext and the link is rendered as plain text, because the linked method is private.
> <img width="422" alt="Screenshot 2025-05-12 at 16 53 56" src="https://github.com/user-attachments/assets/847a2acc-f289-4048-b239-77baa87a01ea" />
> 
> This bug can also creep in later without the author noticing, if they add a new method and javadoc matches it instead.
> 
> 
> Note: This PR can only be integrated after all site bugs are fixed in [JDK-8356549.](https://bugs.openjdk.org/browse/JDK-8356549)

Deferred to 26.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25187#issuecomment-2931179524

From weijun at openjdk.org  Mon Jun  2 15:19:56 2025
From: weijun at openjdk.org (Weijun Wang)
Date: Mon, 2 Jun 2025 15:19:56 GMT
Subject: RFR: 8357796: Stylesheet adjustments after JDK-8357452
In-Reply-To: <L4k3Fe7FKURlJXvWK3ZZnjxCDInkNjupSqvLhHbG18E=.449a8f72-3edc-4887-a8b3-53622eb78036@github.com>
References: <L4k3Fe7FKURlJXvWK3ZZnjxCDInkNjupSqvLhHbG18E=.449a8f72-3edc-4887-a8b3-53622eb78036@github.com>
Message-ID: <bf-29EulRKPYQrTxtB4wO09m-msNnZLZ5lap2TsCElI=.491ef650-d657-4353-9ba6-9fc6ddef48ce@github.com>

On Mon, 26 May 2025 16:52:13 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a simple stylesheet change to adjust for the removal of code span highlights in [JDK-8357452](https://bugs.openjdk.org/browse/JDK-8357452).
> 
> Both of the (subtle) changes undone in this PR were introduced with code span highlights and are no longer needed.

Thanks for the screenshots. I can see the difference, though I don't have a strong preference either way. If this is about reverting to an older format that everyone was happy with, I'm fully in favor of the change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25454#issuecomment-2931221749

From hannesw at openjdk.org  Mon Jun  2 15:29:56 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Mon, 2 Jun 2025 15:29:56 GMT
Subject: Integrated: 8357796: Stylesheet adjustments after JDK-8357452
In-Reply-To: <L4k3Fe7FKURlJXvWK3ZZnjxCDInkNjupSqvLhHbG18E=.449a8f72-3edc-4887-a8b3-53622eb78036@github.com>
References: <L4k3Fe7FKURlJXvWK3ZZnjxCDInkNjupSqvLhHbG18E=.449a8f72-3edc-4887-a8b3-53622eb78036@github.com>
Message-ID: <EybQxiVpFLDz3uMrkH5buDJUPdfT9MX2bj009fzvcpE=.302ec527-9bf2-4a5b-8ce7-38dc87578545@github.com>

On Mon, 26 May 2025 16:52:13 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a simple stylesheet change to adjust for the removal of code span highlights in [JDK-8357452](https://bugs.openjdk.org/browse/JDK-8357452).
> 
> Both of the (subtle) changes undone in this PR were introduced with code span highlights and are no longer needed.

This pull request has now been integrated.

Changeset: daab7b5c
Author:    Hannes Walln?fer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/daab7b5ceeb12222bda709e35699e620b98cb74d
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

8357796: Stylesheet adjustments after JDK-8357452

Reviewed-by: rriggs

-------------

PR: https://git.openjdk.org/jdk/pull/25454

From nbenalla at openjdk.org  Tue Jun  3 15:07:15 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 3 Jun 2025 15:07:15 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v7]
In-Reply-To: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
Message-ID: <6lA92Ca1vGSP2ElA499bsoLB0IWLLZIkOInukKHNIig=.e842af30-45ea-4396-96dd-149488509902@github.com>

> Please review this patch to fix a bug where a method can be documented multiple times 
> Consider these 4 classes
> 
>                     A       (interface)
>                    / \
>                   /   \
> (abstract class)  C     B   ( interface)
>                   \   /
>                    \ /
>                     D       (class)
> 
> 
> Where `A` declares `testA()`, `C` implements it `public final void testA()`, `B` extends `A` but does *not* override it, `D` extends `C` and implements `B`
> 
> In the generated javadoc, `testA()` is documented twice.
> 
> ![Screenshot 2025-05-08 at 15 51 19](https://github.com/user-attachments/assets/46538e61-1546-4128-8041-296d8491406f)
> 
> After the patch, `testA()` is only documented once:
> 
> ![Screenshot 2025-05-08 at 15 52 16](https://github.com/user-attachments/assets/a6b86a21-7104-460c-8f3f-36cee5962eed)

Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:

 - Feedback from @hns -  Expand test with new test cases
 - Merge branch 'master' into duplicate-APIs
 - revert back to simple earlier fix
 - revert back to master
 - Merge branch 'master' into duplicate-APIs
 - Merge branch 'master' into duplicate-APIs
 - rename test to be more accurate and simplify code
 - update javadoc
 - Merge branch 'master' into duplicate-APIs
 - new approach - make sure there is no negative effect on JDK doc output
 - ... and 4 more: https://git.openjdk.org/jdk/compare/2b6d4491...caeb20ad

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25123/files
  - new: https://git.openjdk.org/jdk/pull/25123/files/b53817df..caeb20ad

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25123&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25123&range=05-06

  Stats: 3417 lines in 146 files changed: 2689 ins; 307 del; 421 mod
  Patch: https://git.openjdk.org/jdk/pull/25123.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25123/head:pull/25123

PR: https://git.openjdk.org/jdk/pull/25123

From ihse at openjdk.org  Tue Jun  3 17:52:57 2025
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 3 Jun 2025 17:52:57 GMT
Subject: RFR: 8356977: UTF-8 cleanups [v2]
In-Reply-To: <QDrGzqvDzyZaQMSG3oplXlRSGMmGAMsQPeNnu8G4msU=.5f385862-0ca1-4b20-a31d-0c9e142728b7@github.com>
References: <s4znWc8WCK3liY8YOhRldnBN7yPJr8m-doBeEArSHd0=.0632ae03-da95-4bd5-865f-e8276544bed5@github.com>
 <QDrGzqvDzyZaQMSG3oplXlRSGMmGAMsQPeNnu8G4msU=.5f385862-0ca1-4b20-a31d-0c9e142728b7@github.com>
Message-ID: <DsuF98gTV85TRV5ofvmvH_-7fKmRNk28rI3RJV4e6Gk=.bc6bd102-147c-497e-9734-1bf6863060df@github.com>

On Mon, 26 May 2025 08:20:19 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I found a few other places in the code that can be cleaned up after the conversion to UTF-8.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Restore MenuShortcut.java
>  - Restore LocaleDataTest.java

@naotoj Are you happy with the other changes?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25228#issuecomment-2936435086

From naoto at openjdk.org  Tue Jun  3 17:52:55 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 3 Jun 2025 17:52:55 GMT
Subject: RFR: 8356977: UTF-8 cleanups [v3]
In-Reply-To: <9mEkfsOwQAc6LbxKWQHEMF4GbH_icsLrA_JPWDcIAck=.ec8f6cb8-efa5-4d6f-aadc-c1264ee1dd1a@github.com>
References: <s4znWc8WCK3liY8YOhRldnBN7yPJr8m-doBeEArSHd0=.0632ae03-da95-4bd5-865f-e8276544bed5@github.com>
 <9mEkfsOwQAc6LbxKWQHEMF4GbH_icsLrA_JPWDcIAck=.ec8f6cb8-efa5-4d6f-aadc-c1264ee1dd1a@github.com>
Message-ID: <gah_JMPE3xHcudSsDq_iqqxmTfi3edTCv8NCbKznr1M=.67bfc258-b96f-4d60-b2f7-cda514b11b68@github.com>

On Tue, 3 Jun 2025 17:42:37 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I found a few other places in the code that can be cleaned up after the conversion to UTF-8.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'master' into utf8-minor-cleanup
>  - Revert changes in RotFontBoundsTest.java
>  - Restore MenuShortcut.java
>  - Restore LocaleDataTest.java
>  - Replace uncessary unicode characters with ASCII in instructions, and fix typo
>  - Seems like typos in the comments
>  - Fix unicode sequences in comments (previously missed)

> @naotoj Are you happy with the other changes?

Yes. Thank you for the cleanup!

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25228#pullrequestreview-2893481166

From ihse at openjdk.org  Tue Jun  3 17:52:55 2025
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 3 Jun 2025 17:52:55 GMT
Subject: RFR: 8356977: UTF-8 cleanups [v3]
In-Reply-To: <s4znWc8WCK3liY8YOhRldnBN7yPJr8m-doBeEArSHd0=.0632ae03-da95-4bd5-865f-e8276544bed5@github.com>
References: <s4znWc8WCK3liY8YOhRldnBN7yPJr8m-doBeEArSHd0=.0632ae03-da95-4bd5-865f-e8276544bed5@github.com>
Message-ID: <9mEkfsOwQAc6LbxKWQHEMF4GbH_icsLrA_JPWDcIAck=.ec8f6cb8-efa5-4d6f-aadc-c1264ee1dd1a@github.com>

> I found a few other places in the code that can be cleaned up after the conversion to UTF-8.

Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'master' into utf8-minor-cleanup
 - Revert changes in RotFontBoundsTest.java
 - Restore MenuShortcut.java
 - Restore LocaleDataTest.java
 - Replace uncessary unicode characters with ASCII in instructions, and fix typo
 - Seems like typos in the comments
 - Fix unicode sequences in comments (previously missed)

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25228/files
  - new: https://git.openjdk.org/jdk/pull/25228/files/7184e685..c3027c1a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25228&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25228&range=01-02

  Stats: 125596 lines in 1865 files changed: 71361 ins; 38692 del; 15543 mod
  Patch: https://git.openjdk.org/jdk/pull/25228.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25228/head:pull/25228

PR: https://git.openjdk.org/jdk/pull/25228

From ihse at openjdk.org  Wed Jun  4 08:14:23 2025
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 4 Jun 2025 08:14:23 GMT
Subject: Integrated: 8356977: UTF-8 cleanups
In-Reply-To: <s4znWc8WCK3liY8YOhRldnBN7yPJr8m-doBeEArSHd0=.0632ae03-da95-4bd5-865f-e8276544bed5@github.com>
References: <s4znWc8WCK3liY8YOhRldnBN7yPJr8m-doBeEArSHd0=.0632ae03-da95-4bd5-865f-e8276544bed5@github.com>
Message-ID: <At8VnpzuhZYQNUNMKjqDDQJWpn-95O-PP01qGcpOB20=.8371e2ec-5f36-4a13-b566-6482ac2b6667@github.com>

On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I found a few other places in the code that can be cleaned up after the conversion to UTF-8.

This pull request has now been integrated.

Changeset: edf92721
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/edf92721c2db4cfba091cf4901af603db8486951
Stats:     15 lines in 13 files changed: 0 ins; 0 del; 15 mod

8356977: UTF-8 cleanups

Reviewed-by: naoto, prr

-------------

PR: https://git.openjdk.org/jdk/pull/25228

From nbenalla at openjdk.org  Wed Jun  4 15:12:19 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Wed, 4 Jun 2025 15:12:19 GMT
Subject: RFR: 8349369:
 test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on
 missing man page files
In-Reply-To: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
References: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
Message-ID: <wPkN_C92E9-UOyiwPVjW12-5K4o5C1Oyc1NDGXIFEho=.041413ff-2d30-4792-9f8c-c34e9f510701@github.com>

On Tue, 4 Feb 2025 14:39:49 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this small update to make the test more robust, the test did not always check links to other files if they did not contain a fragment or a `#`symbol.
> 
> I'd like to add that the original [doccheck](https://github.com/openjdk/doccheck) also didn't pick up on these missing files when I ran it. 
> 
> TIA

I made improvements based on the review feedback, the test now catches missing files.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23441#issuecomment-2940406233

From nbenalla at openjdk.org  Wed Jun  4 15:12:19 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Wed, 4 Jun 2025 15:12:19 GMT
Subject: RFR: 8349369:
 test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on
 missing man page files [v2]
In-Reply-To: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
References: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
Message-ID: <SeyZuTwB2dJNIK6UgwoltDClGq3SKZedekktGqB71VM=.f4995c50-91ca-462f-accb-ec8712986012@github.com>

> Please review this small update to make the test more robust, the test did not always check links to other files if they did not contain a fragment or a `#`symbol.
> 
> I'd like to add that the original [doccheck](https://github.com/openjdk/doccheck) also didn't pick up on these missing files when I ran it. 
> 
> TIA

Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - improve based on feedback
 - Merge branch 'master' into update-link-checker
 - Merge branch 'master' into update-link-checker
 - Merge branch 'master' into update-link-checker
 - update link checker to verify that files exist

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23441/files
  - new: https://git.openjdk.org/jdk/pull/23441/files/b0fcb616..95eb3cec

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23441&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23441&range=00-01

  Stats: 658029 lines in 9092 files changed: 275680 ins; 327663 del; 54686 mod
  Patch: https://git.openjdk.org/jdk/pull/23441.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23441/head:pull/23441

PR: https://git.openjdk.org/jdk/pull/23441

From hannesw at openjdk.org  Thu Jun  5 09:39:58 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Thu, 5 Jun 2025 09:39:58 GMT
Subject: RFR: 8349369:
 test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on
 missing man page files [v2]
In-Reply-To: <SeyZuTwB2dJNIK6UgwoltDClGq3SKZedekktGqB71VM=.f4995c50-91ca-462f-accb-ec8712986012@github.com>
References: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
 <SeyZuTwB2dJNIK6UgwoltDClGq3SKZedekktGqB71VM=.f4995c50-91ca-462f-accb-ec8712986012@github.com>
Message-ID: <W7_DHtwALmVqw0TbbfHHkdnAU4wf4Gv7iYgFFL5Ztas=.ac6ac0bc-b438-49cd-92fc-3815485d7d56@github.com>

On Wed, 4 Jun 2025 15:12:19 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this small update to make the test more robust, the test did not always check links to other files if they did not contain a fragment or a `#`symbol.
>> 
>> I'd like to add that the original [doccheck](https://github.com/openjdk/doccheck) also didn't pick up on these missing files when I ran it. 
>> 
>> TIA
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - improve based on feedback
>  - Merge branch 'master' into update-link-checker
>  - Merge branch 'master' into update-link-checker
>  - Merge branch 'master' into update-link-checker
>  - update link checker to verify that files exist

test/docs/jdk/javadoc/doccheck/doccheckutils/checkers/LinkChecker.java line 223:

> 221:     @Override
> 222:     public boolean isOK() {
> 223:         return log.noErrors() && (missingFiles == 0);

In method `reportMissingFile` where `missingFiles` is increased an error is also logged, so I'm wondering is the `missingFiles` check needed here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23441#discussion_r2128409772

From nbenalla at openjdk.org  Thu Jun  5 10:31:57 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Thu, 5 Jun 2025 10:31:57 GMT
Subject: RFR: 8349369:
 test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on
 missing man page files [v2]
In-Reply-To: <W7_DHtwALmVqw0TbbfHHkdnAU4wf4Gv7iYgFFL5Ztas=.ac6ac0bc-b438-49cd-92fc-3815485d7d56@github.com>
References: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
 <SeyZuTwB2dJNIK6UgwoltDClGq3SKZedekktGqB71VM=.f4995c50-91ca-462f-accb-ec8712986012@github.com>
 <W7_DHtwALmVqw0TbbfHHkdnAU4wf4Gv7iYgFFL5Ztas=.ac6ac0bc-b438-49cd-92fc-3815485d7d56@github.com>
Message-ID: <reOhmcwos_2UDS6vfpI9Blxwp4rqRYvNDzjqUCfO4QE=.71ae63e1-1f13-4d41-bb4f-250212fdc1ac@github.com>

On Thu, 5 Jun 2025 09:37:14 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - improve based on feedback
>>  - Merge branch 'master' into update-link-checker
>>  - Merge branch 'master' into update-link-checker
>>  - Merge branch 'master' into update-link-checker
>>  - update link checker to verify that files exist
>
> test/docs/jdk/javadoc/doccheck/doccheckutils/checkers/LinkChecker.java line 223:
> 
>> 221:     @Override
>> 222:     public boolean isOK() {
>> 223:         return log.noErrors() && (missingFiles == 0);
> 
> In method `reportMissingFile` where `missingFiles` is increased an error is also logged, so I'm wondering is the `missingFiles` check needed here?

I'd like to keep this extra check for safety for now.
I plan on updating these tests again for JDK 26 (updating the external link checker) so I could do more cleanup then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23441#discussion_r2128515936

From hannesw at openjdk.org  Thu Jun  5 10:56:02 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Thu, 5 Jun 2025 10:56:02 GMT
Subject: RFR: 8349369:
 test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on
 missing man page files [v2]
In-Reply-To: <SeyZuTwB2dJNIK6UgwoltDClGq3SKZedekktGqB71VM=.f4995c50-91ca-462f-accb-ec8712986012@github.com>
References: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
 <SeyZuTwB2dJNIK6UgwoltDClGq3SKZedekktGqB71VM=.f4995c50-91ca-462f-accb-ec8712986012@github.com>
Message-ID: <s0i4hxPog9DcoUlf4XU7dvx-dDTC1Ok2wcETySPV1qI=.dcbedfdf-c9af-44b0-a9d5-c9b5f4bde81b@github.com>

On Wed, 4 Jun 2025 15:12:19 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this small update to make the test more robust, the test did not always check links to other files if they did not contain a fragment or a `#`symbol.
>> 
>> I'd like to add that the original [doccheck](https://github.com/openjdk/doccheck) also didn't pick up on these missing files when I ran it. 
>> 
>> TIA
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - improve based on feedback
>  - Merge branch 'master' into update-link-checker
>  - Merge branch 'master' into update-link-checker
>  - Merge branch 'master' into update-link-checker
>  - update link checker to verify that files exist

Looks good to me.

-------------

Marked as reviewed by hannesw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23441#pullrequestreview-2899824560

From nbenalla at openjdk.org  Thu Jun  5 11:09:05 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Thu, 5 Jun 2025 11:09:05 GMT
Subject: RFR: 8349369:
 test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on
 missing man page files [v2]
In-Reply-To: <SeyZuTwB2dJNIK6UgwoltDClGq3SKZedekktGqB71VM=.f4995c50-91ca-462f-accb-ec8712986012@github.com>
References: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
 <SeyZuTwB2dJNIK6UgwoltDClGq3SKZedekktGqB71VM=.f4995c50-91ca-462f-accb-ec8712986012@github.com>
Message-ID: <HEsb3cxjLucCRF5cIFLaHJYZnO1Ei-CZTpWsmbwg4tY=.9e723788-c0d6-40e4-b543-80693e972fd5@github.com>

On Wed, 4 Jun 2025 15:12:19 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this small update to make the test more robust, the test did not always check links to other files if they did not contain a fragment or a `#`symbol.
>> 
>> I'd like to add that the original [doccheck](https://github.com/openjdk/doccheck) also didn't pick up on these missing files when I ran it. 
>> 
>> TIA
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - improve based on feedback
>  - Merge branch 'master' into update-link-checker
>  - Merge branch 'master' into update-link-checker
>  - Merge branch 'master' into update-link-checker
>  - update link checker to verify that files exist

Thank you for reviewing!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23441#issuecomment-2943743904

From nbenalla at openjdk.org  Thu Jun  5 11:09:05 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Thu, 5 Jun 2025 11:09:05 GMT
Subject: Integrated: 8349369:
 test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on
 missing man page files
In-Reply-To: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
References: <XFGYLVCil0or1A5UwmBxnFl0d4SpVZ7fWbcxVN6yGHk=.2d6ec2b6-7b2b-450a-aede-881cb7b033d5@github.com>
Message-ID: <toXDK1Cj1KmDnr-ldiohk9MGOO5d9Ah-kc_Oex89bZs=.2a5f7446-c4ab-4845-8a45-0c518a32ae67@github.com>

On Tue, 4 Feb 2025 14:39:49 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Please review this small update to make the test more robust, the test did not always check links to other files if they did not contain a fragment or a `#`symbol.
> 
> I'd like to add that the original [doccheck](https://github.com/openjdk/doccheck) also didn't pick up on these missing files when I ran it. 
> 
> TIA

This pull request has now been integrated.

Changeset: c5daf890
Author:    Nizar Benalla <nbenalla at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c5daf890534dfdbe5f66189ef6b08af8ffd4de47
Stats:     28 lines in 3 files changed: 8 ins; 6 del; 14 mod

8349369: test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on missing man page files

Reviewed-by: hannesw

-------------

PR: https://git.openjdk.org/jdk/pull/23441

From syan at openjdk.org  Tue Jun 10 07:30:53 2025
From: syan at openjdk.org (SendaoYan)
Date: Tue, 10 Jun 2025 07:30:53 GMT
Subject: RFR: 8359083: Test jdkCheckHtml.java should report SkippedException
 rather than report fails when miss tidy
Message-ID: <E-UVc4mCXUWjm_ss36fZTTrFHRuo0B5cX1QoWuudOM0=.fa2f1bae-cbb0-49f0-b9fb-d7e6a466afb8@github.com>

Hi all,

When there is no `tidy` command in PATH, the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java report failure, I think it shoule be report jtreg.SkippedException rather than report test failure.
In file test/docs/jdk/javadoc/doccheck/DocCheck.java, we need to call the `new TidyChecker()` before executing the test so that the `jtreg.SkippedException` exception can be thrown normally, that's why I add `new TidyChecker()` in `init()` function.

Change has been verified locally, only the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java observed this failure, test-fix only, no risk.

-------------

Commit messages:
 - 8359083: Test jdkCheckHtml.java should report SkippedException rather than report fails when miss tidy

Changes: https://git.openjdk.org/jdk/pull/25711/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25711&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8359083
  Stats: 10 lines in 3 files changed: 4 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/25711.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25711/head:pull/25711

PR: https://git.openjdk.org/jdk/pull/25711

From hannesw at openjdk.org  Tue Jun 10 10:11:07 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 10 Jun 2025 10:11:07 GMT
Subject: RFR: 8359024: Accessibility bugs in API documentation
Message-ID: <A0GfwWeQnx-1AbbWk7-jRKkgCB8FebSxzK1kRmdFhB0=.cc400ad7-30d7-4f45-808e-9631f11c0b18@github.com>

Please review a change to fix a couple of accessibility errors in JDK API documentation as detected by our accessibility testing. 

 - Contrast between link and normal text colors was below 3 and therefore would have required other styling (such as underlining). This was fixed by slightly darkening text color (our text color isn't black but dark-gray).
    Resulting colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=FFFFFF&lcolor=437291

 - Links in the headings of inherited member summaries used the wrong color and contrast to background color was below 4.5. This is fixed by removing a bogus `.expanded` selector that shouldn't have been there in the first place.
    Resulting colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=47688A

- Remove the `role="tablist"` and `aria-orientation="horizontal"` attributes from table captions if they do not contain tabs. This is the only code change, and the only change that comes with a test change (I guess the CSS changes are `noreg-hard` as we don't have a way to do automatic accessibility testing).

All changes are invisible or so subtle that they are practically impossible to spot in normal browsing, so I spare myself the task of uploading demo docs.

-------------

Commit messages:
 - JDK-8359024: Accessibility bugs in API documentation

Changes: https://git.openjdk.org/jdk/pull/25716/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25716&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8359024
  Stats: 40 lines in 4 files changed: 2 ins; 2 del; 36 mod
  Patch: https://git.openjdk.org/jdk/pull/25716.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25716/head:pull/25716

PR: https://git.openjdk.org/jdk/pull/25716

From liach at openjdk.org  Tue Jun 10 13:56:32 2025
From: liach at openjdk.org (Chen Liang)
Date: Tue, 10 Jun 2025 13:56:32 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v7]
In-Reply-To: <6lA92Ca1vGSP2ElA499bsoLB0IWLLZIkOInukKHNIig=.e842af30-45ea-4396-96dd-149488509902@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
 <6lA92Ca1vGSP2ElA499bsoLB0IWLLZIkOInukKHNIig=.e842af30-45ea-4396-96dd-149488509902@github.com>
Message-ID: <f2iGMnzxY8O2mAB8AHQLNlW1ljUAvPPwWUwCI5VE2MI=.ea72473b-6b70-40e6-a8d4-c2e93ef8b36a@github.com>

On Tue, 3 Jun 2025 15:07:15 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this patch to fix a bug where a method can be documented multiple times 
>> Consider these 4 classes
>> 
>>                     A       (interface)
>>                    / \
>>                   /   \
>> (abstract class)  C     B   ( interface)
>>                   \   /
>>                    \ /
>>                     D       (class)
>> 
>> 
>> Where `A` declares `testA()`, `C` implements it `public final void testA()`, `B` extends `A` but does *not* override it, `D` extends `C` and implements `B`
>> 
>> In the generated javadoc, `testA()` is documented twice.
>> 
>> ![Screenshot 2025-05-08 at 15 51 19](https://github.com/user-attachments/assets/46538e61-1546-4128-8041-296d8491406f)
>> 
>> After the patch, `testA()` is only documented once:
>> 
>> ![Screenshot 2025-05-08 at 15 52 16](https://github.com/user-attachments/assets/a6b86a21-7104-460c-8f3f-36cee5962eed)
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - Feedback from @hns -  Expand test with new test cases
>  - Merge branch 'master' into duplicate-APIs
>  - revert back to simple earlier fix
>  - revert back to master
>  - Merge branch 'master' into duplicate-APIs
>  - Merge branch 'master' into duplicate-APIs
>  - rename test to be more accurate and simplify code
>  - update javadoc
>  - Merge branch 'master' into duplicate-APIs
>  - new approach - make sure there is no negative effect on JDK doc output
>  - ... and 4 more: https://git.openjdk.org/jdk/compare/845f8445...caeb20ad

Looks identical to the initial version.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25123#pullrequestreview-2913695172

From hannesw at openjdk.org  Tue Jun 10 14:10:30 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 10 Jun 2025 14:10:30 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v7]
In-Reply-To: <f2iGMnzxY8O2mAB8AHQLNlW1ljUAvPPwWUwCI5VE2MI=.ea72473b-6b70-40e6-a8d4-c2e93ef8b36a@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
 <6lA92Ca1vGSP2ElA499bsoLB0IWLLZIkOInukKHNIig=.e842af30-45ea-4396-96dd-149488509902@github.com>
 <f2iGMnzxY8O2mAB8AHQLNlW1ljUAvPPwWUwCI5VE2MI=.ea72473b-6b70-40e6-a8d4-c2e93ef8b36a@github.com>
Message-ID: <1x-4FrJcu1sgcEfyktsunL4Af8YYTY7HLK9mq0RH0Dg=.a6450e56-0467-48e4-bae7-b4b81aa99aa3@github.com>

On Tue, 10 Jun 2025 13:53:37 GMT, Chen Liang <liach at openjdk.org> wrote:

> Looks identical to the initial version.

@liach I realized the first version was right after all (see my comment above). We should not document a method as inherited from some interface when it is implemented in the local class or some superclass. So this gets rid of duplicate inherited methods, such as `equals(Object)` in HashMap appearing as inherited [both from class AbstractMap and interface Map][1].

[1]: https://download.java.net/java/early_access/jdk25/docs/api/java.base/java/util/HashMap.html#methods-inherited-from-class-java.util.AbstractMap

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25123#issuecomment-2959409014

From hannesw at openjdk.org  Tue Jun 10 14:22:38 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 10 Jun 2025 14:22:38 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v7]
In-Reply-To: <6lA92Ca1vGSP2ElA499bsoLB0IWLLZIkOInukKHNIig=.e842af30-45ea-4396-96dd-149488509902@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
 <6lA92Ca1vGSP2ElA499bsoLB0IWLLZIkOInukKHNIig=.e842af30-45ea-4396-96dd-149488509902@github.com>
Message-ID: <Bzp2Qfxx3loNVopJJUVh5z0WZljvMo8W0SDM96IOk1o=.69080ab6-589c-4b7d-bb7a-df13fa20fc12@github.com>

On Tue, 3 Jun 2025 15:07:15 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this patch to fix a bug where a method can be documented multiple times 
>> Consider these 4 classes
>> 
>>                     A       (interface)
>>                    / \
>>                   /   \
>> (abstract class)  C     B   ( interface)
>>                   \   /
>>                    \ /
>>                     D       (class)
>> 
>> 
>> Where `A` declares `testA()`, `C` implements it `public final void testA()`, `B` extends `A` but does *not* override it, `D` extends `C` and implements `B`
>> 
>> In the generated javadoc, `testA()` is documented twice.
>> 
>> ![Screenshot 2025-05-08 at 15 51 19](https://github.com/user-attachments/assets/46538e61-1546-4128-8041-296d8491406f)
>> 
>> After the patch, `testA()` is only documented once:
>> 
>> ![Screenshot 2025-05-08 at 15 52 16](https://github.com/user-attachments/assets/a6b86a21-7104-460c-8f3f-36cee5962eed)
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - Feedback from @hns -  Expand test with new test cases
>  - Merge branch 'master' into duplicate-APIs
>  - revert back to simple earlier fix
>  - revert back to master
>  - Merge branch 'master' into duplicate-APIs
>  - Merge branch 'master' into duplicate-APIs
>  - rename test to be more accurate and simplify code
>  - update javadoc
>  - Merge branch 'master' into duplicate-APIs
>  - new approach - make sure there is no negative effect on JDK doc output
>  - ... and 4 more: https://git.openjdk.org/jdk/compare/8c772620...caeb20ad

test/langtools/jdk/javadoc/doclet/testDuplicateMethodsWarn/TestDuplicateMethods.java line 181:

> 179:         checkExit(Exit.OK);
> 180: 
> 181:         checkOutput("sb/U.html", false,

Could you add a positive check to this test and `testHashMapInheritance` that the method is documented as expected (as local method in this test, and as inherited from the public abstract class in `testHashMapInheritance`), and that the method details has a "Specified by: ..." entry for the interface method?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25123#discussion_r2138039054

From hannesw at openjdk.org  Wed Jun 11 11:20:27 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Wed, 11 Jun 2025 11:20:27 GMT
Subject: RFR: 8359083: Test jdkCheckHtml.java should report
 SkippedException rather than report fails when miss tidy
In-Reply-To: <E-UVc4mCXUWjm_ss36fZTTrFHRuo0B5cX1QoWuudOM0=.fa2f1bae-cbb0-49f0-b9fb-d7e6a466afb8@github.com>
References: <E-UVc4mCXUWjm_ss36fZTTrFHRuo0B5cX1QoWuudOM0=.fa2f1bae-cbb0-49f0-b9fb-d7e6a466afb8@github.com>
Message-ID: <UubpDsL7jRK1G7wzbuRuD3RmiLPEKZ0KytIv_dDvs44=.ffdb414e-a87c-48ba-b3a5-41432ee85486@github.com>

On Tue, 10 Jun 2025 07:21:34 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> When there is no `tidy` command in PATH, the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java report failure, I think it shoule be report jtreg.SkippedException rather than report test failure.
> In file test/docs/jdk/javadoc/doccheck/DocCheck.java, we need to call the `new TidyChecker()` before executing the test so that the `jtreg.SkippedException` exception can be thrown normally, that's why I add `new TidyChecker()` in `init()` function.
> 
> Change has been verified locally, only the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java observed this failure, test-fix only, no risk.

Changes look good to me.

-------------

Marked as reviewed by hannesw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25711#pullrequestreview-2916723187

From syan at openjdk.org  Thu Jun 12 08:20:33 2025
From: syan at openjdk.org (SendaoYan)
Date: Thu, 12 Jun 2025 08:20:33 GMT
Subject: RFR: 8359083: Test jdkCheckHtml.java should report
 SkippedException rather than report fails when miss tidy
In-Reply-To: <UubpDsL7jRK1G7wzbuRuD3RmiLPEKZ0KytIv_dDvs44=.ffdb414e-a87c-48ba-b3a5-41432ee85486@github.com>
References: <E-UVc4mCXUWjm_ss36fZTTrFHRuo0B5cX1QoWuudOM0=.fa2f1bae-cbb0-49f0-b9fb-d7e6a466afb8@github.com>
 <UubpDsL7jRK1G7wzbuRuD3RmiLPEKZ0KytIv_dDvs44=.ffdb414e-a87c-48ba-b3a5-41432ee85486@github.com>
Message-ID: <k5l3d6n8ymk3YiW05U0Fq_WE25CHyQQaxET_Tal07WU=.d699f2ae-da0d-4c2f-b5ad-6919cb213eb1@github.com>

On Wed, 11 Jun 2025 11:17:53 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> Hi all,
>> 
>> When there is no `tidy` command in PATH, the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java report failure, I think it shoule be report jtreg.SkippedException rather than report test failure.
>> In file test/docs/jdk/javadoc/doccheck/DocCheck.java, we need to call the `new TidyChecker()` before executing the test so that the `jtreg.SkippedException` exception can be thrown normally, that's why I add `new TidyChecker()` in `init()` function.
>> 
>> Change has been verified locally, only the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java observed this failure, test-fix only, no risk.
>
> Changes look good to me.

Thanks @hns for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25711#issuecomment-2965602148

From syan at openjdk.org  Thu Jun 12 08:20:33 2025
From: syan at openjdk.org (SendaoYan)
Date: Thu, 12 Jun 2025 08:20:33 GMT
Subject: Integrated: 8359083: Test jdkCheckHtml.java should report
 SkippedException rather than report fails when miss tidy
In-Reply-To: <E-UVc4mCXUWjm_ss36fZTTrFHRuo0B5cX1QoWuudOM0=.fa2f1bae-cbb0-49f0-b9fb-d7e6a466afb8@github.com>
References: <E-UVc4mCXUWjm_ss36fZTTrFHRuo0B5cX1QoWuudOM0=.fa2f1bae-cbb0-49f0-b9fb-d7e6a466afb8@github.com>
Message-ID: <0z0vfdXvi2srEP1cFIg8ZmrIXZPrntr-7pfGv_5CWlY=.9f49d930-04d7-4a2d-a380-76add994fffb@github.com>

On Tue, 10 Jun 2025 07:21:34 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> When there is no `tidy` command in PATH, the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java report failure, I think it shoule be report jtreg.SkippedException rather than report test failure.
> In file test/docs/jdk/javadoc/doccheck/DocCheck.java, we need to call the `new TidyChecker()` before executing the test so that the `jtreg.SkippedException` exception can be thrown normally, that's why I add `new TidyChecker()` in `init()` function.
> 
> Change has been verified locally, only the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java observed this failure, test-fix only, no risk.

This pull request has now been integrated.

Changeset: 3e0ef832
Author:    SendaoYan <syan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3e0ef832cc553c70eb7e8ee713c43aac67994b91
Stats:     10 lines in 3 files changed: 4 ins; 1 del; 5 mod

8359083: Test jdkCheckHtml.java should report SkippedException rather than report fails when miss tidy

Reviewed-by: hannesw

-------------

PR: https://git.openjdk.org/jdk/pull/25711

From vyazici at openjdk.org  Fri Jun 13 10:46:38 2025
From: vyazici at openjdk.org (Volkan Yazici)
Date: Fri, 13 Jun 2025 10:46:38 GMT
Subject: RFR: 8359024: Accessibility bugs in API documentation
In-Reply-To: <A0GfwWeQnx-1AbbWk7-jRKkgCB8FebSxzK1kRmdFhB0=.cc400ad7-30d7-4f45-808e-9631f11c0b18@github.com>
References: <A0GfwWeQnx-1AbbWk7-jRKkgCB8FebSxzK1kRmdFhB0=.cc400ad7-30d7-4f45-808e-9631f11c0b18@github.com>
Message-ID: <jI8wNFtW3t8X7he2CybQSc7m0A4Zc_T1XYKFG3lGdLQ=.9332f28b-ac50-4002-a536-915391fc66f8@github.com>

On Tue, 10 Jun 2025 10:04:46 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a change to fix a couple of accessibility errors in JDK API documentation as detected by our accessibility testing. 
> 
>  - Contrast between link and normal text colors was below 3 and therefore would have required other styling (such as underlining). This is fixed by slightly darkening text color (our text color isn't black but dark-gray).
>     Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=282828&bcolor=FFFFFF&lcolor=437291
>     New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=FFFFFF&lcolor=437291
> 
>  - Links in the headings of inherited member summaries used the wrong color and contrast to background color was below 4.5. This is fixed by removing a bogus `.expanded` selector that shouldn't have been there in the first place.
>     Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=437291
>     New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=47688A
> 
> - Remove the `role="tablist"` and `aria-orientation="horizontal"` attributes from table captions if they do not contain tabs. This is the only code change, and the only change that comes with a test change (I guess the CSS changes are `noreg-hard` as we don't have a way to do automatic accessibility testing).
> 
> All changes are invisible or so subtle that they are practically impossible to spot in normal browsing, so I spare myself the task of uploading demo docs.

Marked as reviewed by vyazici (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25716#pullrequestreview-2924278580

From achung at openjdk.org  Tue Jun 17 23:11:15 2025
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 17 Jun 2025 23:11:15 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update
Message-ID: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>

This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

-------------

Commit messages:
 - empty commit
 - redo ws fixes, add manual changes

Changes: https://git.openjdk.org/jdk/pull/25839/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8359761
  Stats: 1574 lines in 76 files changed: 810 ins; 93 del; 671 mod
  Patch: https://git.openjdk.org/jdk/pull/25839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839

PR: https://git.openjdk.org/jdk/pull/25839

From jlu at openjdk.org  Tue Jun 17 23:18:29 2025
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 17 Jun 2025 23:18:29 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <Cje6gKMQPt1zWBjiAY8j2JlM_29ACoaUVursuJyp_1E=.c55575ca-5cc2-422a-9694-cc7acd41804c@github.com>

On Tue, 17 Jun 2025 01:22:31 GMT, Alisen Chung <achung at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties line 2:

> 1: #
> 2: # Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights reserved.

Same as my comment in `src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java`

src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/resources/jdeprscan_de.properties line 26:

> 24: #
> 25: 
> 26: main.usage=Verwendung: jdeprscan [Optionen] ''{dir|jar|class}'' ...\n\nOptionen:\n        --class-path PATH\n        --for-removal\n        --full-version\n  -? -h --help\n  -l    --list\n        --release {0}\n  -v    --verbose\n        --version

Extra quotes, applies to other localized versions as well. (Usual change we revert)

src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java line 2:

> 1: /*
> 2:  * Copyright (c) 2001, 2023, Oracle and/or its affiliates. All rights reserved.

Looks wrong but is correct. File had its copyright year updated in https://bugs.openjdk.org/browse/JDK-8345800, but the original is still 2023. Translation team is re-syncing it to match the original year.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2153314389
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2153313105
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2153314152

From achung at openjdk.org  Tue Jun 17 23:18:27 2025
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 17 Jun 2025 23:18:27 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <-07gTVUiE_k1Kfc5m2OgDlX6fj1hUMYWZqsSK2YFlYc=.0fc07185-3be2-4f7c-b24f-fca061924170@github.com>

On Tue, 17 Jun 2025 01:22:31 GMT, Alisen Chung <achung at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

whitespace changes are fixed, PR is ready for review

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25839#issuecomment-2982077742

From jlu at openjdk.org  Tue Jun 17 23:24:28 2025
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 17 Jun 2025 23:24:28 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <41BnI9ePFiQiYk_COU-Rrpz0qzr33GN0p9AfF38Fkmk=.0d9c1020-d538-41b2-a939-f7e296029ae0@github.com>

On Tue, 17 Jun 2025 01:22:31 GMT, Alisen Chung <achung at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties line 30:

> 28: STARNN=*******************************************\n\n
> 29: # keytool: Help part
> 30: .OPTION.=\ [OPTION]...

We spoke about this offline. This is fine, property file values need to either start with a `\ `or `\u0020` to denote intentional leading white space. In this case, since we convert to UTF-8 native characters from escape sequences this gets included as well. Functionally, they are equivalent and the new form works well with the translation process.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2153321343

From achung at openjdk.org  Tue Jun 17 23:34:52 2025
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 17 Jun 2025 23:34:52 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  fix unicode escapes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25839/files
  - new: https://git.openjdk.org/jdk/pull/25839/files/2dfac379..d8027691

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=00-01

  Stats: 459 lines in 3 files changed: 0 ins; 0 del; 459 mod
  Patch: https://git.openjdk.org/jdk/pull/25839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839

PR: https://git.openjdk.org/jdk/pull/25839

From almatvee at openjdk.org  Tue Jun 17 23:43:28 2025
From: almatvee at openjdk.org (Alexander Matveev)
Date: Tue, 17 Jun 2025 23:43:28 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
Message-ID: <uLYnpuvdWyGcO615myaP0lHZ9HMiX9Ag27OnViwh5Ik=.cb34bbec-542b-40a6-98ab-270e2b63bcae@github.com>

On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix unicode escapes

jdk.jpackage changes looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25839#pullrequestreview-2937331933

From naoto at openjdk.org  Wed Jun 18 01:56:30 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 18 Jun 2025 01:56:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
Message-ID: <BF4ypBPsudR5UfcpmFRzHx4Xd_p2cBRj2LAC03wzbVs=.78a79e87-2808-40c0-b64b-795b526f366b@github.com>

On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix unicode escapes

src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage_de.properties line 1:

> 1: #

Just wondering why this resource file has not been translated into de/ja/zh_CN till now. Looks correct though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2153463170

From nbenalla at openjdk.org  Wed Jun 18 08:24:09 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Wed, 18 Jun 2025 08:24:09 GMT
Subject: RFR: 8358627:
 tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26
Message-ID: <mcPF1ypiHlYI3H4kgl0bwvU3KF_YO40Yo6aY6w1LX4c=.4376bebf-3397-4354-be3e-9fd0719b24db@github.com>

Once [8346295](https://bugs.openjdk.org/browse/JDK-8346295) is resolved, JavaBaseCheckSince no longer needs to be problemlisted.

-------------

Depends on: https://git.openjdk.org/jdk/pull/25854

Commit messages:
 - this test no longer needs to be problem listed

Changes: https://git.openjdk.org/jdk/pull/25855/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25855&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8358627
  Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/25855.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25855/head:pull/25855

PR: https://git.openjdk.org/jdk/pull/25855

From syan at openjdk.org  Wed Jun 18 08:24:09 2025
From: syan at openjdk.org (SendaoYan)
Date: Wed, 18 Jun 2025 08:24:09 GMT
Subject: RFR: 8358627:
 tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26
In-Reply-To: <mcPF1ypiHlYI3H4kgl0bwvU3KF_YO40Yo6aY6w1LX4c=.4376bebf-3397-4354-be3e-9fd0719b24db@github.com>
References: <mcPF1ypiHlYI3H4kgl0bwvU3KF_YO40Yo6aY6w1LX4c=.4376bebf-3397-4354-be3e-9fd0719b24db@github.com>
Message-ID: <pIXyfeX8Y6s_SUXaHrHY0qtGEWiKtsDC8XKO-XYX4oE=.bd768ada-25e9-4e63-a3a2-a8c1a700c012@github.com>

On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Once [8346295](https://bugs.openjdk.org/browse/JDK-8346295) is resolved, JavaBaseCheckSince no longer needs to be problemlisted.

Marked as reviewed by syan (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25855#pullrequestreview-2937604336

From nbenalla at openjdk.org  Wed Jun 18 09:08:29 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Wed, 18 Jun 2025 09:08:29 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
Message-ID: <xcSAVqLxI2phW8UCEHcDpUMeFySiy0zigXx-MPkt5aU=.0c203d6f-60e1-41d1-82d5-a93bba898f5f@github.com>

On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix unicode escapes

I'm unable to confirm the accuracy of the translations, since I don't speak the target languages. I've only reviewed the `jdk.javadoc` sources.

All keys in the English property files match one-to-one with those in the non-English files: there are no missing or extra entries. The only changes are to the `.properties` files, exactly as the PR title suggests.

>From the `jdk.javadoc` perspective, this looks good, so I'm happy to approve this PR.

-------------

Marked as reviewed by nbenalla (Committer).

PR Review: https://git.openjdk.org/jdk/pull/25839#pullrequestreview-2938377311

From jsikstro at openjdk.org  Wed Jun 18 09:50:30 2025
From: jsikstro at openjdk.org (Joel =?UTF-8?B?U2lrc3Ryw7Zt?=)
Date: Wed, 18 Jun 2025 09:50:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
Message-ID: <zJCQh_R1fU5XdBZNfVyW5e-hk_mRcfnjPASPqzu-t3s=.8b34a54f-3ae2-4516-a2b6-d5c32b3891b8@github.com>

On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix unicode escapes

Should the other localizations for the launcher help text (in `launcher_<lang>.properties`) also be updated? I see that only the German, Japanese and Chinese localizations have been updated so far.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25839#issuecomment-2983504760

From aivanov at openjdk.org  Wed Jun 18 16:15:35 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Jun 2025 16:15:35 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
Message-ID: <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>

On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix unicode escapes

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1:

> 1: # Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.

Shall the copyright year be updated?

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 460:

> 458: SliderDemo.a_plain_slider=Ein einfacher Schieberegler
> 459: SliderDemo.majorticks=Grobteilungen
> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen

Should the translation of `SliderDemo.majorticks` also be updated?

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 462:

> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
> 461: SliderDemo.ticks=Feinteilungen, Teilungen zum Einrasten und Labels
> 462: SliderDemo.minorticks=Feinteilungen

The following description uses different words now:

Feinteilungen -> Teilstrichen
Teilungen -> Teilstrichen

src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties line 183:

> 181: size.bit.alg=%1$d-Bit-%2$s
> 182: Generating.full.keyAlgName.key.pair.and.self.signed.certificate.sigAlgName.with.a.validity.of.days.for=Generieren von {0}-Schl?sselpaar und selbstsigniertem Zertifikat ({1}) mit einer G?ltigkeit von {2} Tagen\n\tf?r: {3}
> 183: Generating.full.keyAlgName.key.pair.and.a.certificate.sigAlgName.issued.by.signerAlias.with.a.validity.of.days.for=Generieren von {0}-Schl?sselpaar und einem von <{2}> ausgestellten Zertifikat ({1}) mit einer G?ltigkeit von {3} Tagen\n\tf?r: {4}

It feels as if there's something missing after _?einem?_.

src/java.base/share/classes/sun/security/util/resources/security_de.properties line 46:

> 44: invalid.null.action.provided=Ung?ltige Nullaktion angegeben
> 45: invalid.null.Class.provided=Ung?ltige Nullklasse angegeben
> 46: Subject.=Subject:\n

Is it correct? German usually uses `k`.

src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties line 56:

> 54: 
> 55: # javax.security.auth.login.AppConfigurationEntry
> 56: LoginModuleControlFlag.=LoginModuleControlFlag?\u0020

Is it intended to have two spaces instead of one? Or am I missing anything? The colon on the modified line looks slightly differently.

src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties line 220:

> 218: entry.1.is.signed.in.jarfile.but.is.not.signed.in.jarinputstream=Eintrag %s ist in JarFile, aber nicht in JarInputStream signiert
> 219: entry.1.is.signed.in.jarinputstream.but.is.not.signed.in.jarfile=Eintrag %s ist in JarInputStream, aber nicht in JarFile signiert
> 220: jar.contains.internal.inconsistencies.result.in.different.contents.via.jarfile.and.jarinputstream=Diese JAR-Datei enth?lt interne Inkonsistenzen, die zu anderem Inhalt beim Lesen ?ber JarFile als beim Lesen ?ber JarInputStream f?hren k?nnen:

Is it expected to have ?JAR_-Datei_?? It was removed from `.verified` and `.signed` strings.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_de.properties line 229:

> 227: doclet.search_in_documentation=In Dokumentation suchen
> 228: doclet.search_reset=Zur?cksetzen
> 229: doclet.Member=Member

Is `Member` translated? Should it be _?Mitglied?_?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2154931256
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2154807291
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2154813672
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2154907979
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2154905960
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2154915395
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2154968902
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2154985100

From jlu at openjdk.org  Wed Jun 18 16:24:29 2025
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 18 Jun 2025 16:24:29 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
Message-ID: <epU16E3XQ7BNcECTdZbJJpdFw05jYxEZ8Kt1yRx34nY=.a5624636-51ea-4466-83c2-6e0f7aa6aca1@github.com>

On Wed, 18 Jun 2025 15:28:49 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix unicode escapes
>
> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties line 56:
> 
>> 54: 
>> 55: # javax.security.auth.login.AppConfigurationEntry
>> 56: LoginModuleControlFlag.=LoginModuleControlFlag?\u0020
> 
> Is it intended to have two spaces instead of one? Or am I missing anything? The colon on the modified line looks slightly differently.

There is still only one space, the new one is a full width colon (U+FF1A). Localization rules have been observed to make the switch from regular colons (U+003A) into the full width version depending on the language.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2155032074

From jlu at openjdk.org  Wed Jun 18 16:28:30 2025
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 18 Jun 2025 16:28:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
Message-ID: <SpVZ52poJGvsBGyuVB8B91ZEje1QaAafXfnEovQx0-I=.640d1f5f-8222-402a-b075-dea1ea46bd81@github.com>

On Wed, 18 Jun 2025 15:34:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix unicode escapes
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1:
> 
>> 1: # Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
> 
> Shall the copyright year be updated?

In the past, we usually don't modify the copyright years and the translation team syncs the localized variants with the original file. In this case the original file did not have a change, simply the translations were updated with a "newer version".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2155038247

From aivanov at openjdk.org  Wed Jun 18 16:45:29 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 18 Jun 2025 16:45:29 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <SpVZ52poJGvsBGyuVB8B91ZEje1QaAafXfnEovQx0-I=.640d1f5f-8222-402a-b075-dea1ea46bd81@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <SpVZ52poJGvsBGyuVB8B91ZEje1QaAafXfnEovQx0-I=.640d1f5f-8222-402a-b075-dea1ea46bd81@github.com>
Message-ID: <ij3E2h5HHVXFll_xif0vHx4lrh6_QkTohC0rAZW2dGA=.03b17f7f-14cf-49bb-92c5-7f0033e6ccb7@github.com>

On Wed, 18 Jun 2025 16:25:29 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1:
>> 
>>> 1: # Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
>> 
>> Shall the copyright year be updated?
>
> In the past, we usually don't modify the copyright years and the translation team syncs the localized variants with the original file. In this case the original file did not have a change, simply the translations were updated with a "newer version".

This is weird? Usually, the copyright year is bumped up whenever the file is edited.

>> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties line 56:
>> 
>>> 54: 
>>> 55: # javax.security.auth.login.AppConfigurationEntry
>>> 56: LoginModuleControlFlag.=LoginModuleControlFlag?\u0020
>> 
>> Is it intended to have two spaces instead of one? Or am I missing anything? The colon on the modified line looks slightly differently.
>
> There is still only one space, the new one is a full width colon (U+FF1A). Localization rules have been observed to make the switch from regular colons (U+003A) into the full width version depending on the language.

Thank you for clarification.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2155071387
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2155071915

From naoto at openjdk.org  Wed Jun 18 16:58:34 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 18 Jun 2025 16:58:34 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <zJCQh_R1fU5XdBZNfVyW5e-hk_mRcfnjPASPqzu-t3s=.8b34a54f-3ae2-4516-a2b6-d5c32b3891b8@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <zJCQh_R1fU5XdBZNfVyW5e-hk_mRcfnjPASPqzu-t3s=.8b34a54f-3ae2-4516-a2b6-d5c32b3891b8@github.com>
Message-ID: <GMreFXOIVIHSDY6c8Vcze6uvKnnsOAaNIH6G5rBfkQA=.507f3521-b8a6-4024-a1ed-d41f71a9c1e1@github.com>

On Wed, 18 Jun 2025 09:47:57 GMT, Joel Sikstr?m <jsikstro at openjdk.org> wrote:

> Should the other localizations for the launcher help text (in `launcher_<lang>.properties`) also be updated? I see that only the German, Japanese and Chinese localizations have been updated so far.

Those languages (de/ja/zh-CN) are the ones we (Oracle) support. Other entities would be welcome to provide l10n for other languages (not a sporadic l10n, but commit to update/maintain).

> 
> Edit: I see that the other localizations haven't been updated for the last few releases, so maybe this is intentional. Still interested to know why we have the other localizations if they aren't updated.

Usuallly l10n resource updates are additions, so those old l10ns still have values for those languages. New additions will simply fall back to English.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25839#issuecomment-2985038815

From achung at openjdk.org  Wed Jun 18 18:42:54 2025
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 18 Jun 2025 18:42:54 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v3]
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <3Sb_Nj53MtMZRoKypbBFn0yumsFtiGJzY5fv60CilwA=.4ee9201b-0657-484b-8e69-01306c131b39@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  remove double quotes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25839/files
  - new: https://git.openjdk.org/jdk/pull/25839/files/d8027691..66c34e7d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=01-02

  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/25839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839

PR: https://git.openjdk.org/jdk/pull/25839

From dnguyen at openjdk.org  Wed Jun 18 18:50:29 2025
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 18 Jun 2025 18:50:29 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v3]
In-Reply-To: <Cje6gKMQPt1zWBjiAY8j2JlM_29ACoaUVursuJyp_1E=.c55575ca-5cc2-422a-9694-cc7acd41804c@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <Cje6gKMQPt1zWBjiAY8j2JlM_29ACoaUVursuJyp_1E=.c55575ca-5cc2-422a-9694-cc7acd41804c@github.com>
Message-ID: <dWF_2vYxbax6VWDCokd4Mlhsn3H7PV3crLJAofEfr90=.231f96e1-6130-41f4-abc5-53166ca93f48@github.com>

On Tue, 17 Jun 2025 23:15:05 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove double quotes
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2001, 2023, Oracle and/or its affiliates. All rights reserved.
> 
> Looks wrong but is correct. File had its copyright year updated in https://bugs.openjdk.org/browse/JDK-8345800, but the original is still 2023. Translation team is re-syncing it to match the original year.

Is there any way to prevent this or do we just change it back when we do a drop and explain why each time?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2155272483

From prr at openjdk.org  Wed Jun 18 20:40:29 2025
From: prr at openjdk.org (Phil Race)
Date: Wed, 18 Jun 2025 20:40:29 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
Message-ID: <a_GmJUtJTOEwCYk23UOkb03IWqfwuNI0GO1lXRJTGGY=.06afc484-9259-46d4-9384-9e93b08598c0@github.com>

On Wed, 18 Jun 2025 14:45:32 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix unicode escapes
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 460:
> 
>> 458: SliderDemo.a_plain_slider=Ein einfacher Schieberegler
>> 459: SliderDemo.majorticks=Grobteilungen
>> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
> 
> Should the translation of `SliderDemo.majorticks` also be updated?

I agree. I'd expect consistency here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2155451453

From duke at openjdk.org  Thu Jun 19 17:42:30 2025
From: duke at openjdk.org (Johannes =?UTF-8?B?RMO2Ymxlcg==?=)
Date: Thu, 19 Jun 2025 17:42:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
Message-ID: <yC5NAA2uzq92MZGyXJQkRYallBsQCJpF8vmemkndk9c=.c7bb4cff-9af0-4d25-9782-dbe35cafcfd8@github.com>

On Wed, 18 Jun 2025 15:25:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix unicode escapes
>
> src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties line 183:
> 
>> 181: size.bit.alg=%1$d-Bit-%2$s
>> 182: Generating.full.keyAlgName.key.pair.and.self.signed.certificate.sigAlgName.with.a.validity.of.days.for=Generieren von {0}-Schl?sselpaar und selbstsigniertem Zertifikat ({1}) mit einer G?ltigkeit von {2} Tagen\n\tf?r: {3}
>> 183: Generating.full.keyAlgName.key.pair.and.a.certificate.sigAlgName.issued.by.signerAlias.with.a.validity.of.days.for=Generieren von {0}-Schl?sselpaar und einem von <{2}> ausgestellten Zertifikat ({1}) mit einer G?ltigkeit von {3} Tagen\n\tf?r: {4}
> 
> It feels as if there's something missing after _?einem?_.

seems ok to me, einem von X ausgestellten Zertifikat ~ einem Zertifikat, das von X ausgestellt wurde

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2157444024

From henryjen at openjdk.org  Mon Jun 23 07:34:32 2025
From: henryjen at openjdk.org (Henry Jen)
Date: Mon, 23 Jun 2025 07:34:32 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <BF4ypBPsudR5UfcpmFRzHx4Xd_p2cBRj2LAC03wzbVs=.78a79e87-2808-40c0-b64b-795b526f366b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <BF4ypBPsudR5UfcpmFRzHx4Xd_p2cBRj2LAC03wzbVs=.78a79e87-2808-40c0-b64b-795b526f366b@github.com>
Message-ID: <KIsmHFx2cVbJJ-DDbarwf9NVbONDqpQr9BckHVXsZpA=.62a82ba6-00f5-4113-8d24-5d60ce5c47da@github.com>

On Wed, 18 Jun 2025 01:51:28 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix unicode escapes
>
> src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage_de.properties line 1:
> 
>> 1: #
> 
> Just wondering why this resource file has not been translated into de/ja/zh_CN till now. Looks correct though.

I am wondering the same thing. Perhaps because it is not intended for general public, it's not in the [JDK tools specifications](https://docs.oracle.com/en/java/javase/24/docs/specs/man/index.html).
If that was intentionally left out, I don't see new reason to add them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2160914804

From jlu at openjdk.org  Mon Jun 23 14:45:31 2025
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 23 Jun 2025 14:45:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v3]
In-Reply-To: <dWF_2vYxbax6VWDCokd4Mlhsn3H7PV3crLJAofEfr90=.231f96e1-6130-41f4-abc5-53166ca93f48@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <Cje6gKMQPt1zWBjiAY8j2JlM_29ACoaUVursuJyp_1E=.c55575ca-5cc2-422a-9694-cc7acd41804c@github.com>
 <dWF_2vYxbax6VWDCokd4Mlhsn3H7PV3crLJAofEfr90=.231f96e1-6130-41f4-abc5-53166ca93f48@github.com>
Message-ID: <BVN8gdSxc54F_PWYYXyMoHt4FDCeFNtN_vMeMSxIGoI=.beedc45e-7447-4e77-9553-ad1420bc512e@github.com>

On Wed, 18 Jun 2025 18:48:04 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2001, 2023, Oracle and/or its affiliates. All rights reserved.
>> 
>> Looks wrong but is correct. File had its copyright year updated in https://bugs.openjdk.org/browse/JDK-8345800, but the original is still 2023. Translation team is re-syncing it to match the original year.
>
> Is there any way to prevent this or do we just change it back when we do a drop and explain why each time?

If this is committed, then the years will be synced and we won't have to change it back. This would be consistent with the way we receive l10n translations which sync the copyright years of localized files to the original. 

If we want to deviate from this then we could file a request asking them to not update copyright years and we could update them ourselves.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2161805058

From jlu at openjdk.org  Mon Jun 23 14:57:30 2025
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 23 Jun 2025 14:57:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
Message-ID: <odr9SLW6_8t2_QsZRndgYFqyCZTVjXh6U6rnT_fL3uQ=.404af4de-b837-485e-a220-47419742434d@github.com>

On Wed, 18 Jun 2025 15:52:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix unicode escapes
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties line 220:
> 
>> 218: entry.1.is.signed.in.jarfile.but.is.not.signed.in.jarinputstream=Eintrag %s ist in JarFile, aber nicht in JarInputStream signiert
>> 219: entry.1.is.signed.in.jarinputstream.but.is.not.signed.in.jarfile=Eintrag %s ist in JarInputStream, aber nicht in JarFile signiert
>> 220: jar.contains.internal.inconsistencies.result.in.different.contents.via.jarfile.and.jarinputstream=Diese JAR-Datei enth?lt interne Inkonsistenzen, die zu anderem Inhalt beim Lesen ?ber JarFile als beim Lesen ?ber JarInputStream f?hren k?nnen:
> 
> Is it expected to have ?JAR_-Datei_?? It was removed from `.verified` and `.signed` strings.

I think it is because the English version of the properties file uses "jar" for `.verified` and `.signed` strings, but `jar.contains.internal.inconsistencies.result.in.different.contents.via.jarfile.and.jarinputstream` uses "JAR".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2161832785

From jlu at openjdk.org  Mon Jun 23 15:00:37 2025
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 23 Jun 2025 15:00:37 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
Message-ID: <M5xHiXsy_RXNKRklp3u-Rc0JJiVmUyKDAdZgTmURWbo=.3c8874b7-ffda-4ffe-910f-381607b78e29@github.com>

On Wed, 18 Jun 2025 15:59:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix unicode escapes
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_de.properties line 229:
> 
>> 227: doclet.search_in_documentation=In Dokumentation suchen
>> 228: doclet.search_reset=Zur?cksetzen
>> 229: doclet.Member=Member
> 
> Is `Member` translated? Should it be _?Mitglied?_?

Good catch. Usually, we file these issues with the translation team and make the appropriate updates in the second L10n drop. I think this one is fine to be updated now as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2161839290

From hannesw at openjdk.org  Mon Jun 23 15:51:31 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Mon, 23 Jun 2025 15:51:31 GMT
Subject: RFR: 8328848: Inaccuracy in the documentation of the -group option
In-Reply-To: <DfqH6RrQXPHHUf1uBCVbOTVEARdVEjk2maT-64sVK10=.a7af9f0e-f623-4c60-a846-12fc20f664b4@github.com>
References: <DfqH6RrQXPHHUf1uBCVbOTVEARdVEjk2maT-64sVK10=.a7af9f0e-f623-4c60-a846-12fc20f664b4@github.com>
Message-ID: <PqfmKWjSnNupGwLmoMeJAhVtAMPQlnAoyBK-HGOoNmo=.ffd61176-6590-4a9a-a91e-01acfa1f5a28@github.com>

On Tue, 13 May 2025 13:09:56 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a documentation fix in the `javadoc` man page to document that the `-group` option can be used with packages or modules depending on documented code. 
> 
> Although the help output of the `javadoc` tool already included this fact I replaced the abstract term "elements" with "packages or modules" to make it a bit more concrete.

@jddarcy could you please have a look at this trivial doc fix?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25212#issuecomment-2997003314

From achung at openjdk.org  Mon Jun 23 16:38:29 2025
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 23 Jun 2025 16:38:29 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <a_GmJUtJTOEwCYk23UOkb03IWqfwuNI0GO1lXRJTGGY=.06afc484-9259-46d4-9384-9e93b08598c0@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <a_GmJUtJTOEwCYk23UOkb03IWqfwuNI0GO1lXRJTGGY=.06afc484-9259-46d4-9384-9e93b08598c0@github.com>
Message-ID: <wjxC1HjQZ0pqyW-twJYYAjL6gH44ufgW53nkbNSLHRI=.848fbbb0-ebe7-4c55-9ae3-2996471c368c@github.com>

On Wed, 18 Jun 2025 20:37:43 GMT, Phil Race <prr at openjdk.org> wrote:

>> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 460:
>> 
>>> 458: SliderDemo.a_plain_slider=Ein einfacher Schieberegler
>>> 459: SliderDemo.majorticks=Grobteilungen
>>> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
>> 
>> Should the translation of `SliderDemo.majorticks` also be updated?
>
> I agree. I'd expect consistency here.

What would be the correct translation of majorticks here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162027420

From achung at openjdk.org  Mon Jun 23 16:38:31 2025
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 23 Jun 2025 16:38:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
Message-ID: <OZ262_JSW2vfezx4xU16MrfrecafkpCY6BuoG8nJgkU=.8ea6aecc-dd18-4799-a844-6139910d7aea@github.com>

On Wed, 18 Jun 2025 14:48:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix unicode escapes
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 462:
> 
>> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
>> 461: SliderDemo.ticks=Feinteilungen, Teilungen zum Einrasten und Labels
>> 462: SliderDemo.minorticks=Feinteilungen
> 
> The following description uses different words now:
> 
> Feinteilungen -> Teilstrichen
> Teilungen -> Teilstrichen

Just to clarify, does this mean

SliderDemo.ticks=Teilstrichen, Teilstrichen zum Einrasten und Labels
SliderDemo.minorticks=Teilstrichen

is correct?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162030543

From achung at openjdk.org  Mon Jun 23 16:38:31 2025
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 23 Jun 2025 16:38:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <KIsmHFx2cVbJJ-DDbarwf9NVbONDqpQr9BckHVXsZpA=.62a82ba6-00f5-4113-8d24-5d60ce5c47da@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <BF4ypBPsudR5UfcpmFRzHx4Xd_p2cBRj2LAC03wzbVs=.78a79e87-2808-40c0-b64b-795b526f366b@github.com>
 <KIsmHFx2cVbJJ-DDbarwf9NVbONDqpQr9BckHVXsZpA=.62a82ba6-00f5-4113-8d24-5d60ce5c47da@github.com>
Message-ID: <mX5C6udFi0d1gR80HpyQ9-9t-cf7fMUxdf1bDmLcxxE=.e343b549-8696-46b8-a7e9-4285bdc5d46d@github.com>

On Mon, 23 Jun 2025 07:31:34 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>> src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage_de.properties line 1:
>> 
>>> 1: #
>> 
>> Just wondering why this resource file has not been translated into de/ja/zh_CN till now. Looks correct though.
>
> I am wondering the same thing. Perhaps because it is not intended for general public, it's not in the [JDK tools specifications](https://docs.oracle.com/en/java/javase/24/docs/specs/man/index.html).
> If that was intentionally left out, I don't see new reason to add them.

This file wasn't originally in the tbom file when we first restarted translations and was picked up by our getChanges tool because of a recent update to the file some time after the previous drop, so it hasn't been translated until this drop. Maybe the previous team just forgot to translate this file?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162024606

From achung at openjdk.org  Mon Jun 23 16:44:23 2025
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 23 Jun 2025 16:44:23 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  update to german translations

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25839/files
  - new: https://git.openjdk.org/jdk/pull/25839/files/66c34e7d..90bfd7bd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/25839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839

PR: https://git.openjdk.org/jdk/pull/25839

From naoto at openjdk.org  Mon Jun 23 16:44:24 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 23 Jun 2025 16:44:24 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <mX5C6udFi0d1gR80HpyQ9-9t-cf7fMUxdf1bDmLcxxE=.e343b549-8696-46b8-a7e9-4285bdc5d46d@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <BF4ypBPsudR5UfcpmFRzHx4Xd_p2cBRj2LAC03wzbVs=.78a79e87-2808-40c0-b64b-795b526f366b@github.com>
 <KIsmHFx2cVbJJ-DDbarwf9NVbONDqpQr9BckHVXsZpA=.62a82ba6-00f5-4113-8d24-5d60ce5c47da@github.com>
 <mX5C6udFi0d1gR80HpyQ9-9t-cf7fMUxdf1bDmLcxxE=.e343b549-8696-46b8-a7e9-4285bdc5d46d@github.com>
Message-ID: <i1GseMJyfCL5uo-smr3SLsDUVkvWzdQheIzvVr5PpKY=.1281d6d5-c07e-47cc-bacc-8ea1161a3df9@github.com>

On Mon, 23 Jun 2025 16:32:21 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> I am wondering the same thing. Perhaps because it is not intended for general public, it's not in the [JDK tools specifications](https://docs.oracle.com/en/java/javase/24/docs/specs/man/index.html).
>> If that was intentionally left out, I don't see new reason to add them.
>
> This file wasn't originally in the tbom file when we first restarted translations and was picked up by our getChanges tool because of a recent update to the file some time after the previous drop, so it hasn't been translated until this drop. Maybe the previous team just forgot to translate this file?

Thanks. I guess this was simply an overlook in the first place, as the process was manual back then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162038459

From duke at openjdk.org  Mon Jun 23 17:41:29 2025
From: duke at openjdk.org (Johannes =?UTF-8?B?RMO2Ymxlcg==?=)
Date: Mon, 23 Jun 2025 17:41:29 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <wjxC1HjQZ0pqyW-twJYYAjL6gH44ufgW53nkbNSLHRI=.848fbbb0-ebe7-4c55-9ae3-2996471c368c@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <a_GmJUtJTOEwCYk23UOkb03IWqfwuNI0GO1lXRJTGGY=.06afc484-9259-46d4-9384-9e93b08598c0@github.com>
 <wjxC1HjQZ0pqyW-twJYYAjL6gH44ufgW53nkbNSLHRI=.848fbbb0-ebe7-4c55-9ae3-2996471c368c@github.com>
Message-ID: <KD-oruGQL9hUtmCexnxFdfMwwEud0SQCNo4HMW4l9-o=.37a8bead-5fe1-42b8-887e-fbe834794531@github.com>

On Mon, 23 Jun 2025 16:34:05 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> I agree. I'd expect consistency here.
>
> What would be the correct translation of majorticks here?

If "major tick" is translated to "Hauptteilstrich", then the plural would be `[SliderDemo.majorticks=]Hauptteilstriche` (which is a rather artificial word so the translation team might want to come up with a better translation for "major tick").

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162131034

From aivanov at openjdk.org  Mon Jun 23 18:45:30 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Jun 2025 18:45:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <odr9SLW6_8t2_QsZRndgYFqyCZTVjXh6U6rnT_fL3uQ=.404af4de-b837-485e-a220-47419742434d@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <odr9SLW6_8t2_QsZRndgYFqyCZTVjXh6U6rnT_fL3uQ=.404af4de-b837-485e-a220-47419742434d@github.com>
Message-ID: <9FQIYMoH-HEi7ktEzRGxRsoWXGPsDyWPWk3Ds0Edjy0=.5dcab616-2713-441b-b363-350ea62505e3@github.com>

On Mon, 23 Jun 2025 14:55:08 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties line 220:
>> 
>>> 218: entry.1.is.signed.in.jarfile.but.is.not.signed.in.jarinputstream=Eintrag %s ist in JarFile, aber nicht in JarInputStream signiert
>>> 219: entry.1.is.signed.in.jarinputstream.but.is.not.signed.in.jarfile=Eintrag %s ist in JarInputStream, aber nicht in JarFile signiert
>>> 220: jar.contains.internal.inconsistencies.result.in.different.contents.via.jarfile.and.jarinputstream=Diese JAR-Datei enth?lt interne Inkonsistenzen, die zu anderem Inhalt beim Lesen ?ber JarFile als beim Lesen ?ber JarInputStream f?hren k?nnen:
>> 
>> Is it expected to have ?JAR_-Datei_?? It was removed from `.verified` and `.signed` strings.
>
> I think it is because the English version of the properties file uses "jar" for `.verified` and `.signed` strings, but `jar.contains.internal.inconsistencies.result.in.different.contents.via.jarfile.and.jarinputstream` uses "JAR".

I see the entries for


jar.signed.=jar signed.
jar.verified.=jar verified.

don't have the word *?file?*, whereas `?via.jarfile.and.jarinputstream` has it: ?This JAR *file*??

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162318454

From aivanov at openjdk.org  Mon Jun 23 19:07:31 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Jun 2025 19:07:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <KD-oruGQL9hUtmCexnxFdfMwwEud0SQCNo4HMW4l9-o=.37a8bead-5fe1-42b8-887e-fbe834794531@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <a_GmJUtJTOEwCYk23UOkb03IWqfwuNI0GO1lXRJTGGY=.06afc484-9259-46d4-9384-9e93b08598c0@github.com>
 <wjxC1HjQZ0pqyW-twJYYAjL6gH44ufgW53nkbNSLHRI=.848fbbb0-ebe7-4c55-9ae3-2996471c368c@github.com>
 <KD-oruGQL9hUtmCexnxFdfMwwEud0SQCNo4HMW4l9-o=.37a8bead-5fe1-42b8-887e-fbe834794531@github.com>
Message-ID: <OcacegwRzvpCkX4TBo0MwjR50O63wyiITIe63m_Qd3Y=.2afba7d1-f27a-4978-b495-01a995eb545e@github.com>

On Mon, 23 Jun 2025 17:38:58 GMT, Johannes D?bler <duke at openjdk.org> wrote:

>> What would be the correct translation of majorticks here?
>
> If "major tick" is translated to "Hauptteilstrich", then the plural would be `[SliderDemo.majorticks=]Hauptteilstriche` (which is a rather artificial word so the translation team might want to come up with a better translation for "major tick").

Microsoft uses *Hauptteilstrich*, see [MajorTickMark Klasse](https://learn.microsoft.com/de-de/dotnet/api/documentformat.openxml.drawing.charts.majortickmark?view=openxml-3.0.1), so *Hauptteilstrich* (singular Nominative) seems correct.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162350461

From aivanov at openjdk.org  Mon Jun 23 19:36:31 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Jun 2025 19:36:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <OZ262_JSW2vfezx4xU16MrfrecafkpCY6BuoG8nJgkU=.8ea6aecc-dd18-4799-a844-6139910d7aea@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <OZ262_JSW2vfezx4xU16MrfrecafkpCY6BuoG8nJgkU=.8ea6aecc-dd18-4799-a844-6139910d7aea@github.com>
Message-ID: <O9Co_nchUBZcx7IsEWV3BulBeBx49f1DCSSfMncRP9Y=.01ec06db-951c-4466-b07e-4f49e34c41ad@github.com>

On Mon, 23 Jun 2025 16:36:00 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 462:
>> 
>>> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
>>> 461: SliderDemo.ticks=Feinteilungen, Teilungen zum Einrasten und Labels
>>> 462: SliderDemo.minorticks=Feinteilungen
>> 
>> The following description uses different words now:
>> 
>> Feinteilungen -> Teilstrichen
>> Teilungen -> Teilstrichen
>
> Just to clarify, does this mean
> 
> SliderDemo.ticks=Teilstrichen, Teilstrichen zum Einrasten und Labels
> SliderDemo.minorticks=Teilstrichen
> 
> is correct?

Hm? I don't know. You should clarify with the translation team. They've changed the translation for the major ticks from *Grobteilungen* to *Hauptteilstriche*. Yet minor ticks remain *Feinteilungen*, which doesn't look right because the main word is different. (*Teilung* doesn't seem to be the right word, at least dictionaries translate it as ?division?.)

*Teilstrich* means *scale line*, the marks on a ruler, so it fits.

Microsoft documentation for [MinorTickMark Klasse](https://learn.microsoft.com/de-de/dotnet/api/documentformat.openxml.drawing.charts.minortickmark?view=openxml-3.0.1) uses *Kleinere Teilstriche*, yet I don't understand why there's ?-e? ending (plural?).


SliderDemo.ticks=Teilstrichen, Teilstrichen zum Einrasten und Labels

This one looks particularly incorrect; ?einrasten? is a verb with a separable prefix that means ?to lock?, and I can't find a usage as if it's a noun.

The English phrase is ?Minor Ticks, Snap-to-ticks and Labels?, and I don't know how to correctly translate it to German.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162394521

From aivanov at openjdk.org  Mon Jun 23 19:36:32 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 23 Jun 2025 19:36:32 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <yC5NAA2uzq92MZGyXJQkRYallBsQCJpF8vmemkndk9c=.c7bb4cff-9af0-4d25-9782-dbe35cafcfd8@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <yC5NAA2uzq92MZGyXJQkRYallBsQCJpF8vmemkndk9c=.c7bb4cff-9af0-4d25-9782-dbe35cafcfd8@github.com>
Message-ID: <Cnn1pTxh334i_8vCnBa3c3FWvblGyzCjASOEGJQTsw8=.eb5e76f7-e83b-416c-9fe6-361d772780af@github.com>

On Thu, 19 Jun 2025 17:39:38 GMT, Johannes D?bler <duke at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties line 183:
>> 
>>> 181: size.bit.alg=%1$d-Bit-%2$s
>>> 182: Generating.full.keyAlgName.key.pair.and.self.signed.certificate.sigAlgName.with.a.validity.of.days.for=Generieren von {0}-Schl?sselpaar und selbstsigniertem Zertifikat ({1}) mit einer G?ltigkeit von {2} Tagen\n\tf?r: {3}
>>> 183: Generating.full.keyAlgName.key.pair.and.a.certificate.sigAlgName.issued.by.signerAlias.with.a.validity.of.days.for=Generieren von {0}-Schl?sselpaar und einem von <{2}> ausgestellten Zertifikat ({1}) mit einer G?ltigkeit von {3} Tagen\n\tf?r: {4}
>> 
>> It feels as if there's something missing after _?einem?_.
>
> seems ok to me, einem von X ausgestellten Zertifikat ~ einem Zertifikat, das von X ausgestellt wurde

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162395125

From nbenalla at openjdk.org  Mon Jun 23 22:29:34 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Mon, 23 Jun 2025 22:29:34 GMT
Subject: RFR: 8358627:
 tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26
In-Reply-To: <mcPF1ypiHlYI3H4kgl0bwvU3KF_YO40Yo6aY6w1LX4c=.4376bebf-3397-4354-be3e-9fd0719b24db@github.com>
References: <mcPF1ypiHlYI3H4kgl0bwvU3KF_YO40Yo6aY6w1LX4c=.4376bebf-3397-4354-be3e-9fd0719b24db@github.com>
Message-ID: <Sfp9LEP7TTaZrAVXqGmOQb321UFTRS_ua0nYz3jS_10=.943929e6-28aa-436b-a245-35eb9417f1f9@github.com>

On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved, JavaBaseCheckSince no longer needs to be problemlisted.

Now that https://github.com/openjdk/jdk/pull/25854 has been integrated, the tests no longer need to be problemlisted.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25855#issuecomment-2998140113

From jpai at openjdk.org  Tue Jun 24 04:37:20 2025
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 24 Jun 2025 04:37:20 GMT
Subject: RFR: 8360307: Problemlist
 tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java
Message-ID: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>

Can I please get a review of this problemlisting change which problem lists the `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java` test? This test has been failing regularly in our CI in tier2.

I have tier2 run in progress and I'll integrate this change once that run completes successfully.

-------------

Commit messages:
 - 8360307: Problemlist tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java

Changes: https://git.openjdk.org/jdk/pull/25947/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25947&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8360307
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/25947.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25947/head:pull/25947

PR: https://git.openjdk.org/jdk/pull/25947

From dholmes at openjdk.org  Tue Jun 24 05:02:29 2025
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 24 Jun 2025 05:02:29 GMT
Subject: RFR: 8360307: Problemlist
 tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java
In-Reply-To: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>
References: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>
Message-ID: <JzfSt3X52-Ls1VvOPsYWpKaorjZQCNd8pkv1YoJj2Iw=.76f05e18-b92c-4864-b503-d44658a15e99@github.com>

On Tue, 24 Jun 2025 04:29:16 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this problemlisting change which problem lists the `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java` test? This test has been failing regularly in our CI in tier2.
> 
> I have tier2 run in progress and I'll integrate this change once that run completes successfully.

Thanks for doing this Jai.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25947#pullrequestreview-2952177895

From cstein at openjdk.org  Tue Jun 24 05:15:34 2025
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 24 Jun 2025 05:15:34 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <OcacegwRzvpCkX4TBo0MwjR50O63wyiITIe63m_Qd3Y=.2afba7d1-f27a-4978-b495-01a995eb545e@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <a_GmJUtJTOEwCYk23UOkb03IWqfwuNI0GO1lXRJTGGY=.06afc484-9259-46d4-9384-9e93b08598c0@github.com>
 <wjxC1HjQZ0pqyW-twJYYAjL6gH44ufgW53nkbNSLHRI=.848fbbb0-ebe7-4c55-9ae3-2996471c368c@github.com>
 <KD-oruGQL9hUtmCexnxFdfMwwEud0SQCNo4HMW4l9-o=.37a8bead-5fe1-42b8-887e-fbe834794531@github.com>
 <OcacegwRzvpCkX4TBo0MwjR50O63wyiITIe63m_Qd3Y=.2afba7d1-f27a-4978-b495-01a995eb545e@github.com>
Message-ID: <bNn_SZAJQvbgRD39f2sJDCLItuz4Q-fJOjCQzc0URAo=.825ec4ad-31a1-4882-93ee-97f0eff02597@github.com>

On Mon, 23 Jun 2025 19:04:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> If "major tick" is translated to "Hauptteilstrich", then the plural would be `[SliderDemo.majorticks=]Hauptteilstriche` (which is a rather artificial word so the translation team might want to come up with a better translation for "major tick").
>
> Microsoft uses *Hauptteilstrich*, see [MajorTickMark Klasse](https://learn.microsoft.com/de-de/dotnet/api/documentformat.openxml.drawing.charts.majortickmark?view=openxml-3.0.1), so *Hauptteilstrich* (singular Nominative) seems correct.

Ja, "Hauptteilstrich" and "Hauptteilstriche" (pl) are correct.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162975420

From liach at openjdk.org  Tue Jun 24 05:17:26 2025
From: liach at openjdk.org (Chen Liang)
Date: Tue, 24 Jun 2025 05:17:26 GMT
Subject: RFR: 8360307: Problemlist
 tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java
In-Reply-To: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>
References: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>
Message-ID: <YChUxVyxvxApIeJSTlA0YH30NejI4KNZSiOANRLJU_0=.f41c39fe-cd52-4bb6-a493-c7c5831b5dae@github.com>

On Tue, 24 Jun 2025 04:29:16 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this problemlisting change which problem lists the `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java` test? This test has been failing regularly in our CI in tier2.
> 
> I have tier2 run in progress and I'll integrate this change once that run completes successfully.

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25947#pullrequestreview-2952199955

From jpai at openjdk.org  Tue Jun 24 05:21:33 2025
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 24 Jun 2025 05:21:33 GMT
Subject: RFR: 8360307: Problemlist
 tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java
In-Reply-To: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>
References: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>
Message-ID: <j3kor1VEat-Wa4VJqzJV0KVtGKt925uNShX10TD8mb0=.ec988bb2-7a1c-49c6-8e33-0c1e06258490@github.com>

On Tue, 24 Jun 2025 04:29:16 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this problemlisting change which problem lists the `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java` test? This test has been failing regularly in our CI in tier2.
> 
> I have tier2 run in progress and I'll integrate this change once that run completes successfully.

Thank you David and Chen for the reviews. I verified that the tier2 run with this change no longer runs this test. I'll go ahead and integrate this now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25947#issuecomment-2998849764

From jpai at openjdk.org  Tue Jun 24 05:21:33 2025
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 24 Jun 2025 05:21:33 GMT
Subject: Integrated: 8360307: Problemlist
 tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java
In-Reply-To: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>
References: <jnWgVUFVlHNoieXQ9LD_lM-4tQetemCM3OMhposcLGg=.21598cc8-1a07-44a8-a97f-d2d9c502baf8@github.com>
Message-ID: <RKTdRLaHGGU1YVbpCBSebJi6WnxFTwEaTXB8swhDQrY=.027b4d35-0ae6-4517-8811-f4bbe98d7001@github.com>

On Tue, 24 Jun 2025 04:29:16 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this problemlisting change which problem lists the `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java` test? This test has been failing regularly in our CI in tier2.
> 
> I have tier2 run in progress and I'll integrate this change once that run completes successfully.

This pull request has now been integrated.

Changeset: 9af36b13
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9af36b13c52b60274507a90874b8fb41fc3586f8
Stats:     2 lines in 1 file changed: 2 ins; 0 del; 0 mod

8360307: Problemlist tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java

Reviewed-by: dholmes, liach

-------------

PR: https://git.openjdk.org/jdk/pull/25947

From cstein at openjdk.org  Tue Jun 24 05:22:33 2025
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 24 Jun 2025 05:22:33 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]
In-Reply-To: <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
Message-ID: <ws3HlD1kGmF5lUjtCE7SxWmnc4GEkdFi6FWo_Hnm7Tc=.c3dc65c9-7681-4145-afc2-a3af84857e78@github.com>

On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to german translations

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 462:

> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
> 461: SliderDemo.ticks=Feinteilungen, Teilungen zum Einrasten und Labels
> 462: SliderDemo.minorticks=Feinteilungen

For consistency with the "Hilfsteilstrich" (singular) and "Hilfsteilstriche" (plural) used below in `SliderDemo.minorticksdescription` and `SliderDemo.disableddescription`, I'd suggest to use:
Suggestion:

SliderDemo.ticks=Hilfsteilstriche, zum Einrasten und Beschriften
SliderDemo.minorticks=Hilfsteilstriche


As "Labels" is not a German word.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162982972

From cstein at openjdk.org  Tue Jun 24 05:34:31 2025
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 24 Jun 2025 05:34:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]
In-Reply-To: <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
Message-ID: <8Orj0J7-iUsSjTQEc7t-pSShM2wHGmfReMStzGByHGY=.41967017-0e70-4e2a-9133-f84fd263ff51@github.com>

On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to german translations

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_de.properties line 178:

> 176: javac.opt.Xlint.desc.restricted=Warnt vor der Verwendung eingeschr?nkter Methoden.
> 177: 
> 178: javac.opt.Xlint.desc.synchronization=Warnt vor Synchronisierungsversuchen mit Instanzen wertbasierter Klassen.\n                         Dieser Schl?ssel ist ein veralteter Alias f?r die Kategorie "Identit?t", die dieselben Verwendungen und\n                         Effekte hat. Benutzern wird empfohlen, die Kategorie "Identit?t" f?r alle zuk?nftigen\n                         und vorhandenen Verwendungen von "Synchronisierung" zu verwenden.

"Identit?t" and "Synchronisierung" are literals that must not be translated.

The English base entry reads:


javac.opt.Xlint.desc.synchronization=\
    Warn about synchronization attempts on instances of value-based classes.\n\
\                         This key is a deprecated alias for ''identity'', which has the same uses and\n\
\                         effects. Users are encouraged to use the ''identity'' category for all future\n\
\                         and existing uses of ''synchronization''.


And `javac --help-lint` contains:


    strictfp             Warn about unnecessary use of the strictfp modifier.
    synchronization      Warn about synchronization attempts on instances of value-based classes.
    text-blocks          Warn about inconsistent white space characters in text block indentation.
    
    
    
Suggestion:

javac.opt.Xlint.desc.synchronization=Warnt vor Synchronisierungsversuchen mit Instanzen wertbasierter Klassen.\n                         Dieser Schl?ssel ist ein veralteter Alias f?r die Kategorie "identity", die dieselben Verwendungen und\n                         Effekte hat. Benutzern wird empfohlen, die Kategorie "identity" f?r alle zuk?nftigen\n                         und vorhandenen Verwendungen von "synchronization" zu verwenden.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2162995954

From cstein at openjdk.org  Tue Jun 24 05:44:30 2025
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 24 Jun 2025 05:44:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]
In-Reply-To: <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
Message-ID: <AQix03HSJOPQl9dpzNexQJ-oAj3KLVWEt4zDGOxjmZM=.1efb1178-489f-478e-9534-f9b32e5b92de@github.com>

On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to german translations

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher_de.properties line 103:

> 101: 
> 102: # 0: string
> 103: launcher.err.cant.find.main.method=main(String[])- oder main()-Methode nicht gefunden in Klasse: {0}

Suggestion:

launcher.err.cant.find.main.method=Konnte keine main(String[])- oder main()-Methode in der Klasse: {0} finden.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2163006433

From nbenalla at openjdk.org  Tue Jun 24 10:32:51 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 24 Jun 2025 10:32:51 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v8]
In-Reply-To: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
Message-ID: <R3m5L7NuBUG6JEYSN1KclL0F-Eoau1qRSsfFJHwMT6o=.bbe0bb0c-5cea-4c05-83b0-82a827171ed6@github.com>

> Please review this patch to fix a bug where a method can be documented multiple times 
> Consider these 4 classes
> 
>                     A       (interface)
>                    / \
>                   /   \
> (abstract class)  C     B   ( interface)
>                   \   /
>                    \ /
>                     D       (class)
> 
> 
> Where `A` declares `testA()`, `C` implements it `public final void testA()`, `B` extends `A` but does *not* override it, `D` extends `C` and implements `B`
> 
> In the generated javadoc, `testA()` is documented twice.
> 
> ![Screenshot 2025-05-08 at 15 51 19](https://github.com/user-attachments/assets/46538e61-1546-4128-8041-296d8491406f)
> 
> After the patch, `testA()` is only documented once:
> 
> ![Screenshot 2025-05-08 at 15 52 16](https://github.com/user-attachments/assets/a6b86a21-7104-460c-8f3f-36cee5962eed)

Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:

 - review feedback: add positive test
 - Merge branch 'master' into duplicate-APIs
 - Merge branch 'master' into duplicate-APIs
 - Feedback from @hns -  Expand test with new test cases
 - Merge branch 'master' into duplicate-APIs
 - revert back to simple earlier fix
 - revert back to master
 - Merge branch 'master' into duplicate-APIs
 - Merge branch 'master' into duplicate-APIs
 - rename test to be more accurate and simplify code
 - ... and 7 more: https://git.openjdk.org/jdk/compare/f8ee11ec...00e7adcc

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25123/files
  - new: https://git.openjdk.org/jdk/pull/25123/files/caeb20ad..00e7adcc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25123&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25123&range=06-07

  Stats: 51882 lines in 1215 files changed: 35082 ins; 10971 del; 5829 mod
  Patch: https://git.openjdk.org/jdk/pull/25123.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25123/head:pull/25123

PR: https://git.openjdk.org/jdk/pull/25123

From nbenalla at openjdk.org  Tue Jun 24 10:32:53 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 24 Jun 2025 10:32:53 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v7]
In-Reply-To: <Bzp2Qfxx3loNVopJJUVh5z0WZljvMo8W0SDM96IOk1o=.69080ab6-589c-4b7d-bb7a-df13fa20fc12@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
 <6lA92Ca1vGSP2ElA499bsoLB0IWLLZIkOInukKHNIig=.e842af30-45ea-4396-96dd-149488509902@github.com>
 <Bzp2Qfxx3loNVopJJUVh5z0WZljvMo8W0SDM96IOk1o=.69080ab6-589c-4b7d-bb7a-df13fa20fc12@github.com>
Message-ID: <XziguBI-2RDfijCz0odDCz8Ddy7qvDnjV8t2s5Al_ug=.9295c309-f0c9-41cb-bf32-bd26a35756b0@github.com>

On Tue, 10 Jun 2025 14:20:19 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>> 
>>  - Feedback from @hns -  Expand test with new test cases
>>  - Merge branch 'master' into duplicate-APIs
>>  - revert back to simple earlier fix
>>  - revert back to master
>>  - Merge branch 'master' into duplicate-APIs
>>  - Merge branch 'master' into duplicate-APIs
>>  - rename test to be more accurate and simplify code
>>  - update javadoc
>>  - Merge branch 'master' into duplicate-APIs
>>  - new approach - make sure there is no negative effect on JDK doc output
>>  - ... and 4 more: https://git.openjdk.org/jdk/compare/89246a82...caeb20ad
>
> test/langtools/jdk/javadoc/doclet/testDuplicateMethodsWarn/TestDuplicateMethods.java line 181:
> 
>> 179:         checkExit(Exit.OK);
>> 180: 
>> 181:         checkOutput("sb/U.html", false,
> 
> Could you add a positive check to this test and `testHashMapInheritance` that the method is documented as expected (as local method in this test, and as inherited from the public abstract class in `testHashMapInheritance`), and that the method details has a "Specified by: ..." entry pointing to the interface method?

Updated the test to add a positive check. Tests are currently running in CI.
If the update look trivial enough, could you set the reviewer count back to 1?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25123#discussion_r2163574291

From weijun at openjdk.org  Tue Jun 24 14:56:30 2025
From: weijun at openjdk.org (Weijun Wang)
Date: Tue, 24 Jun 2025 14:56:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <ij3E2h5HHVXFll_xif0vHx4lrh6_QkTohC0rAZW2dGA=.03b17f7f-14cf-49bb-92c5-7f0033e6ccb7@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <SpVZ52poJGvsBGyuVB8B91ZEje1QaAafXfnEovQx0-I=.640d1f5f-8222-402a-b075-dea1ea46bd81@github.com>
 <ij3E2h5HHVXFll_xif0vHx4lrh6_QkTohC0rAZW2dGA=.03b17f7f-14cf-49bb-92c5-7f0033e6ccb7@github.com>
Message-ID: <WuQvK5zsAIoLmBECTsLi2L1CDnyqyNyHhISc_Fmyel8=.b28647b1-80b6-44cf-bc67-5e9a6a4bb272@github.com>

On Wed, 18 Jun 2025 16:43:02 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> There is still only one space, the new one is a full width colon (U+FF1A). Localization rules have been observed to make the switch from regular colons (U+003A) into the full width version depending on the language.
>
> Thank you for the clarification.

However, there is no space required between two Chinese sentences. In English, we usually write "I am here, and you are there." But in Chinese, with the full-width punctuation, it's always "??????????".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2164251035

From weijun at openjdk.org  Tue Jun 24 15:01:30 2025
From: weijun at openjdk.org (Weijun Wang)
Date: Tue, 24 Jun 2025 15:01:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]
In-Reply-To: <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
Message-ID: <WHNIK6WQ1Y5x33W8vaKCXZJ5MJjM40ODNx2cBohFtpQ=.434218f1-9099-4045-b90f-0c13a5a4a5dd@github.com>

On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to german translations

src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties line 49:

> 47: .Principal.=\t????\u0020
> 48: .Public.Credential.=\t??????:\u0020
> 49: .Private.Credential.=\t??????:\u0020

Why aren't the 2 lines above updated like in lines 46 and 47?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2164262664

From weijun at openjdk.org  Tue Jun 24 15:01:31 2025
From: weijun at openjdk.org (Weijun Wang)
Date: Tue, 24 Jun 2025 15:01:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <WuQvK5zsAIoLmBECTsLi2L1CDnyqyNyHhISc_Fmyel8=.b28647b1-80b6-44cf-bc67-5e9a6a4bb272@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <SpVZ52poJGvsBGyuVB8B91ZEje1QaAafXfnEovQx0-I=.640d1f5f-8222-402a-b075-dea1ea46bd81@github.com>
 <ij3E2h5HHVXFll_xif0vHx4lrh6_QkTohC0rAZW2dGA=.03b17f7f-14cf-49bb-92c5-7f0033e6ccb7@github.com>
 <WuQvK5zsAIoLmBECTsLi2L1CDnyqyNyHhISc_Fmyel8=.b28647b1-80b6-44cf-bc67-5e9a6a4bb272@github.com>
Message-ID: <570JPur5CDdEKtLyaTZEthUJePWje6-WK49sZNCBFEs=.058eb1d3-c0f4-48f3-90a4-cd29ad41dccf@github.com>

On Tue, 24 Jun 2025 14:54:17 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Thank you for the clarification.
>
> However, there is no space required between two Chinese sentences. In English, we usually write "I am here, and you are there." But in Chinese, with the full-width punctuation, it's always "??????????".

Some people like to insert a space between a Chinese character and a Latin letter. I?m not a fan of this style, but I don?t feel strongly about it. However, adding a space between two Chinese characters or between a Chinese character and a full-width punctuation mark is unusual.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2164261187

From liach at openjdk.org  Tue Jun 24 15:36:28 2025
From: liach at openjdk.org (Chen Liang)
Date: Tue, 24 Jun 2025 15:36:28 GMT
Subject: RFR: 8359024: Accessibility bugs in API documentation
In-Reply-To: <A0GfwWeQnx-1AbbWk7-jRKkgCB8FebSxzK1kRmdFhB0=.cc400ad7-30d7-4f45-808e-9631f11c0b18@github.com>
References: <A0GfwWeQnx-1AbbWk7-jRKkgCB8FebSxzK1kRmdFhB0=.cc400ad7-30d7-4f45-808e-9631f11c0b18@github.com>
Message-ID: <FMbNFNpzVCtNq9o-1S9PfalXNyU2AdV35mszxgmg1jk=.44835c84-ba49-4ee1-ae58-c7b7988ecc04@github.com>

On Tue, 10 Jun 2025 10:04:46 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a change to fix a couple of accessibility errors in JDK API documentation as detected by our accessibility testing. 
> 
>  - Contrast between link and normal text colors was below 3 and therefore would have required other styling (such as underlining). This is fixed by slightly darkening text color (our text color isn't black but dark-gray).
>     Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=282828&bcolor=FFFFFF&lcolor=437291
>     New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=FFFFFF&lcolor=437291
> 
>  - Links in the headings of inherited member summaries used the wrong color and contrast to background color was below 4.5. This is fixed by removing a bogus `.expanded` selector that shouldn't have been there in the first place.
>     Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=437291
>     New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=47688A
> 
> - Remove the `role="tablist"` and `aria-orientation="horizontal"` attributes from table captions if they do not contain tabs. This is the only code change, and the only change that comes with a test change (I guess the CSS changes are `noreg-hard` as we don't have a way to do automatic accessibility testing).
> 
> All changes are invisible or so subtle that they are practically impossible to spot in normal browsing, so I spare myself the task of uploading demo docs.

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25716#pullrequestreview-2954385380

From liach at openjdk.org  Tue Jun 24 15:37:31 2025
From: liach at openjdk.org (Chen Liang)
Date: Tue, 24 Jun 2025 15:37:31 GMT
Subject: RFR: 8328848: Inaccuracy in the documentation of the -group option
In-Reply-To: <DfqH6RrQXPHHUf1uBCVbOTVEARdVEjk2maT-64sVK10=.a7af9f0e-f623-4c60-a846-12fc20f664b4@github.com>
References: <DfqH6RrQXPHHUf1uBCVbOTVEARdVEjk2maT-64sVK10=.a7af9f0e-f623-4c60-a846-12fc20f664b4@github.com>
Message-ID: <R_nmeRqJoXnSVuEPCjdiTL9tdbKC-HPvcoQkbSqZK-g=.62ee02d6-2b34-4257-b259-9b722fb6395d@github.com>

On Tue, 13 May 2025 13:09:56 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a documentation fix in the `javadoc` man page to document that the `-group` option can be used with packages or modules depending on documented code. 
> 
> Although the help output of the `javadoc` tool already included this fact I replaced the abstract term "elements" with "packages or modules" to make it a bit more concrete.

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25212#pullrequestreview-2954387031

From liach at openjdk.org  Tue Jun 24 15:39:32 2025
From: liach at openjdk.org (Chen Liang)
Date: Tue, 24 Jun 2025 15:39:32 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v8]
In-Reply-To: <R3m5L7NuBUG6JEYSN1KclL0F-Eoau1qRSsfFJHwMT6o=.bbe0bb0c-5cea-4c05-83b0-82a827171ed6@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
 <R3m5L7NuBUG6JEYSN1KclL0F-Eoau1qRSsfFJHwMT6o=.bbe0bb0c-5cea-4c05-83b0-82a827171ed6@github.com>
Message-ID: <zSvmqWW-fTyK079RlqDtgKqjSROCGDCC37sjK4-C7oA=.8ad34b87-5bd2-4c6e-a0a0-4863336609ae@github.com>

On Tue, 24 Jun 2025 10:32:51 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this patch to fix a bug where a method can be documented multiple times 
>> Consider these 4 classes
>> 
>>                     A       (interface)
>>                    / \
>>                   /   \
>> (abstract class)  C     B   ( interface)
>>                   \   /
>>                    \ /
>>                     D       (class)
>> 
>> 
>> Where `A` declares `testA()`, `C` implements it `public final void testA()`, `B` extends `A` but does *not* override it, `D` extends `C` and implements `B`
>> 
>> In the generated javadoc, `testA()` is documented twice.
>> 
>> ![Screenshot 2025-05-08 at 15 51 19](https://github.com/user-attachments/assets/46538e61-1546-4128-8041-296d8491406f)
>> 
>> After the patch, `testA()` is only documented once:
>> 
>> ![Screenshot 2025-05-08 at 15 52 16](https://github.com/user-attachments/assets/a6b86a21-7104-460c-8f3f-36cee5962eed)
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
> 
>  - review feedback: add positive test
>  - Merge branch 'master' into duplicate-APIs
>  - Merge branch 'master' into duplicate-APIs
>  - Feedback from @hns -  Expand test with new test cases
>  - Merge branch 'master' into duplicate-APIs
>  - revert back to simple earlier fix
>  - revert back to master
>  - Merge branch 'master' into duplicate-APIs
>  - Merge branch 'master' into duplicate-APIs
>  - rename test to be more accurate and simplify code
>  - ... and 7 more: https://git.openjdk.org/jdk/compare/1b01a1bd...00e7adcc

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25123#pullrequestreview-2954393305

From liach at openjdk.org  Tue Jun 24 15:40:29 2025
From: liach at openjdk.org (Chen Liang)
Date: Tue, 24 Jun 2025 15:40:29 GMT
Subject: RFR: 8358627:
 tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26
In-Reply-To: <mcPF1ypiHlYI3H4kgl0bwvU3KF_YO40Yo6aY6w1LX4c=.4376bebf-3397-4354-be3e-9fd0719b24db@github.com>
References: <mcPF1ypiHlYI3H4kgl0bwvU3KF_YO40Yo6aY6w1LX4c=.4376bebf-3397-4354-be3e-9fd0719b24db@github.com>
Message-ID: <Llr2oDIu8Fn15KPvm3vRwWC2Mlqr-OvB9_uBdfJEQ3Q=.4d6362b6-dc4b-4bb4-9045-24b9a50b8942@github.com>

On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved, JavaBaseCheckSince no longer needs to be problemlisted.

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25855#pullrequestreview-2954395455

From hannesw at openjdk.org  Tue Jun 24 15:51:37 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 24 Jun 2025 15:51:37 GMT
Subject: Integrated: 8359024: Accessibility bugs in API documentation
In-Reply-To: <A0GfwWeQnx-1AbbWk7-jRKkgCB8FebSxzK1kRmdFhB0=.cc400ad7-30d7-4f45-808e-9631f11c0b18@github.com>
References: <A0GfwWeQnx-1AbbWk7-jRKkgCB8FebSxzK1kRmdFhB0=.cc400ad7-30d7-4f45-808e-9631f11c0b18@github.com>
Message-ID: <SksUS65w-Pzxka8wVARwp5EEl5aeXfWKWLGS8WuJT_U=.c03a34b9-7503-4240-a17e-7cc7f8bdd0e4@github.com>

On Tue, 10 Jun 2025 10:04:46 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a change to fix a couple of accessibility errors in JDK API documentation as detected by our accessibility testing. 
> 
>  - Contrast between link and normal text colors was below 3 and therefore would have required other styling (such as underlining). This is fixed by slightly darkening text color (our text color isn't black but dark-gray).
>     Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=282828&bcolor=FFFFFF&lcolor=437291
>     New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=FFFFFF&lcolor=437291
> 
>  - Links in the headings of inherited member summaries used the wrong color and contrast to background color was below 4.5. This is fixed by removing a bogus `.expanded` selector that shouldn't have been there in the first place.
>     Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=437291
>     New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=47688A
> 
> - Remove the `role="tablist"` and `aria-orientation="horizontal"` attributes from table captions if they do not contain tabs. This is the only code change, and the only change that comes with a test change (I guess the CSS changes are `noreg-hard` as we don't have a way to do automatic accessibility testing).
> 
> All changes are invisible or so subtle that they are practically impossible to spot in normal browsing, so I spare myself the task of uploading demo docs.

This pull request has now been integrated.

Changeset: 9a726df3
Author:    Hannes Walln?fer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9a726df3731a22bdd4e768d83835aba9240967d2
Stats:     40 lines in 4 files changed: 2 ins; 2 del; 36 mod

8359024: Accessibility bugs in API documentation

Reviewed-by: vyazici, liach

-------------

PR: https://git.openjdk.org/jdk/pull/25716

From hannesw at openjdk.org  Tue Jun 24 15:53:38 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 24 Jun 2025 15:53:38 GMT
Subject: Integrated: 8328848: Inaccuracy in the documentation of the -group
 option
In-Reply-To: <DfqH6RrQXPHHUf1uBCVbOTVEARdVEjk2maT-64sVK10=.a7af9f0e-f623-4c60-a846-12fc20f664b4@github.com>
References: <DfqH6RrQXPHHUf1uBCVbOTVEARdVEjk2maT-64sVK10=.a7af9f0e-f623-4c60-a846-12fc20f664b4@github.com>
Message-ID: <LK-W40ckK9yactUY5m64eL_Eg4q7ICfZzR_soetuMk8=.22dfdccb-15a6-4388-8661-1af54702ab38@github.com>

On Tue, 13 May 2025 13:09:56 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a documentation fix in the `javadoc` man page to document that the `-group` option can be used with packages or modules depending on documented code. 
> 
> Although the help output of the `javadoc` tool already included this fact I replaced the abstract term "elements" with "packages or modules" to make it a bit more concrete.

This pull request has now been integrated.

Changeset: f8de5bc5
Author:    Hannes Walln?fer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f8de5bc5827742dd60b8f8f4a0d3625c370af15b
Stats:     4 lines in 2 files changed: 1 ins; 0 del; 3 mod

8328848: Inaccuracy in the documentation of the -group option

Reviewed-by: liach

-------------

PR: https://git.openjdk.org/jdk/pull/25212

From hannesw at openjdk.org  Tue Jun 24 16:08:14 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 24 Jun 2025 16:08:14 GMT
Subject: [jdk25] RFR: 8359024: Accessibility bugs in API documentation
Message-ID: <FDs_hzWkGx1jTk7F1ud3Ccqg44Wah2uWUQ2BvjNfkfQ=.6de9d8ed-1368-4853-af64-2d402aa677c0@github.com>

This pull request contains a backport of commit [9a726df3](https://github.com/openjdk/jdk/commit/9a726df3731a22bdd4e768d83835aba9240967d2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Hannes Walln?fer on 24 Jun 2025 and was reviewed by Volkan Yazici and Chen Liang.

-------------

Commit messages:
 - Backport 9a726df3731a22bdd4e768d83835aba9240967d2

Changes: https://git.openjdk.org/jdk/pull/25956/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25956&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8359024
  Stats: 40 lines in 4 files changed: 2 ins; 2 del; 36 mod
  Patch: https://git.openjdk.org/jdk/pull/25956.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25956/head:pull/25956

PR: https://git.openjdk.org/jdk/pull/25956

From liach at openjdk.org  Tue Jun 24 16:11:29 2025
From: liach at openjdk.org (Chen Liang)
Date: Tue, 24 Jun 2025 16:11:29 GMT
Subject: [jdk25] RFR: 8359024: Accessibility bugs in API documentation
In-Reply-To: <FDs_hzWkGx1jTk7F1ud3Ccqg44Wah2uWUQ2BvjNfkfQ=.6de9d8ed-1368-4853-af64-2d402aa677c0@github.com>
References: <FDs_hzWkGx1jTk7F1ud3Ccqg44Wah2uWUQ2BvjNfkfQ=.6de9d8ed-1368-4853-af64-2d402aa677c0@github.com>
Message-ID: <Hr_JrGc7uiULJy3uYuQKoUDiMO4rGe6rLcQKtTX233M=.f79c66f2-5db5-4713-a693-c65b246783c7@github.com>

On Tue, 24 Jun 2025 16:02:34 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> This pull request contains a backport of commit [9a726df3](https://github.com/openjdk/jdk/commit/9a726df3731a22bdd4e768d83835aba9240967d2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Hannes Walln?fer on 24 Jun 2025 and was reviewed by Volkan Yazici and Chen Liang.

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25956#pullrequestreview-2954508014

From nbenalla at openjdk.org  Tue Jun 24 16:21:35 2025
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 24 Jun 2025 16:21:35 GMT
Subject: RFR: 8177100: APIs duplicated in JavaDoc [v8]
In-Reply-To: <R3m5L7NuBUG6JEYSN1KclL0F-Eoau1qRSsfFJHwMT6o=.bbe0bb0c-5cea-4c05-83b0-82a827171ed6@github.com>
References: <0NrLP37RZ6I7ytBxcNyNFReQVvgu-6p_-HbSbHW9ZRM=.c7fd5ae4-8c8d-48ea-8349-5c92a2f78c71@github.com>
 <R3m5L7NuBUG6JEYSN1KclL0F-Eoau1qRSsfFJHwMT6o=.bbe0bb0c-5cea-4c05-83b0-82a827171ed6@github.com>
Message-ID: <JsZQ6trdt_Ujkd9-HiHFhyHWW0EvWindo9zvVvsEDwU=.6a850296-a368-496b-a5b1-540fe7bc888b@github.com>

On Tue, 24 Jun 2025 10:32:51 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this patch to fix a bug where a method can be documented multiple times 
>> Consider these 4 classes
>> 
>>                     A       (interface)
>>                    / \
>>                   /   \
>> (abstract class)  C     B   ( interface)
>>                   \   /
>>                    \ /
>>                     D       (class)
>> 
>> 
>> Where `A` declares `testA()`, `C` implements it `public final void testA()`, `B` extends `A` but does *not* override it, `D` extends `C` and implements `B`
>> 
>> In the generated javadoc, `testA()` is documented twice.
>> 
>> ![Screenshot 2025-05-08 at 15 51 19](https://github.com/user-attachments/assets/46538e61-1546-4128-8041-296d8491406f)
>> 
>> After the patch, `testA()` is only documented once:
>> 
>> ![Screenshot 2025-05-08 at 15 52 16](https://github.com/user-attachments/assets/a6b86a21-7104-460c-8f3f-36cee5962eed)
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
> 
>  - review feedback: add positive test
>  - Merge branch 'master' into duplicate-APIs
>  - Merge branch 'master' into duplicate-APIs
>  - Feedback from @hns -  Expand test with new test cases
>  - Merge branch 'master' into duplicate-APIs
>  - revert back to simple earlier fix
>  - revert back to master
>  - Merge branch 'master' into duplicate-APIs
>  - Merge branch 'master' into duplicate-APIs
>  - rename test to be more accurate and simplify code
>  - ... and 7 more: https://git.openjdk.org/jdk/compare/b91911c8...00e7adcc

Passes tier 1-3.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25123#issuecomment-3001115508

From hannesw at openjdk.org  Tue Jun 24 17:22:07 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 24 Jun 2025 17:22:07 GMT
Subject: [jdk25] RFR: 8328848: Inaccuracy in the documentation of the -group
 option
Message-ID: <TPRFSAfHjdUyzr7jqtlJsCt_PFQ-fKO8PToepecDR88=.4c47b3da-03c3-4584-a707-0503888e75b2@github.com>

This pull request contains a backport of commit [f8de5bc5](https://github.com/openjdk/jdk/commit/f8de5bc5827742dd60b8f8f4a0d3625c370af15b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Hannes Walln?fer on 24 Jun 2025 and was reviewed by Chen Liang.

-------------

Commit messages:
 - Backport f8de5bc5827742dd60b8f8f4a0d3625c370af15b

Changes: https://git.openjdk.org/jdk/pull/25959/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25959&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328848
  Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/25959.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25959/head:pull/25959

PR: https://git.openjdk.org/jdk/pull/25959

From liach at openjdk.org  Tue Jun 24 17:34:27 2025
From: liach at openjdk.org (Chen Liang)
Date: Tue, 24 Jun 2025 17:34:27 GMT
Subject: [jdk25] RFR: 8328848: Inaccuracy in the documentation of the
 -group option
In-Reply-To: <TPRFSAfHjdUyzr7jqtlJsCt_PFQ-fKO8PToepecDR88=.4c47b3da-03c3-4584-a707-0503888e75b2@github.com>
References: <TPRFSAfHjdUyzr7jqtlJsCt_PFQ-fKO8PToepecDR88=.4c47b3da-03c3-4584-a707-0503888e75b2@github.com>
Message-ID: <pZ_ru4Ed0-qbKgbPaYYS6H_eZM1fyOkCvWAI7uUdOL0=.094cf9cd-c5a9-43f4-b8d8-e2737eba7d02@github.com>

On Tue, 24 Jun 2025 17:16:08 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> This pull request contains a backport of commit [f8de5bc5](https://github.com/openjdk/jdk/commit/f8de5bc5827742dd60b8f8f4a0d3625c370af15b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Hannes Walln?fer on 24 Jun 2025 and was reviewed by Chen Liang.

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25959#pullrequestreview-2954730235

From achung at openjdk.org  Tue Jun 24 21:47:23 2025
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 24 Jun 2025 21:47:23 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v5]
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <D5DGFra1xHGKB6ITrD1TV1PQcZNS_7nlA8GfD8cwQ6w=.c87859b8-fb89-4d2e-93a4-d9c0e3e44f21@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

Alisen Chung has updated the pull request incrementally with three additional commits since the last revision:

 - Update src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher_de.properties
   
   Co-authored-by: Christian Stein <sormuras at gmail.com>
 - Update src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_de.properties
   
   Co-authored-by: Christian Stein <sormuras at gmail.com>
 - Update src/demo/share/jfc/SwingSet2/resources/swingset_de.properties
   
   Co-authored-by: Christian Stein <sormuras at gmail.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25839/files
  - new: https://git.openjdk.org/jdk/pull/25839/files/90bfd7bd..97f3fe37

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=03-04

  Stats: 8 lines in 3 files changed: 4 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/25839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839

PR: https://git.openjdk.org/jdk/pull/25839

From dnguyen at openjdk.org  Wed Jun 25 00:30:31 2025
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 25 Jun 2025 00:30:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]
In-Reply-To: <WHNIK6WQ1Y5x33W8vaKCXZJ5MJjM40ODNx2cBohFtpQ=.434218f1-9099-4045-b90f-0c13a5a4a5dd@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
 <WHNIK6WQ1Y5x33W8vaKCXZJ5MJjM40ODNx2cBohFtpQ=.434218f1-9099-4045-b90f-0c13a5a4a5dd@github.com>
Message-ID: <EkV9jV9XTsut84ob-HuMVzhJzQYhFVWWjmPlA-p1ewU=.b85e2289-4e2b-437e-944c-7bb5aadfc0c0@github.com>

On Tue, 24 Jun 2025 14:59:18 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update to german translations
>
> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties line 49:
> 
>> 47: .Principal.=\t????\u0020
>> 48: .Public.Credential.=\t??????:\u0020
>> 49: .Private.Credential.=\t??????:\u0020
> 
> Why aren't the 2 lines above updated like in lines 46 and 47?

I checked the ASCII codes here and on the source file. The updated colons are localized to full-width colons as @justin-curtis-lu mentioned in another thread here.

I agree. I also believe lines 48 & 49 need to be updated to the same type of colon. I don't see a good reason for why this was not updated as well. We may need to file a bug with the translators to resolve this inconsistency for next time. We should update these lines here now unless anyone else sees a reason not to.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2165200706

From hannesw at openjdk.org  Wed Jun 25 05:39:32 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Wed, 25 Jun 2025 05:39:32 GMT
Subject: [jdk25] Integrated: 8359024: Accessibility bugs in API documentation
In-Reply-To: <FDs_hzWkGx1jTk7F1ud3Ccqg44Wah2uWUQ2BvjNfkfQ=.6de9d8ed-1368-4853-af64-2d402aa677c0@github.com>
References: <FDs_hzWkGx1jTk7F1ud3Ccqg44Wah2uWUQ2BvjNfkfQ=.6de9d8ed-1368-4853-af64-2d402aa677c0@github.com>
Message-ID: <C2SqOzik6VcLUhzeOGENn779VtChWSispSYDP_Ph1h4=.84053649-b7de-476d-bd27-41caad026e56@github.com>

On Tue, 24 Jun 2025 16:02:34 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> This pull request contains a backport of commit [9a726df3](https://github.com/openjdk/jdk/commit/9a726df3731a22bdd4e768d83835aba9240967d2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Hannes Walln?fer on 24 Jun 2025 and was reviewed by Volkan Yazici and Chen Liang.

This pull request has now been integrated.

Changeset: a5769520
Author:    Hannes Walln?fer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a5769520393555fbf18992b62fb8d1526e809ce8
Stats:     40 lines in 4 files changed: 2 ins; 2 del; 36 mod

8359024: Accessibility bugs in API documentation

Reviewed-by: liach
Backport-of: 9a726df3731a22bdd4e768d83835aba9240967d2

-------------

PR: https://git.openjdk.org/jdk/pull/25956

From hannesw at openjdk.org  Wed Jun 25 05:43:32 2025
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Wed, 25 Jun 2025 05:43:32 GMT
Subject: [jdk25] Integrated: 8328848: Inaccuracy in the documentation of the
 -group option
In-Reply-To: <TPRFSAfHjdUyzr7jqtlJsCt_PFQ-fKO8PToepecDR88=.4c47b3da-03c3-4584-a707-0503888e75b2@github.com>
References: <TPRFSAfHjdUyzr7jqtlJsCt_PFQ-fKO8PToepecDR88=.4c47b3da-03c3-4584-a707-0503888e75b2@github.com>
Message-ID: <UxhFw0EtUs7P_7T46Burj_8hqdKpMuRW3ZgyymavcUE=.33ab9d07-751a-45b2-8015-5a25afca6f85@github.com>

On Tue, 24 Jun 2025 17:16:08 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> This pull request contains a backport of commit [f8de5bc5](https://github.com/openjdk/jdk/commit/f8de5bc5827742dd60b8f8f4a0d3625c370af15b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Hannes Walln?fer on 24 Jun 2025 and was reviewed by Chen Liang.

This pull request has now been integrated.

Changeset: 80cb773b
Author:    Hannes Walln?fer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/80cb773b7ee8e15ecae9a3ae12683363004e03f7
Stats:     4 lines in 2 files changed: 1 ins; 0 del; 3 mod

8328848: Inaccuracy in the documentation of the -group option

Reviewed-by: liach
Backport-of: f8de5bc5827742dd60b8f8f4a0d3625c370af15b

-------------

PR: https://git.openjdk.org/jdk/pull/25959

From jlu at openjdk.org  Wed Jun 25 17:01:42 2025
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 25 Jun 2025 17:01:42 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]
In-Reply-To: <EkV9jV9XTsut84ob-HuMVzhJzQYhFVWWjmPlA-p1ewU=.b85e2289-4e2b-437e-944c-7bb5aadfc0c0@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
 <WHNIK6WQ1Y5x33W8vaKCXZJ5MJjM40ODNx2cBohFtpQ=.434218f1-9099-4045-b90f-0c13a5a4a5dd@github.com>
 <EkV9jV9XTsut84ob-HuMVzhJzQYhFVWWjmPlA-p1ewU=.b85e2289-4e2b-437e-944c-7bb5aadfc0c0@github.com>
Message-ID: <8VlBIQujie_ZC5DVQHE_1GWD2RG8z6TZw2Vui2aOSEo=.dfd5df61-faab-4a95-b11b-125c8865d84e@github.com>

On Wed, 25 Jun 2025 00:27:48 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties line 49:
>> 
>>> 47: .Principal.=\t????\u0020
>>> 48: .Public.Credential.=\t??????:\u0020
>>> 49: .Private.Credential.=\t??????:\u0020
>> 
>> Why aren't the 2 lines above updated like in lines 46 and 47?
>
> I checked the ASCII codes here and on the source file. The updated colons are localized to full-width colons as @justin-curtis-lu mentioned in another thread here.
> 
> I agree. I also believe lines 48 & 49 need to be updated to the same type of colon. I don't see a good reason for why this was not updated as well. We may need to file a bug with the translators to resolve this inconsistency for next time. We should update these lines here now unless anyone else sees a reason not to.

If the context for these 2 values makes sense to use the full-width colon then let's update them here and we can file an issue with the translation team to get them synced.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2167196792

From achung at openjdk.org  Wed Jun 25 17:08:20 2025
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 25 Jun 2025 17:08:20 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v6]
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <A8-dFBI2Gk-VdqR_l4lwojVF5CZvIJ2ULOlDgHiSbNc=.ba1119c0-61ce-4a42-9e4c-0ea2f57145eb@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

Alisen Chung has updated the pull request incrementally with three additional commits since the last revision:

 - update majorticks translation
 - Merge branch '8359761' of github.com:alisenchung/jdk into 8359761
 - fix colon in chinese security.properties file

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25839/files
  - new: https://git.openjdk.org/jdk/pull/25839/files/97f3fe37..67990651

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=04-05

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/25839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839

PR: https://git.openjdk.org/jdk/pull/25839

From achung at openjdk.org  Wed Jun 25 17:14:30 2025
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 25 Jun 2025 17:14:30 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]
In-Reply-To: <8VlBIQujie_ZC5DVQHE_1GWD2RG8z6TZw2Vui2aOSEo=.dfd5df61-faab-4a95-b11b-125c8865d84e@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <0TCi0COBOv8n_PJEC7NpYpDEjwqZ_3Y8_GtOfYETI1Q=.2b1705fb-1afc-4ec5-8be2-d7bef70fa562@github.com>
 <WHNIK6WQ1Y5x33W8vaKCXZJ5MJjM40ODNx2cBohFtpQ=.434218f1-9099-4045-b90f-0c13a5a4a5dd@github.com>
 <EkV9jV9XTsut84ob-HuMVzhJzQYhFVWWjmPlA-p1ewU=.b85e2289-4e2b-437e-944c-7bb5aadfc0c0@github.com>
 <8VlBIQujie_ZC5DVQHE_1GWD2RG8z6TZw2Vui2aOSEo=.dfd5df61-faab-4a95-b11b-125c8865d84e@github.com>
Message-ID: <CMnvjWZDePPSAZ69wSOKZLnscDx2R5vNhJAw1OkZTi8=.c81ae441-6667-41df-8e84-2eeec2fb3d15@github.com>

On Wed, 25 Jun 2025 16:59:09 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> I checked the ASCII codes here and on the source file. The updated colons are localized to full-width colons as @justin-curtis-lu mentioned in another thread here.
>> 
>> I agree. I also believe lines 48 & 49 need to be updated to the same type of colon. I don't see a good reason for why this was not updated as well. We may need to file a bug with the translators to resolve this inconsistency for next time. We should update these lines here now unless anyone else sees a reason not to.
>
> If the context for these 2 values makes sense to use the full-width colon then let's update them here and we can file an issue with the translation team to get them synced.

There's more full width colons spread around in different properties files and I think the translation team just revisits lines and decides to change the colon, so these changes look a bit random to us. I've updated these specific colons to full width for now but I think it might be better to just let the translation team update them for each drop.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2167222866

From achung at openjdk.org  Wed Jun 25 20:22:31 2025
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 25 Jun 2025 20:22:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v6]
In-Reply-To: <A8-dFBI2Gk-VdqR_l4lwojVF5CZvIJ2ULOlDgHiSbNc=.ba1119c0-61ce-4a42-9e4c-0ea2f57145eb@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <A8-dFBI2Gk-VdqR_l4lwojVF5CZvIJ2ULOlDgHiSbNc=.ba1119c0-61ce-4a42-9e4c-0ea2f57145eb@github.com>
Message-ID: <Bot3EolwZjhUb3m62TbiB2D7LtowSu6VLXRIBmM2XfI=.92f0274b-629b-4b02-b25e-ecb71ff7f3c8@github.com>

On Wed, 25 Jun 2025 17:08:20 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - update majorticks translation
>  - Merge branch '8359761' of github.com:alisenchung/jdk into 8359761
>  - fix colon in chinese security.properties file

Currently running tests and everything looks green so far, @aivanov-jdk @sormuras do the German localizations look fine?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25839#issuecomment-3006029100

From jlu at openjdk.org  Wed Jun 25 21:19:31 2025
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 25 Jun 2025 21:19:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v6]
In-Reply-To: <A8-dFBI2Gk-VdqR_l4lwojVF5CZvIJ2ULOlDgHiSbNc=.ba1119c0-61ce-4a42-9e4c-0ea2f57145eb@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <A8-dFBI2Gk-VdqR_l4lwojVF5CZvIJ2ULOlDgHiSbNc=.ba1119c0-61ce-4a42-9e4c-0ea2f57145eb@github.com>
Message-ID: <7w3okXKFhjzXb1zG6J-pfS1skbQqOsmKnt9Wpxap83o=.1fb9f308-b219-4acb-9b75-8de05c43055d@github.com>

On Wed, 25 Jun 2025 17:08:20 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - update majorticks translation
>  - Merge branch '8359761' of github.com:alisenchung/jdk into 8359761
>  - fix colon in chinese security.properties file

Overall looks correct to me, and it seems you addressed all of the suggestions left by other reviewers. I skimmed most of the files for any glaring issues and also spot checked a few to make sure their associated English file had the correct corresponding change.

Left some small comments which should be addressed.

src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_de.properties line 36:

> 34: MSG_Help_mac_install=\  --mac-dmg-content <Pfad zu zus?tzlichem Inhalt>[,<Pfad zu zus?tzlichem Inhalt>...]\n          Nimmt den gesamten referenzierten Inhalt in die DMG-Datei auf.\n          Diese Option kann mehrmals verwendet werden. \n
> 35: MSG_Help_mac_launcher=\  --mac-package-identifier <ID-Zeichenfolge>\n          Eine ID, die die Anwendung f?r macOS eindeutig identifiziert\n          Standardwert ist der Hauptklassenname.\n          Es d?rfen nur alphanumerische Zeichen (A-Z, a-z, 0-9), Bindestriche (-)\n          und Punkte (.) verwendet werden.\n  --mac-package-name <Namenszeichenfolge>\n          Name der Anwendung, wie in der Men?leiste angezeigt\n          Dieser kann vom Anwendungsnamen abweichen.\n          Er darf maximal 15 Zeichen enthalten und muss f?r die Anzeige\n          in der Men?leiste und im Infofenster der Anwendung geeignet sein.\n          Standardwert: Anwendungsname.\n  --mac-package-signing-prefix <Pr?fixzeichenfolge>\n          Beim Signieren des Anwendungspackages wird dieser Wert\n          allen zu signierenden Komponenten ohne vorhandene\n          Package-ID als Pr?fix vorangestellt.\n  --mac-sign\n          Anforderung zum Signieren des Packages oder des vordefinierten\n
 Anwendungsimages\n  --mac-signing-keychain <Schl?sselbundname>\n          Name des Schl?sselbundes f?r die Suche nach der Signaturidentit?t\n          Bei fehlender Angabe werden die Standardschl?sselbunde verwendet.\n  --mac-signing-key-user-name <Teamname>\n          Team- oder Benutzernamensteil der Apple-Signaturidentit?ten. Um direkt zu steuern,\n          welche Signaturidentit?t zum Signieren eines Anwendungsimages oder\n          Installationsprogramms verwendet wird, verwenden Sie --mac-app-image-sign-identity und/oder\n          --mac-installer-sign-identity. Diese Option kann nicht mit\n          --mac-app-image-sign-identity oder --mac-installer-sign-identity kombiniert werden.\n  --mac-app-image-sign-identity <identity>\n          Zum Signieren des Anwendungsimages verwendete Identit?t. Dieser Wert wird\n          direkt an die Option --sign des Tools "codesign" ?bergeben. Diese Option kann nicht\n          mit --mac-signing-key-user-name kombiniert werden.\n  
 --mac-installer-sign-identity <identity>\n          Zum Signieren des Installationsprogramms "pkg" verwendete Identit?t. Dieser Wert wird\n          direkt an die Option --sign des Tools "productbuild" ?bergeben. Diese Option\n          kann nicht mit --mac-signing-key-user-name kombiniert werden.\n  --mac-app-store\n          Gibt an, dass die jpackage-Ausgabe f?r den\n          Mac App Store bestimmt ist.\n  --mac-entitlements <Dateipfad>\n          Pfad zu einer Datei mit Berechtigungen, die beim Signieren\n          von ausf?hrbaren Dateien und Librarys im Bundle verwendet werden sollen.\n  --mac-app-category <Kategoriezeichenfolge>\n          Zeichenfolge f?r das Erstellen von LSApplicationCategoryType in\n          Anwendungs-plist. Standardwert: "utilities".\n
> 36: MSG_Help_linux_install=\  --linux-package-name <Packagename>\n          Name f?r das Linux-Package, Standardwert: Anwendungsname\n  --linux-deb-maintainer <E-Mail-Adresse>\n          Maintainer f?r .deb-Package\n  --linux-menu-group <Men?gruppenname>\n          Men?gruppe, in der diese Anwendung abgelegt wird\n  --linux-package-deps <package-dep-string>\n          Erforderliche Packages oder Funktionen f?r die Anwendung\n  --linux-rpm-license-type <Typzeichenfolge>\n          Typ der Lizenz ("License: <Wert>" der RPM-SPEC-Datei)\n  --linux-app-release <Releasewert>\n          Releasewert der RPM-SPEC-Datei <Name> oder \n          Debian-Revisionswert der DEB-Kontrolldatei\n  --linux-app-category <Kategoriewert>\n          Gruppenwert der RPM-SPEC-Datei <Name> oder \n          Abschnittswert der DEB-Kontrolldatei\n  --linux-shortcut\n          Erstellt eine Verkn?pfung f?r die Anwendung.\n

"package-dep-string" is within "<>" and should not be translated. ja and zh_CN locales remain un-translated as well. I'd like this particular one to be reverted back and we can file an issue with the translation team.

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_en.wxl line 1:

> 1: <?xml version="1.0" encoding="utf-8"?>

This change can be reverted, the English file should not be touched anyways during l10n.

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/25839#pullrequestreview-2959683606
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2167643767
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2167645253

From achung at openjdk.org  Wed Jun 25 21:28:16 2025
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 25 Jun 2025 21:28:16 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  revert german translation, revert english wxl format change

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25839/files
  - new: https://git.openjdk.org/jdk/pull/25839/files/67990651..d54f457d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=05-06

  Stats: 21 lines in 2 files changed: 0 ins; 0 del; 21 mod
  Patch: https://git.openjdk.org/jdk/pull/25839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839

PR: https://git.openjdk.org/jdk/pull/25839

From jlu at openjdk.org  Wed Jun 25 21:43:31 2025
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 25 Jun 2025 21:43:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]
In-Reply-To: <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
Message-ID: <L30V0OupKPnDuj1v0M_paL96VPnJ4FBQpxbR-csL9qw=.c5a4c608-2a73-4002-95ad-7af701fad29e@github.com>

On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert german translation, revert english wxl format change

Marked as reviewed by jlu (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25839#pullrequestreview-2959749881

From jlu at openjdk.org  Wed Jun 25 22:55:33 2025
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 25 Jun 2025 22:55:33 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]
In-Reply-To: <570JPur5CDdEKtLyaTZEthUJePWje6-WK49sZNCBFEs=.058eb1d3-c0f4-48f3-90a4-cd29ad41dccf@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <1H_WgwF6mPWZ6l0Gjwg18qYBm8kS3-XKI2uXpgTqsFM=.73b2285c-23cc-4d9d-bed2-10feda82315f@github.com>
 <n42uuxgae9PBvLNZy8lNWD_HnTnj4pWFbsI1_8q2Wbc=.3a3ff3b3-b385-4ba0-9ece-f179dbac63d4@github.com>
 <SpVZ52poJGvsBGyuVB8B91ZEje1QaAafXfnEovQx0-I=.640d1f5f-8222-402a-b075-dea1ea46bd81@github.com>
 <ij3E2h5HHVXFll_xif0vHx4lrh6_QkTohC0rAZW2dGA=.03b17f7f-14cf-49bb-92c5-7f0033e6ccb7@github.com>
 <WuQvK5zsAIoLmBECTsLi2L1CDnyqyNyHhISc_Fmyel8=.b28647b1-80b6-44cf-bc67-5e9a6a4bb272@github.com>
 <570JPur5CDdEKtLyaTZEthUJePWje6-WK49sZNCBFEs=.058eb1d3-c0f4-48f3-90a4-cd29ad41dccf@github.com>
Message-ID: <9xiUCl6NKMT520fpbnfGriItpYYHh93M9Gn2T5nfEIE=.3e8ab340-855f-47cb-87ba-1d3275a37598@github.com>

On Tue, 24 Jun 2025 14:58:38 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> However, there is no space required between two Chinese sentences. In English, we usually write "I am here, and you are there." But in Chinese, with the full-width punctuation, it's always "??????????".
>
> Some people like to insert a space between a Chinese character and a Latin letter. I?m not a fan of this style, but I don?t feel strongly about it. However, adding a space between two Chinese characters or between a Chinese character and a full-width punctuation mark is unusual.

As discussed offline, since there are many instances of this, we will file an issue with the translation team and see if they will agree to the suggested changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2167774594

From dnguyen at openjdk.org  Thu Jun 26 00:18:39 2025
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 26 Jun 2025 00:18:39 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]
In-Reply-To: <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
Message-ID: <Qjn1b786Q_fqBZXGYAGl3IMk-YzmCrxtqRKk89XCng4=.e49c60eb-2751-41b4-ab25-283c00b3bb4d@github.com>

On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert german translation, revert english wxl format change

Marked as reviewed by dnguyen (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25839#pullrequestreview-2959999177

From cstein at openjdk.org  Thu Jun 26 05:23:31 2025
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 26 Jun 2025 05:23:31 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]
In-Reply-To: <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
Message-ID: <4Yu9Xo_LEoSLn6WwWbZB5GoLk0YroJfIT8B2izB5Y2k=.372e1dfb-bf3f-4ca7-be8c-edf13e87533c@github.com>

On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert german translation, revert english wxl format change

German `_de` translations look good to me.

-------------

Marked as reviewed by cstein (Committer).

PR Review: https://git.openjdk.org/jdk/pull/25839#pullrequestreview-2960590912

From naoto at openjdk.org  Thu Jun 26 16:11:35 2025
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 26 Jun 2025 16:11:35 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]
In-Reply-To: <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
Message-ID: <yCfy1s78TO0A4KkM8-Dsfwel3MyFrljHZZfcOY31X6o=.9826e189-d4d2-4166-9634-e35bd79cf55d@github.com>

On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert german translation, revert english wxl format change

Looks fine to me. Thanks, Alisen!

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25839#pullrequestreview-2962676541

From aivanov at openjdk.org  Thu Jun 26 17:32:34 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 26 Jun 2025 17:32:34 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]
In-Reply-To: <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
Message-ID: <6E-wE5Z32CVZsOTCjwVkJBY_WZWE69KJ1BmYcSRH26U=.90929e1a-7b80-4c8d-85b7-13714803cb9e@github.com>

On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert german translation, revert english wxl format change

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 461:

> 459: SliderDemo.majorticks=Hauptteilstriche
> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
> 461: SliderDemo.ticks=Hilfsteilstriche, zum Einrasten und Beschriften

@sormuras Is this the correct German? A follow-up from [previous discussion](https://github.com/openjdk/jdk/pull/25839#discussion_r2162982972).

Both *Einrasten* and *Beschriften* are verbs, aren't they? Why are they capitalised?

Should *Beschriften* rather be *Beschriftung*?

Would *Hilfsteilstriche, Einrasten an Teilstrichen, Beschriftungen* be a better translation?

src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 463:

> 461: SliderDemo.ticks=Hilfsteilstriche, zum Einrasten und Beschriften
> 462: SliderDemo.minorticks=Hilfsteilstriche
> 463: SliderDemo.minorticksdescription=Ein Schieberegler mit Haupt- und Hilfsteilstrichen, mit Teilstrichen, in die der Schieberegler einrastet, wobei einige Teilstriche mit einem sichtbaren Label versehen sind

This one is repetitive:
Suggestion:

SliderDemo.minorticksdescription=Ein Schieberegler mit Haupt- und Hilfsteilstrichen, in die der Schieberegler einrastet, wobei einige Teilstriche mit einer sichtbaren Beschriftung versehen sind

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2169540017
PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2169535281

From cstein at openjdk.org  Thu Jun 26 17:44:34 2025
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 26 Jun 2025 17:44:34 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]
In-Reply-To: <6E-wE5Z32CVZsOTCjwVkJBY_WZWE69KJ1BmYcSRH26U=.90929e1a-7b80-4c8d-85b7-13714803cb9e@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
 <6E-wE5Z32CVZsOTCjwVkJBY_WZWE69KJ1BmYcSRH26U=.90929e1a-7b80-4c8d-85b7-13714803cb9e@github.com>
Message-ID: <hFn5wmgbm5zMsnPdoOpOohNFpP1Rt1LK5xzezGmNW-g=.22beef9d-e3be-4862-819f-69da291a0c63@github.com>

On Thu, 26 Jun 2025 17:22:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert german translation, revert english wxl format change
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 461:
> 
>> 459: SliderDemo.majorticks=Hauptteilstriche
>> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
>> 461: SliderDemo.ticks=Hilfsteilstriche, zum Einrasten und Beschriften
> 
> @sormuras Is this the correct German? A follow-up from [previous discussion](https://github.com/openjdk/jdk/pull/25839#discussion_r2162982972).
> 
> Both *Einrasten* and *Beschriften* are verbs, aren't they? Why are they capitalised?
> 
> Should *Beschriften* rather be *Beschriftung*?
> 
> Would *Hilfsteilstriche, Einrasten an Teilstrichen, Beschriftungen* be a better translation?

You may (re-)use every German verb as a noun: [Substantivierung](https://de.wikipedia.org/wiki/Substantivierung)

> Would Hilfsteilstriche, Einrasten an Teilstrichen, Beschriftungen be a better translation?

Nein. Sounds too disrupted/distorted in my ears. If you really want to make it longer, it could read like:

_Hilfsteilstriche, an denen der Schieberegler einrastet und denen Beschriftungen angebracht werden k?nnen_

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2169576244

From achung at openjdk.org  Thu Jun 26 20:56:39 2025
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 26 Jun 2025 20:56:39 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v8]
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <wde0M3LUuqMdILh7rklStZmGCU3jZKf0ruVujEePt0c=.3601d7c3-7e4c-494c-9599-be3adb908f4e@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  Update src/demo/share/jfc/SwingSet2/resources/swingset_de.properties
  
  Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25839/files
  - new: https://git.openjdk.org/jdk/pull/25839/files/d54f457d..dcce2a39

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25839&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/25839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25839/head:pull/25839

PR: https://git.openjdk.org/jdk/pull/25839

From achung at openjdk.org  Thu Jun 26 20:56:40 2025
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 26 Jun 2025 20:56:40 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]
In-Reply-To: <hFn5wmgbm5zMsnPdoOpOohNFpP1Rt1LK5xzezGmNW-g=.22beef9d-e3be-4862-819f-69da291a0c63@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <ukl_ukcO4mp0UmS1YkfdmbsViiqkIWOq0CGhn58I-2A=.da968e7e-c61b-49b0-b3ed-c01c2031f477@github.com>
 <6E-wE5Z32CVZsOTCjwVkJBY_WZWE69KJ1BmYcSRH26U=.90929e1a-7b80-4c8d-85b7-13714803cb9e@github.com>
 <hFn5wmgbm5zMsnPdoOpOohNFpP1Rt1LK5xzezGmNW-g=.22beef9d-e3be-4862-819f-69da291a0c63@github.com>
Message-ID: <SglYkl97hMPTI35H7e9VncJTC3GWAW2mRgU72vGs3eI=.d8f3e462-116e-4530-bc97-bb4cab345fb7@github.com>

On Thu, 26 Jun 2025 17:41:13 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 461:
>> 
>>> 459: SliderDemo.majorticks=Hauptteilstriche
>>> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit Hauptteilstrichen
>>> 461: SliderDemo.ticks=Hilfsteilstriche, zum Einrasten und Beschriften
>> 
>> @sormuras Is this the correct German? A follow-up from [previous discussion](https://github.com/openjdk/jdk/pull/25839#discussion_r2162982972).
>> 
>> Both *Einrasten* and *Beschriften* are verbs, aren't they? Why are they capitalised?
>> 
>> Should *Beschriften* rather be *Beschriftung*?
>> 
>> Would *Hilfsteilstriche, Einrasten an Teilstrichen, Beschriftungen* be a better translation?
>
> You may (re-)use every German verb as a noun: [Substantivierung](https://de.wikipedia.org/wiki/Substantivierung)
> 
>> Would Hilfsteilstriche, Einrasten an Teilstrichen, Beschriftungen be a better translation?
> 
> Nein. Sounds too disrupted/distorted in my ears. If you really want to make it longer, it could read like:
> 
> _Hilfsteilstriche, an denen der Schieberegler einrastet und denen Beschriftungen angebracht werden k?nnen_

Maybe better to leave this one as is and next drop the translation team can take another look

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25839#discussion_r2169956970

From aivanov at openjdk.org  Fri Jun 27 11:57:44 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Jun 2025 11:57:44 GMT
Subject: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v8]
In-Reply-To: <wde0M3LUuqMdILh7rklStZmGCU3jZKf0ruVujEePt0c=.3601d7c3-7e4c-494c-9599-be3adb908f4e@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
 <wde0M3LUuqMdILh7rklStZmGCU3jZKf0ruVujEePt0c=.3601d7c3-7e4c-494c-9599-be3adb908f4e@github.com>
Message-ID: <vWI5H8ceYQIjIidhY4mIYGYza-hAcdeWODbUDEsvWCM=.281ca419-7152-43a9-b2be-8fd5f2e163c8@github.com>

On Thu, 26 Jun 2025 20:56:39 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/demo/share/jfc/SwingSet2/resources/swingset_de.properties
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25839#pullrequestreview-2966237280

From achung at openjdk.org  Fri Jun 27 16:15:51 2025
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 27 Jun 2025 16:15:51 GMT
Subject: Integrated: 8359761: JDK 25 RDP1 L10n resource files update
In-Reply-To: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
References: <yFHtJVbU6-KK5KZN8Gq40D5qT8GYsm3gw-EILhejTr4=.49bda9de-d594-4774-a644-d87b6ec6561b@github.com>
Message-ID: <GF5IDxTAhXqzc73VVys13RSJKUc87JeYqSfSPXZjZWM=.997990aa-1178-4323-83b0-de46c0f2b455@github.com>

On Tue, 17 Jun 2025 01:22:31 GMT, Alisen Chung <achung at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.

This pull request has now been integrated.

Changeset: da7080ff
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/da7080fffb2389465dc9afca6d02e9085fe15302
Stats:     1196 lines in 71 files changed: 814 ins; 93 del; 289 mod

8359761: JDK 25 RDP1 L10n resource files update

Reviewed-by: aivanov, almatvee, nbenalla, jlu, dnguyen, cstein, naoto

-------------

PR: https://git.openjdk.org/jdk/pull/25839

From achung at openjdk.org  Fri Jun 27 18:31:40 2025
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 27 Jun 2025 18:31:40 GMT
Subject: [jdk25] RFR: 8359761: JDK 25 RDP1 L10n resource files update
Message-ID: <Z-0Oad8hly2CCUVUO68zsuIi18AffuFUgomulIw9_H0=.594abd54-1017-4506-a736-d22ac12ad574@github.com>

8359761: JDK 25 RDP1 L10n resource files update

-------------

Commit messages:
 - Backport da7080fffb2389465dc9afca6d02e9085fe15302

Changes: https://git.openjdk.org/jdk/pull/26026/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26026&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8359761
  Stats: 1196 lines in 71 files changed: 814 ins; 93 del; 289 mod
  Patch: https://git.openjdk.org/jdk/pull/26026.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26026/head:pull/26026

PR: https://git.openjdk.org/jdk/pull/26026

From jlu at openjdk.org  Fri Jun 27 18:48:40 2025
From: jlu at openjdk.org (Justin Lu)
Date: Fri, 27 Jun 2025 18:48:40 GMT
Subject: [jdk25] RFR: 8359761: JDK 25 RDP1 L10n resource files update
In-Reply-To: <Z-0Oad8hly2CCUVUO68zsuIi18AffuFUgomulIw9_H0=.594abd54-1017-4506-a736-d22ac12ad574@github.com>
References: <Z-0Oad8hly2CCUVUO68zsuIi18AffuFUgomulIw9_H0=.594abd54-1017-4506-a736-d22ac12ad574@github.com>
Message-ID: <K1-1d3pNRFgWpkSWz0z37g8bv6FZDptY3FqWn6mA1YM=.b1642fa3-3131-475d-be48-e46ae826b1ca@github.com>

On Fri, 27 Jun 2025 18:27:15 GMT, Alisen Chung <achung at openjdk.org> wrote:

> 8359761: JDK 25 RDP1 L10n resource files update

Marked as reviewed by jlu (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/26026#pullrequestreview-2967612181

From aivanov at openjdk.org  Fri Jun 27 18:58:42 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 27 Jun 2025 18:58:42 GMT
Subject: [jdk25] RFR: 8359761: JDK 25 RDP1 L10n resource files update
In-Reply-To: <Z-0Oad8hly2CCUVUO68zsuIi18AffuFUgomulIw9_H0=.594abd54-1017-4506-a736-d22ac12ad574@github.com>
References: <Z-0Oad8hly2CCUVUO68zsuIi18AffuFUgomulIw9_H0=.594abd54-1017-4506-a736-d22ac12ad574@github.com>
Message-ID: <kg51-qmlCGiGQD2uT5jUV-tXzjg56nUx10DltgKO0xY=.eec85c62-ad07-4181-bfcb-37b946b625b3@github.com>

On Fri, 27 Jun 2025 18:27:15 GMT, Alisen Chung <achung at openjdk.org> wrote:

> 8359761: JDK 25 RDP1 L10n resource files update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/26026#pullrequestreview-2967634176

From achung at openjdk.org  Fri Jun 27 19:31:01 2025
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 27 Jun 2025 19:31:01 GMT
Subject: [jdk25] Integrated: 8359761: JDK 25 RDP1 L10n resource files update
In-Reply-To: <Z-0Oad8hly2CCUVUO68zsuIi18AffuFUgomulIw9_H0=.594abd54-1017-4506-a736-d22ac12ad574@github.com>
References: <Z-0Oad8hly2CCUVUO68zsuIi18AffuFUgomulIw9_H0=.594abd54-1017-4506-a736-d22ac12ad574@github.com>
Message-ID: <Lvees89-ahp6rs1DC7OJnMRzhPaBlrM8HoOj1YDdGq4=.d69d8c1f-63dc-43e3-a8d4-bd98d3bb8670@github.com>

On Fri, 27 Jun 2025 18:27:15 GMT, Alisen Chung <achung at openjdk.org> wrote:

> 8359761: JDK 25 RDP1 L10n resource files update

This pull request has now been integrated.

Changeset: 12ffb0c1
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/12ffb0c131c5100dc23549b9b7216625bc0dab9e
Stats:     1196 lines in 71 files changed: 814 ins; 93 del; 289 mod

8359761: JDK 25 RDP1 L10n resource files update

Reviewed-by: jlu, aivanov
Backport-of: da7080fffb2389465dc9afca6d02e9085fe15302

-------------

PR: https://git.openjdk.org/jdk/pull/26026