RFR: 8349369: test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on missing man page files [v2]
Hannes Wallnöfer
hannesw at openjdk.org
Thu Jun 5 10:56:02 UTC 2025
On Wed, 4 Jun 2025 15:12:19 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Please review this small update to make the test more robust, the test did not always check links to other files if they did not contain a fragment or a `#`symbol.
>>
>> I'd like to add that the original [doccheck](https://github.com/openjdk/doccheck) also didn't pick up on these missing files when I ran it.
>>
>> TIA
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - improve based on feedback
> - Merge branch 'master' into update-link-checker
> - Merge branch 'master' into update-link-checker
> - Merge branch 'master' into update-link-checker
> - update link checker to verify that files exist
Looks good to me.
-------------
Marked as reviewed by hannesw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23441#pullrequestreview-2899824560
More information about the javadoc-dev
mailing list