RFR: 8177100: APIs duplicated in JavaDoc [v7]
Nizar Benalla
nbenalla at openjdk.org
Tue Jun 24 10:32:53 UTC 2025
On Tue, 10 Jun 2025 14:20:19 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>>
>> - Feedback from @hns - Expand test with new test cases
>> - Merge branch 'master' into duplicate-APIs
>> - revert back to simple earlier fix
>> - revert back to master
>> - Merge branch 'master' into duplicate-APIs
>> - Merge branch 'master' into duplicate-APIs
>> - rename test to be more accurate and simplify code
>> - update javadoc
>> - Merge branch 'master' into duplicate-APIs
>> - new approach - make sure there is no negative effect on JDK doc output
>> - ... and 4 more: https://git.openjdk.org/jdk/compare/89246a82...caeb20ad
>
> test/langtools/jdk/javadoc/doclet/testDuplicateMethodsWarn/TestDuplicateMethods.java line 181:
>
>> 179: checkExit(Exit.OK);
>> 180:
>> 181: checkOutput("sb/U.html", false,
>
> Could you add a positive check to this test and `testHashMapInheritance` that the method is documented as expected (as local method in this test, and as inherited from the public abstract class in `testHashMapInheritance`), and that the method details has a "Specified by: ..." entry pointing to the interface method?
Updated the test to add a positive check. Tests are currently running in CI.
If the update look trivial enough, could you set the reviewer count back to 1?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25123#discussion_r2163574291
More information about the javadoc-dev
mailing list