RFR: 8350920: Allow inherited member summaries to be viewed inline [v3]
Hannes Wallnöfer
hannesw at openjdk.org
Tue Mar 25 04:35:19 UTC 2025
> Please review an enhancement to allow switching between the traditional condensed footnote-style summary and the summary table format for inherited members (types, fields, methods and properties) that are inherited from included types. You can test the feature in [the doc bundle I uploaded][apidocs] or watch the short screencast below.
>
> [apidocs]: https://cr.openjdk.org/~hannesw/8350920/api.00/java.base/module-summary.html
>
> https://github.com/user-attachments/assets/0aaa1f8b-c18b-4922-b704-2b2cdc05ca79
>
> I added two new protected methods to the `AbstractMemberWriter` class, `createInheritedSummaryTable` and `getInheritedSummaryId`. Otherwise this is mostly reusing existing functionality (we already had the feature to display the signature of an inherited method in the context of the current class).
>
> The writers for non-inheritable members such as constructors or enum constants were simplified a bit by implementing formerly abstract methods in `AbstractMemberWriter` as concrete methods throwing `UnsupportedOperationException` so they don't have to be implemented as empty methods in these writers.
>
> The UI to switch between member list presentations is implemented in `script.js.template`. If no summary list presentation is available (because the supertype is not part of the documentation bundle) nothing changes in the UI.
>
> I added a `stripTags()` method to `Content` to return the plain text content with HTML tags stripped that could be used in a few other places. The patch also adds two new vector graphics files called right.svg and down.svg for the right and downwards pointing angle.
Hannes Wallnöfer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
- Merge branch 'master' into JDK-8350920
- Merge branch 'master' into JDK-8350920
- Add svg files
- 8350920: Allow inherited member summaries to be viewed inline
-------------
Changes: https://git.openjdk.org/jdk/pull/23967/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23967&range=02
Stats: 521 lines in 27 files changed: 409 ins; 55 del; 57 mod
Patch: https://git.openjdk.org/jdk/pull/23967.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23967/head:pull/23967
PR: https://git.openjdk.org/jdk/pull/23967
More information about the javadoc-dev
mailing list