RFR: 8351332: Line breaks in search tag descriptions corrupt JSON search index [v2]
Nizar Benalla
nbenalla at openjdk.org
Tue Mar 25 11:40:35 UTC 2025
On Tue, 25 Mar 2025 10:50:19 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> Apologies. Whitespace is indeed allowed in certain keys, I thought that the Labels would mostly be references (links) but titles and headers are also included in the Index files.
>
> One thing I noticed is that we have this kind of `"\\s+"` to `" "` whitespace normalization in other related places, notably in `IndexTaglet.java` and `SpecTaglet.java`. Would it make sense to unify the functionality somewhere there, and do it before passing the strings over to `IndexItem`?
Updated in [3e04020](https://github.com/openjdk/jdk/pull/24202/commits/3e040204520084254fbed5d1e4245d13aa24cf42).
I added a new method in `Utils.java` and replaced most uses of `.replaceAll("\\s+", " ")` with it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24202#discussion_r2011906511
More information about the javadoc-dev
mailing list