RFR: 8351332: Line breaks in search tag descriptions corrupt JSON search index [v2]
Hannes Wallnöfer
hannesw at openjdk.org
Tue Mar 25 14:21:28 UTC 2025
On Tue, 25 Mar 2025 11:40:35 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Please review this patch to fix an issue in the `tag-search-index.js` generation.
>>
>> The problem was in the `toJSON()` method of `IndexItem`. When adding the description, it's using `escapeQuotes(description)` which only escapes backslashes and quotes, but doesn't normalize whitespace.
>>
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> move logic of normalizing whitespace to the common utils class
Looks good to me. A doc comment on the new utils method would be nice.
-------------
Marked as reviewed by hannesw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24202#pullrequestreview-2713954463
More information about the javadoc-dev
mailing list