Integrated: 8276966: Improve diagnostic output for the mismatching parts of a hybrid snippet
Hannes Wallnöfer
hannesw at openjdk.org
Fri Oct 3 15:56:32 UTC 2025
On Fri, 3 Oct 2025 11:07:02 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
> Please review a trivial change to improve the error output for hybrid snippets with mismatching inline and external snippet text.
>
> Since the logging code drops trailing blank lines, differences in trailing whitespace were not displayed properly. See [JDK-8304408](https://bugs.openjdk.org/browse/JDK-8304408) for an example where this occurs. By adding a terminal separator we make sure trailing blank lines are not discarded. This makes it also easier to see where the snippet diff ends.
>
> Old output:
>
>
> ----------------- inline -------------------
> inline snippet
> ----------------- external -----------------
> external snippet
>
>
> New output:
>
>
> ----------------- inline -------------------
> inline snippet
> ----------------- external -----------------
> external snippet
> --------------------------------------------
This pull request has now been integrated.
Changeset: f81c7c59
Author: Hannes Wallnöfer <hannesw at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/f81c7c592bbc9f5575ed41e41d12f54cbfc5e4aa
Stats: 15 lines in 2 files changed: 11 ins; 0 del; 4 mod
8276966: Improve diagnostic output for the mismatching parts of a hybrid snippet
Reviewed-by: prappo
-------------
PR: https://git.openjdk.org/jdk/pull/27621
More information about the javadoc-dev
mailing list