RFR: 8361366: Allow sorting of member details in lexicographical order [v5]
Nizar Benalla
nbenalla at openjdk.org
Mon Oct 13 14:31:26 UTC 2025
On Mon, 13 Oct 2025 14:27:56 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Please review this patch to add a toggle to order the member details in the table of contents in lexical order. The selected choice is stored and preserved.
>>
>> Here is a preview of the new toggle.
>>
>>
>> https://github.com/user-attachments/assets/55c81e4b-5fc0-416e-8946-53aede419640
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>
> - Merge branch 'master' into toc-toggle
>
> # Conflicts:
> # src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/stylesheet.css
> - improve implementation based on feedback
> - member details should also be sorted
> - Merge branch 'refs/heads/master' into toc-toggle
> - Merge branch 'master' into toc-toggle
>
> # Conflicts:
> # src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java
> - Merge branch 'master' into toc-toggle
>
> # Conflicts:
> # src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java
> - make toc.js resilient to being loaded after script.js
> - add toggle to sort TOC in lexical order
I couldn't include a `cr.openjdk` link due to some issues with uploading.
I have updated the PR to fix the issues that were brought up in the review (sorting section headers, adding a visual cue etc)
Here is what the button looks like now if it is selected.
<img width="882" height="397" alt="Screenshot 2025-10-13 at 15 26 56" src="https://github.com/user-attachments/assets/a36b0670-0779-4055-9e19-710b5688f16e" />
<img width="914" height="384" alt="Screenshot 2025-10-13 at 15 26 48" src="https://github.com/user-attachments/assets/bfbef971-b9d2-4afa-8454-3d9e9af4bd51" />
<img width="806" height="376" alt="Screenshot 2025-10-13 at 15 27 06" src="https://github.com/user-attachments/assets/a31bcc97-f37c-48da-ae16-5c2ddefdd377" />
<img width="1018" height="511" alt="Screenshot 2025-10-13 at 15 27 12" src="https://github.com/user-attachments/assets/26d2bbcd-b575-404f-98ce-04e528849285" />
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26322#issuecomment-3397766876
More information about the javadoc-dev
mailing list