RFR: 8361366: Allow sorting of member details in lexicographical order [v7]
Hannes Wallnöfer
hannesw at openjdk.org
Wed Oct 15 12:30:50 UTC 2025
On Tue, 14 Oct 2025 16:26:24 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Please review this patch to add a toggle to order the member details in the table of contents in lexical order. The selected choice is stored and preserved.
>>
>> Here is a preview of the new toggle.
>>
>>
>> https://github.com/user-attachments/assets/55c81e4b-5fc0-416e-8946-53aede419640
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> remove redundant css
Changes requested by hannesw (Reviewer).
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties line 255:
> 253: doclet.table_of_contents=Table of contents
> 254: doclet.Sort_lexicographically=Sort lexicographically
> 255: doclet.Sort_by_source_order=Sort by source order
Would be nice to add what is being sorted: "Sort member details lexicographically/by source order".
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties line 261:
> 259: doclet.filter_table_of_contents=Filter table of contents
> 260: doclet.filter_reset=Reset
> 261: doclet.sort_table_of_contents=Sort table of contents members in lexicographical order
I think "table of contents members" should be replaced with "member details".
-------------
PR Review: https://git.openjdk.org/jdk/pull/26322#pullrequestreview-3340107914
PR Review Comment: https://git.openjdk.org/jdk/pull/26322#discussion_r2432367296
PR Review Comment: https://git.openjdk.org/jdk/pull/26322#discussion_r2432370495
More information about the javadoc-dev
mailing list