RFR: 8361366: Allow sorting of member details in lexicographical order [v7]

Nizar Benalla nbenalla at openjdk.org
Fri Oct 17 10:27:31 UTC 2025


On Wed, 15 Oct 2025 13:21:55 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove redundant css
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script.js.template line 808:
> 
>> 806:         reorderMemberDetailsAlpha();
>> 807:         allTocNavs().forEach(sortTocAlpha);
>> 808:         initSectionData(); prevHash = null; handleScroll();
> 
> We should not set `prevHash = null` here and in the method below. It causes the TOC to scroll even if the viewed section has not changed, which is not useful. 
> 
> Imagine a user loading a class page, scrolling the TOC down to method details, realizing that method details are sorted in source order, and clicking the "Sort" button. Scrolling the TOC back up to the beginning is not useful, it should remain at its current position.

Fixed in https://github.com/openjdk/jdk/pull/26322/commits/424e38547d7a88bb37941966fe674a16be4748e2, Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26322#discussion_r2439213365


More information about the javadoc-dev mailing list