RFR: 8366278: Form control element <select> has no associated label [v2]
Pasam Soujanya
duke at openjdk.org
Thu Sep 11 10:09:18 UTC 2025
On Thu, 11 Sep 2025 09:52:31 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> Pasam Soujanya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Form control select should have a aria-label
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 792:
>
>> 790:
>> 791: doclet.searchModules=\
>> 792: Search the specified content in the modules.
>
> The change looks good regarding the code, but I'm not sure about naming/wording. I think `doclet.selectModule` and "Select the module to search in" would better describe the element.
Updated as suggested. Thank you.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26982#discussion_r2339934878
More information about the javadoc-dev
mailing list