RFR: 8367321: Fix CSS bugs in dark theme [v2]
Hannes Wallnöfer
hannesw at openjdk.org
Tue Sep 30 13:05:29 UTC 2025
On Fri, 26 Sep 2025 09:30:42 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> Please review a change to fix various problems with the recently introduced dark theme for API docs:
>>
>> - Minimizes flickering when page is loaded with dark theme ([before](https://download.java.net/java/early_access/jdk26/docs/api/allclasses-index.html) / [after](https://cr.openjdk.org/~hannesw/8366942/api.00/allclasses-index.html))
>> - Fixes link color in table captions of inherited member summaries and class use pages ([before](https://download.java.net/java/early_access/jdk26/docs/api/java.base/java/lang/Exception.html#method-summary) / [after](https://cr.openjdk.org/~hannesw/8366942/api.00/java.base/java/lang/Exception.html#method-summary))
>> - Fixes section color in Serialized Form page ([before](https://download.java.net/java/early_access/jdk26/docs/api/serialized-form.html) / [after](https://cr.openjdk.org/~hannesw/8366942/api.00/serialized-form.html))
>>
>> The change also includes some JS and CSS refactoring/cleanup.
>>
>> Generated documentation was tested on Firefox, Chrome and Safari and [can be viewed here](https://cr.openjdk.org/~hannesw/8366942/api.00/java.base/module-summary.html) (module java.base only).
>
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
>
> Adjust table colors
Thanks for looking into this!
> It's out of scope for this change, but we may want to look at our CSS file for duplicate properties using a linter.
I know we have duplicate custom properties, but there is no way around this, at least as far as I can tell. We need two sets of properties per theme for 1) the "native" theme that is not in conflict with the OS setting, and 2) the "non-native" theme that overrides the OS setting.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27191#issuecomment-3352017819
More information about the javadoc-dev
mailing list