RFR: 8284315: DocTrees.getElement is inconsistent with Elements.getTypeElement [v2]
Vicente Romero
vromero at openjdk.org
Thu Feb 26 18:02:40 UTC 2026
On Thu, 26 Feb 2026 17:49:20 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> Please review a change that brings the implementation of `DocTrees.getElement(DocTreePath)` in agreement with `javax.lang.model` behavior by returning `null` for `DocTree` instances referring to a primitive or array type. Additionally, this adds some missing functionality to the implementation of the related `DocTrees.getType(DocTreePath)` method and improves test coverage for both methods.
>>
>> Internally, the member lookup part in method `JavacTrees.attributeDocReference` is split into a separate `resolveMember` method that can also be used by `getType`.
>>
>> We also improve attribution of references with explicit module name by attempting to attribute the referenced type and checking whether the module matches the name in the reference afterwards. This allows us to support parameterized types in references with explicit module id.
>>
>> In `test/langtools/tools/javac/doctree/ReferenceTest.java` we add some missing test coverage such as for type parameter references, and add tests for `DocTrees.getType(DocTreePath)` to the existing tests for `DocTrees.getElement(DocTreePath)`. The former was previously ony covered in javadoc tests.
>
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review feedback
lgtm
-------------
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29547#pullrequestreview-3862685639
More information about the javadoc-dev
mailing list