<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Roman,</p>
<p>You are welcome to file a PR, subject to OCA rules, etc, but that
being said, your comparison does not seem like a valid fix for <span style="mso-fareast-language:EN-US" lang="EN-US">JDK-8297437.</span></p>
<p><span style="mso-fareast-language:EN-US" lang="EN-US">Once again,
I emphasise to you that the `--source` option is not a valid way
to determine the output format, as you do in these lines of
getValidHtmlName.</span></p>
<table class=" diff-table js-diff-table tab-size " data-tab-size="8" data-diff-anchor="diff-22d9182196ae739a6de9c29801bb3ca788992b0cbf44564b2aeda2018a7b78e1" data-paste-markdown-skip="" style="box-sizing: border-box;
border-spacing: 0px; border-collapse: separate; width: 1150px;
tab-size: 8; caret-color: rgb(36, 41, 47); color: rgb(36, 41, 47);
font-family: -apple-system, BlinkMacSystemFont, "Segoe
UI", "Noto Sans", Helvetica, Arial, sans-serif,
"Apple Color Emoji", "Segoe UI Emoji";
font-size: 14px; font-style: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: auto;
text-align: start; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; text-decoration: none;">
<tbody style="box-sizing: border-box;">
<tr data-hunk="39e82f8513d5fe58ee2296da56d48d10d052ebfcd4b86ac11d7ace3af49f8b5d" class="show-top-border" style="box-sizing: border-box;">
<td class="blob-code blob-code-addition js-file-line" style="box-sizing: border-box; padding: 0px 10px 0px 22px;
position: relative; line-height: 20px; vertical-align: top;
background-color: var(--color-diff-blob-addition-line-bg);
outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker js-code-nav-pass " data-code-marker="+" style="box-sizing: border-box; display: table-cell; overflow: visible; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 12px; color: var(--color-fg-default); overflow-wrap: anywhere; white-space: pre;">{</span></td>
</tr>
<tr data-hunk="39e82f8513d5fe58ee2296da56d48d10d052ebfcd4b86ac11d7ace3af49f8b5d" class="show-top-border" style="box-sizing: border-box;">
<td class="blob-num blob-num-addition empty-cell" style="box-sizing: border-box; padding: 0px 10px; position:
relative; width: 50px; min-width: 50px; font-family:
ui-monospace, SFMono-Regular, "SF Mono", Menlo,
Consolas, "Liberation Mono", monospace; font-size:
12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td id="diff-22d9182196ae739a6de9c29801bb3ca788992b0cbf44564b2aeda2018a7b78e1R553" data-line-number="553" class="blob-num blob-num-addition
js-linkable-line-number js-code-nav-line-number
js-blob-rnum" style="box-sizing: border-box; padding: 0px
10px; position: relative; width: 50px; min-width: 50px;
font-family: ui-monospace, SFMono-Regular, "SF
Mono", Menlo, Consolas, "Liberation Mono",
monospace; font-size: 12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td class="blob-code blob-code-addition js-file-line" style="box-sizing: border-box; padding: 0px 10px 0px 22px;
position: relative; line-height: 20px; vertical-align: top;
background-color: var(--color-diff-blob-addition-line-bg);
outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker js-code-nav-pass " data-code-marker="+" style="box-sizing: border-box; display: table-cell; overflow: visible; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 12px; color: var(--color-fg-default); overflow-wrap: anywhere; white-space: pre;"> <span class="pl-smi" style="box-sizing: border-box; color: var(--color-prettylights-syntax-storage-modifier-import);">SourceVersion</span> <span class="pl-s1" style="box-sizing: border-box;">srcVer</span> = <span class="pl-s1" style="box-sizing: border-box;">configuration</span>.<span class="pl-s1" style="box-sizing: border-box;">docEnv</span>.<span class="pl-en" style="box-sizing: border-box; color: var(--color-prettylights-syntax-entity);">getSourceVersion</span>();</span></td>
</tr>
<tr data-hunk="39e82f8513d5fe58ee2296da56d48d10d052ebfcd4b86ac11d7ace3af49f8b5d" class="show-top-border" style="box-sizing: border-box;">
<td class="blob-num blob-num-addition empty-cell" style="box-sizing: border-box; padding: 0px 10px; position:
relative; width: 50px; min-width: 50px; font-family:
ui-monospace, SFMono-Regular, "SF Mono", Menlo,
Consolas, "Liberation Mono", monospace; font-size:
12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td id="diff-22d9182196ae739a6de9c29801bb3ca788992b0cbf44564b2aeda2018a7b78e1R554" data-line-number="554" class="blob-num blob-num-addition
js-linkable-line-number js-code-nav-line-number
js-blob-rnum" style="box-sizing: border-box; padding: 0px
10px; position: relative; width: 50px; min-width: 50px;
font-family: ui-monospace, SFMono-Regular, "SF
Mono", Menlo, Consolas, "Liberation Mono",
monospace; font-size: 12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td class="blob-code blob-code-addition js-file-line" style="box-sizing: border-box; padding: 0px 10px 0px 22px;
position: relative; line-height: 20px; vertical-align: top;
background-color: var(--color-diff-blob-addition-line-bg);
outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker js-code-nav-pass " data-code-marker="+" style="box-sizing: border-box; display: table-cell; overflow: visible; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 12px; color: var(--color-fg-default); overflow-wrap: anywhere; white-space: pre;"> <span class="pl-k" style="box-sizing: border-box; color: var(--color-prettylights-syntax-keyword);">if</span> (<span class="pl-smi" style="box-sizing: border-box; color: var(--color-prettylights-syntax-storage-modifier-import);">SourceVersion</span>.<span class="pl-c1" style="box-sizing: border-box; color: var(--color-prettylights-syntax-constant);">RELEASE_8</span> != <span class="pl-s1" style="box-sizing: border-box;">srcVer</span> && <span class="pl-smi" style="box-sizing: border-box; color: var(--color-prettylights-syntax-storage-modifier-import);">SourceVersion</span>.<span class="pl-c1" style="box-sizing: border-box; color: var(--color-prettylights-syntax-constant);">RELEASE_9</span> != <span class="pl-s1" style="box-sizing: border-box;">srcVer</span>) {</span></td>
</tr>
<tr data-hunk="39e82f8513d5fe58ee2296da56d48d10d052ebfcd4b86ac11d7ace3af49f8b5d" class="show-top-border" style="box-sizing: border-box;">
<td class="blob-num blob-num-addition empty-cell" style="box-sizing: border-box; padding: 0px 10px; position:
relative; width: 50px; min-width: 50px; font-family:
ui-monospace, SFMono-Regular, "SF Mono", Menlo,
Consolas, "Liberation Mono", monospace; font-size:
12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td id="diff-22d9182196ae739a6de9c29801bb3ca788992b0cbf44564b2aeda2018a7b78e1R555" data-line-number="555" class="blob-num blob-num-addition
js-linkable-line-number js-code-nav-line-number
js-blob-rnum" style="box-sizing: border-box; padding: 0px
10px; position: relative; width: 50px; min-width: 50px;
font-family: ui-monospace, SFMono-Regular, "SF
Mono", Menlo, Consolas, "Liberation Mono",
monospace; font-size: 12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td class="blob-code blob-code-addition js-file-line" style="box-sizing: border-box; padding: 0px 10px 0px 22px;
position: relative; line-height: 20px; vertical-align: top;
background-color: var(--color-diff-blob-addition-line-bg);
outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker js-code-nav-pass " data-code-marker="+" style="box-sizing: border-box; display: table-cell; overflow: visible; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 12px; color: var(--color-fg-default); overflow-wrap: anywhere; white-space: pre;"> <span class="pl-k" style="box-sizing: border-box; color: var(--color-prettylights-syntax-keyword);">return</span> <span class="pl-s1" style="box-sizing: border-box;">name</span>;</span></td>
</tr>
<tr data-hunk="39e82f8513d5fe58ee2296da56d48d10d052ebfcd4b86ac11d7ace3af49f8b5d" class="show-top-border" style="box-sizing: border-box;">
<td class="blob-num blob-num-addition empty-cell" style="box-sizing: border-box; padding: 0px 10px; position:
relative; width: 50px; min-width: 50px; font-family:
ui-monospace, SFMono-Regular, "SF Mono", Menlo,
Consolas, "Liberation Mono", monospace; font-size:
12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td id="diff-22d9182196ae739a6de9c29801bb3ca788992b0cbf44564b2aeda2018a7b78e1R556" data-line-number="556" class="blob-num blob-num-addition
js-linkable-line-number js-code-nav-line-number
js-blob-rnum" style="box-sizing: border-box; padding: 0px
10px; position: relative; width: 50px; min-width: 50px;
font-family: ui-monospace, SFMono-Regular, "SF
Mono", Menlo, Consolas, "Liberation Mono",
monospace; font-size: 12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td class="blob-code blob-code-addition js-file-line" style="box-sizing: border-box; padding: 0px 10px 0px 22px;
position: relative; line-height: 20px; vertical-align: top;
background-color: var(--color-diff-blob-addition-line-bg);
outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker js-code-nav-pass " data-code-marker="+" style="box-sizing: border-box; display: table-cell; overflow: visible; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 12px; color: var(--color-fg-default); overflow-wrap: anywhere; white-space: pre;"> }</span></td>
</tr>
<tr data-hunk="39e82f8513d5fe58ee2296da56d48d10d052ebfcd4b86ac11d7ace3af49f8b5d" class="show-top-border" style="box-sizing: border-box;">
<td class="blob-num blob-num-addition empty-cell is-hovered" style="box-sizing: border-box; padding: 0px 10px; position:
relative; width: 50px; min-width: 50px; font-family:
ui-monospace, SFMono-Regular, "SF Mono", Menlo,
Consolas, "Liberation Mono", monospace; font-size:
12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td id="diff-22d9182196ae739a6de9c29801bb3ca788992b0cbf44564b2aeda2018a7b78e1R557" data-line-number="557" class="blob-num blob-num-addition
js-linkable-line-number js-code-nav-line-number js-blob-rnum
is-hovered" style="box-sizing: border-box; padding: 0px
10px; position: relative; width: 50px; min-width: 50px;
font-family: ui-monospace, SFMono-Regular, "SF
Mono", Menlo, Consolas, "Liberation Mono",
monospace; font-size: 12px; line-height: 20px; color:
var(--color-diff-blob-addition-num-text); text-align: right;
white-space: nowrap; vertical-align: top; cursor: pointer;
-webkit-user-select: none; background-color:
var(--color-diff-blob-addition-num-bg); border-color:
var(--color-success-emphasis);"><br>
</td>
<td class="blob-code blob-code-addition js-file-line
is-hovered" style="box-sizing: border-box; padding: 0px 10px
0px 22px; position: relative; line-height: 20px;
vertical-align: top; background-color:
var(--color-diff-blob-addition-line-bg); outline:
transparent dotted 1px;"><span class="blob-code-inner blob-code-marker js-code-nav-pass " data-code-marker="+" style="box-sizing: border-box; display: table-cell; overflow: visible; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 12px; color: var(--color-fg-default); overflow-wrap: anywhere; white-space: pre;"> }</span></td>
</tr>
</tbody>
</table>
<p><span style="mso-fareast-language:EN-US" lang="EN-US"></span></p>
<p><span style="mso-fareast-language:EN-US" lang="EN-US">If nothing
else, the code above makes far too simple a choice: the correct
choice will depend on the library being linked to. When
running javadoc on some "recent" code, some of the libraries
being linked to may have been generated by JDK8-era javadoc
(with HTML4-style ids) and others may have been generated by
more recent versions of javadoc (with HTML5-style ids).<br>
</span></p>
<p><span style="mso-fareast-language:EN-US" lang="EN-US">-- Jon <br>
</span></p>
<p><span style="mso-fareast-language:EN-US" lang="EN-US"><br>
</span></p>
<div class="moz-cite-prefix">On 12/9/22 4:48 AM, Roman Marchenko
wrote:<br>
</div>
<blockquote type="cite" cite="mid:DM8PR11MB5736E429661C529C5D76AC41BF1C9@DM8PR11MB5736.namprd11.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}span.EmailStyle21
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US" lang="EN-US">Hi Jon,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US" lang="EN-US">May I propose a fix for
</span><span style="mso-fareast-language:EN-US" lang="EN-US">JDK-8297437?</span><span style="mso-fareast-language:EN-US" lang="EN-US">
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US" lang="EN-US">I prepared the changes in my JDK fork, so here
is the branch comparison:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US" lang="EN-US"><a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/compare/master...wkia:jdk:fix-8297437__;!!ACWV5N9M2RV99hQ!Oo1QGcqNfPQkQgSk0twA8OLpeeyls4wp1DTAly44LtwabfZp6TB5yyhH5lKYS9Y9yAG8V_mAbmCmaMMFHXRUk55v$" moz-do-not-send="true">https://github.com/openjdk/jdk/compare/master...wkia:jdk:fix-8297437</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US" lang="EN-US">If it’s appropriate I’d create a pull request.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US" lang="EN-US">Thanks.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- </span>R<span lang="EN-US">o</span>man<o:p></o:p></p>
</div>
</blockquote>
</body>
</html>