<div dir="ltr">Oh, many thanks, Hannes!<div><br></div><div>That error was hiding in plain sight right before my eyes… also because the IDE (IntelliJ) links it incorrectly too.</div><div><br></div><div>Best regards,<br>Stefano</div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Fri, Nov 14, 2025 at 7:08 PM Hannes Wallnoefer <<a href="mailto:hannes.wallnoefer@oracle.com">hannes.wallnoefer@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
Hi Stefano,
<div><br>
</div>
<div>DEFAULT_DIRECTION is not a constant in enum Direction[1], it's a field in the enclosing Sort class[2]. So the new bahaviour of JavaDoc is actually correct.</div>
<div><br>
</div>
<div>[1]: <a href="https://github.com/spring-projects/spring-batch-extensions/blob/deb1c6d7890d8a25312f765724ec5078aaf8a691/spring-batch-notion/src/main/java/org/springframework/batch/extensions/notion/Sort.java#L111-L133" target="_blank">https://github.com/spring-projects/spring-batch-extensions/blob/deb1c6d7890d8a25312f765724ec5078aaf8a691/spring-batch-notion/src/main/java/org/springframework/batch/extensions/notion/Sort.java#L111-L133</a></div>
<div><br>
</div>
<div>[2]: <a href="https://github.com/spring-projects/spring-batch-extensions/blob/deb1c6d7890d8a25312f765724ec5078aaf8a691/spring-batch-notion/src/main/java/org/springframework/batch/extensions/notion/Sort.java#L38" target="_blank">https://github.com/spring-projects/spring-batch-extensions/blob/deb1c6d7890d8a25312f765724ec5078aaf8a691/spring-batch-notion/src/main/java/org/springframework/batch/extensions/notion/Sort.java#L38</a></div>
<div><br>
</div>
<div>Unfortunately JavaDoc used to accept this kind of invalid link. It was fixed in 23:</div>
<div><br>
</div>
<div><a href="https://bugs.openjdk.org/browse/JDK-8164094" target="_blank">https://bugs.openjdk.org/browse/JDK-8164094</a></div>
<div><br>
</div>
<div>It’s quite an easy mistake to make if you don’t get an error for it. We also had several instances of this in JDK source code.</div>
<div><br>
</div>
<div>Hannes</div>
<div><br id="m_-2261714916697939491lineBreakAtBeginningOfMessage">
<div><br>
<blockquote type="cite">
<div>On 11.11.2025, at 17:10, Stefano Cordio <<a href="mailto:stefano.cordio@gmail.com" target="_blank">stefano.cordio@gmail.com</a>> wrote:</div>
<br>
<div>
<div dir="ltr">Hello everyone,
<div><br>
</div>
<div>I am upgrading a project's build from Java 21 to Java 25, and Javadoc generation fails with the following error:</div>
<div><br>
</div>
<div>
<pre><code>[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar (attach-javadoc) on project spring-batch-notion: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1
[ERROR] /home/runner/work/spring-batch-extensions/spring-batch-extensions/spring-batch-notion/src/main/java/org/springframework/batch/extensions/notion/Sort.java:29: error: reference not found
[ERROR] * The direction defaults to {@link Direction#DEFAULT_DIRECTION}.
[ERROR] ^
[ERROR] The generated documentation contains diagnostic markers for invalid input.
[ERROR] 1 error
[ERROR] Command line was: /usr/lib/jvm/temurin-25-jdk-amd64/bin/javadoc -J-Duser.language= -J-Duser.country= @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/home/runner/work/spring-batch-extensions/spring-batch-extensions/spring-batch-notion/target/reports/apidocs' dir.</code></pre>
</div>
<div><br>
</div>
<div>Given that it was working fine on 21, I imagine it could be a regression.</div>
<div><br>
</div>
<div>Reference: <a href="https://github.com/spring-projects/spring-batch-extensions/pull/192" target="_blank">https://github.com/spring-projects/spring-batch-extensions/pull/192</a></div>
<div><br>
</div>
<div>Thanks in advance for any feedback!</div>
<div><br>
</div>
<div>Best regards,</div>
<div>Stefano</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote></div>