From alexey.fedorchenko at oracle.com Wed Apr 4 22:34:38 2018 From: alexey.fedorchenko at oracle.com (alexey.fedorchenko at oracle.com) Date: Wed, 04 Apr 2018 22:34:38 +0000 Subject: hg: code-tools/jcov: temporary add an old tag for the latest jtreg compatibility Message-ID: <201804042234.w34MYcab012191@aojmv0008.oracle.com> Changeset: 391790f13cfd Author: afedorch Date: 2018-04-04 15:29 -0700 URL: http://hg.openjdk.java.net/code-tools/jcov/rev/391790f13cfd temporary add an old tag for the latest jtreg compatibility ! .hgtags From alexey.fedorchenko at oracle.com Thu Apr 5 18:36:22 2018 From: alexey.fedorchenko at oracle.com (Alexey Fedorchenko) Date: Thu, 5 Apr 2018 11:36:22 -0700 Subject: RFR 7902143: Add an ANC filter that takes method list as input In-Reply-To: <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> References: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> Message-ID: <8774E3A6-508E-47AB-9476-FDED07D4AE5F@oracle.com> Hello! Thanks for the patch! I will review the content of the changes. Please, look at these items: - the changes for the build.xml looks like a diff to your local copy and not to the latest repo state: http://hg.openjdk.java.net/code-tools/jcov/file/391790f13cfd/build/build.xml#l165 (The target was set to 1.7 long time ago) - please, send a patch not a diff (I will be able to push it from your name) - do you plan to provide any execution mechanism for the /test/unit ? Thank you. ?Alexey > On Apr 4, 2018, at 3:44 PM, Alexandre (Shura) Iline wrote: > > > >> On Apr 4, 2018, at 1:25 PM, Alexandre (Shura) Iline wrote: >> >> Hi. >> >> Please take a look on this new ANC filter: >> http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ >> >> Please notice that beyond actually adding the functionality I am suggesting to >> 1. allow to use Java 7 features >> 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. >> >> Shura > From alexey.fedorchenko at oracle.com Fri Apr 6 19:32:36 2018 From: alexey.fedorchenko at oracle.com (Alexey Fedorchenko) Date: Fri, 6 Apr 2018 12:32:36 -0700 Subject: RFR 7902143: Add an ANC filter that takes method list as input In-Reply-To: <5BEB35D2-DD10-4681-919A-797645DF9566@oracle.com> References: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> <8774E3A6-508E-47AB-9476-FDED07D4AE5F@oracle.com> <5BEB35D2-DD10-4681-919A-797645DF9566@oracle.com> Message-ID: <83A8FEF8-9DE0-4A5D-BD5A-7CFA6DE12E89@oracle.com> The new ?parameterized? filters should be excluded from ?all? filters (because there is no parameter for these filters in this case). The idea to fail if default filter is not found looks reasonable (if the filter is listed in the loader, it should be present). I am not sure that the filter should fail full report generation process if there is an error (but unexpected result is also not the best choice), anyway the current default anc filters are simple and do not log/throw any errors and we can have this ?full fail? rule. ?Alexey > On Apr 5, 2018, at 1:57 PM, Alexandre (Shura) Iline wrote: > > I will fix the web rev to the latest code, thanks. > > I do not think you need to commit for me - I will commit myself when you are OK with the changes, putting you as a reviewer. > > Are you OK with the actual code changes, though? > > Shura > > >> On Apr 5, 2018, at 11:36 AM, Alexey Fedorchenko > wrote: >> >> Hello! >> >> Thanks for the patch! I will review the content of the changes. >> >> Please, look at these items: >> - the changes for the build.xml looks like a diff to your local copy and not to the latest repo state: >> http://hg.openjdk.java.net/code-tools/jcov/file/391790f13cfd/build/build.xml#l165 >> (The target was set to 1.7 long time ago) >> - please, send a patch not a diff (I will be able to push it from your name) >> - do you plan to provide any execution mechanism for the /test/unit ? >> >> Thank you. >> >> ?Alexey >> >>> On Apr 4, 2018, at 3:44 PM, Alexandre (Shura) Iline > wrote: >>> >>> >>> >>>> On Apr 4, 2018, at 1:25 PM, Alexandre (Shura) Iline > wrote: >>>> >>>> Hi. >>>> >>>> Please take a look on this new ANC filter: >>>> http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ >>>> >>>> Please notice that beyond actually adding the functionality I am suggesting to >>>> 1. allow to use Java 7 features >>>> 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. >>>> >>>> Shura >>> >> > From alexandre.iline at oracle.com Sat Apr 7 01:44:56 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Fri, 6 Apr 2018 18:44:56 -0700 Subject: RFR 7902143: Add an ANC filter that takes method list as input In-Reply-To: <83A8FEF8-9DE0-4A5D-BD5A-7CFA6DE12E89@oracle.com> References: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> <8774E3A6-508E-47AB-9476-FDED07D4AE5F@oracle.com> <5BEB35D2-DD10-4681-919A-797645DF9566@oracle.com> <83A8FEF8-9DE0-4A5D-BD5A-7CFA6DE12E89@oracle.com> Message-ID: <9AB1DC6A-F8E4-40BA-9F54-AD2887B932FB@oracle.com> Updated to the last source and fixed the ?all? filters problem. New web rev: http://cr.openjdk.java.net/~shurailine/7902143/webrev.01/ Thank you Shura > On Apr 6, 2018, at 12:32 PM, Alexey Fedorchenko wrote: > > The new ?parameterized? filters should be excluded from ?all? filters (because there is no parameter for these filters in this case). > > The idea to fail if default filter is not found looks reasonable (if the filter is listed in the loader, it should be present). > I am not sure that the filter should fail full report generation process if there is an error (but unexpected result is also not the best > choice), anyway the current default anc filters are simple and do not log/throw any errors and we can have this ?full fail? rule. > > ?Alexey > > >> On Apr 5, 2018, at 1:57 PM, Alexandre (Shura) Iline > wrote: >> >> I will fix the web rev to the latest code, thanks. >> >> I do not think you need to commit for me - I will commit myself when you are OK with the changes, putting you as a reviewer. >> >> Are you OK with the actual code changes, though? >> >> Shura >> >> >>> On Apr 5, 2018, at 11:36 AM, Alexey Fedorchenko > wrote: >>> >>> Hello! >>> >>> Thanks for the patch! I will review the content of the changes. >>> >>> Please, look at these items: >>> - the changes for the build.xml looks like a diff to your local copy and not to the latest repo state: >>> http://hg.openjdk.java.net/code-tools/jcov/file/391790f13cfd/build/build.xml#l165 >>> (The target was set to 1.7 long time ago) >>> - please, send a patch not a diff (I will be able to push it from your name) >>> - do you plan to provide any execution mechanism for the /test/unit ? >>> >>> Thank you. >>> >>> ?Alexey >>> >>>> On Apr 4, 2018, at 3:44 PM, Alexandre (Shura) Iline > wrote: >>>> >>>> >>>> >>>>> On Apr 4, 2018, at 1:25 PM, Alexandre (Shura) Iline > wrote: >>>>> >>>>> Hi. >>>>> >>>>> Please take a look on this new ANC filter: >>>>> http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ >>>>> >>>>> Please notice that beyond actually adding the functionality I am suggesting to >>>>> 1. allow to use Java 7 features >>>>> 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. >>>>> >>>>> Shura >>>> >>> >> > From alexey.fedorchenko at oracle.com Sat Apr 7 02:15:47 2018 From: alexey.fedorchenko at oracle.com (Alexey Fedorchenko) Date: Fri, 6 Apr 2018 19:15:47 -0700 Subject: RFR 7902143: Add an ANC filter that takes method list as input In-Reply-To: <9AB1DC6A-F8E4-40BA-9F54-AD2887B932FB@oracle.com> References: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> <8774E3A6-508E-47AB-9476-FDED07D4AE5F@oracle.com> <5BEB35D2-DD10-4681-919A-797645DF9566@oracle.com> <83A8FEF8-9DE0-4A5D-BD5A-7CFA6DE12E89@oracle.com> <9AB1DC6A-F8E4-40BA-9F54-AD2887B932FB@oracle.com> Message-ID: <5A5AF70B-4133-4B64-A6ED-89828500838E@oracle.com> Hello! Please, take a look at these issues: - typo in ListANCFilter javadoc: ?of" -> ?or?. - empty lines in the end of RepGen. - imports in RepGen is something in the middle between the old and ?optimized" by IDE (we need to chose any side here) - typo in the class name: ?ParameterisedAncFilter" -> ?ParameterizedAncFilter" - The logic if condition in the RepGen is incorrect: The code verifies if the filter is ParameterisedAncFilter and if it is not - throws an exception. That breaks all default not parameterized filters. - ListANCFilterTest uses the Files.newBufferedWriter(file) method from 1.8, but minimal version is 7: https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#newBufferedReader-java.nio.file.Path- Charset.defaultCharset() should help. ?Alexey > On Apr 6, 2018, at 6:44 PM, Alexandre (Shura) Iline wrote: > > Updated to the last source and fixed the ?all? filters problem. > > New web rev: http://cr.openjdk.java.net/~shurailine/7902143/webrev.01/ > > Thank you > > Shura > >> On Apr 6, 2018, at 12:32 PM, Alexey Fedorchenko > wrote: >> >> The new ?parameterized? filters should be excluded from ?all? filters (because there is no parameter for these filters in this case). >> >> The idea to fail if default filter is not found looks reasonable (if the filter is listed in the loader, it should be present). >> I am not sure that the filter should fail full report generation process if there is an error (but unexpected result is also not the best >> choice), anyway the current default anc filters are simple and do not log/throw any errors and we can have this ?full fail? rule. >> >> ?Alexey >> >> >>> On Apr 5, 2018, at 1:57 PM, Alexandre (Shura) Iline > wrote: >>> >>> I will fix the web rev to the latest code, thanks. >>> >>> I do not think you need to commit for me - I will commit myself when you are OK with the changes, putting you as a reviewer. >>> >>> Are you OK with the actual code changes, though? >>> >>> Shura >>> >>> >>>> On Apr 5, 2018, at 11:36 AM, Alexey Fedorchenko > wrote: >>>> >>>> Hello! >>>> >>>> Thanks for the patch! I will review the content of the changes. >>>> >>>> Please, look at these items: >>>> - the changes for the build.xml looks like a diff to your local copy and not to the latest repo state: >>>> http://hg.openjdk.java.net/code-tools/jcov/file/391790f13cfd/build/build.xml#l165 >>>> (The target was set to 1.7 long time ago) >>>> - please, send a patch not a diff (I will be able to push it from your name) >>>> - do you plan to provide any execution mechanism for the /test/unit ? >>>> >>>> Thank you. >>>> >>>> ?Alexey >>>> >>>>> On Apr 4, 2018, at 3:44 PM, Alexandre (Shura) Iline > wrote: >>>>> >>>>> >>>>> >>>>>> On Apr 4, 2018, at 1:25 PM, Alexandre (Shura) Iline > wrote: >>>>>> >>>>>> Hi. >>>>>> >>>>>> Please take a look on this new ANC filter: >>>>>> http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ >>>>>> >>>>>> Please notice that beyond actually adding the functionality I am suggesting to >>>>>> 1. allow to use Java 7 features >>>>>> 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. >>>>>> >>>>>> Shura From alexandre.iline at oracle.com Mon Apr 9 18:51:11 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Mon, 9 Apr 2018 11:51:11 -0700 Subject: RFR 7902143: Add an ANC filter that takes method list as input In-Reply-To: <5A5AF70B-4133-4B64-A6ED-89828500838E@oracle.com> References: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> <8774E3A6-508E-47AB-9476-FDED07D4AE5F@oracle.com> <5BEB35D2-DD10-4681-919A-797645DF9566@oracle.com> <83A8FEF8-9DE0-4A5D-BD5A-7CFA6DE12E89@oracle.com> <9AB1DC6A-F8E4-40BA-9F54-AD2887B932FB@oracle.com> <5A5AF70B-4133-4B64-A6ED-89828500838E@oracle.com> Message-ID: <4E66D47A-118E-4A32-A1E3-404A342412EC@oracle.com> New version: http://cr.openjdk.java.net/~shurailine/7902143/webrev.02/ More inline. > On Apr 6, 2018, at 7:15 PM, Alexey Fedorchenko wrote: > > Hello! > > Please, take a look at these issues: > > - typo in ListANCFilter javadoc: ?of" -> ?or?. > > - empty lines in the end of RepGen. > > - imports in RepGen is something in the middle between the old and ?optimized" by IDE (we need to chose any side here) I have reverted to the old order. You are right that a choice of IDE should not dictate order of imports. > > - typo in the class name: ?ParameterisedAncFilter" -> ?ParameterizedAncFilter? Turns out, ?parameterised? is British and ?parameterized? is American. Who knew? Fixed that. > > - The logic if condition in the RepGen is incorrect: > The code verifies if the filter is ParameterisedAncFilter and if it is not - throws an exception. > That breaks all default not parameterized filters. Yeah, sorry about that. Last minute changes ... That is why tests are needed. Fixed. > > - ListANCFilterTest uses the Files.newBufferedWriter(file) method from 1.8, but minimal version is 7: > https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#newBufferedReader-java.nio.file.Path- > Charset.defaultCharset() should help. I actually do not see a problem with using JDK8 for tests, but this case clearly does not justify the trouble of setting test JDK separately. Fixed. Shura > > ?Alexey > > >> On Apr 6, 2018, at 6:44 PM, Alexandre (Shura) Iline > wrote: >> >> Updated to the last source and fixed the ?all? filters problem. >> >> New web rev: http://cr.openjdk.java.net/~shurailine/7902143/webrev.01/ >> >> Thank you >> >> Shura >> >>> On Apr 6, 2018, at 12:32 PM, Alexey Fedorchenko > wrote: >>> >>> The new ?parameterized? filters should be excluded from ?all? filters (because there is no parameter for these filters in this case). >>> >>> The idea to fail if default filter is not found looks reasonable (if the filter is listed in the loader, it should be present). >>> I am not sure that the filter should fail full report generation process if there is an error (but unexpected result is also not the best >>> choice), anyway the current default anc filters are simple and do not log/throw any errors and we can have this ?full fail? rule. >>> >>> ?Alexey >>> >>> >>>> On Apr 5, 2018, at 1:57 PM, Alexandre (Shura) Iline > wrote: >>>> >>>> I will fix the web rev to the latest code, thanks. >>>> >>>> I do not think you need to commit for me - I will commit myself when you are OK with the changes, putting you as a reviewer. >>>> >>>> Are you OK with the actual code changes, though? >>>> >>>> Shura >>>> >>>> >>>>> On Apr 5, 2018, at 11:36 AM, Alexey Fedorchenko > wrote: >>>>> >>>>> Hello! >>>>> >>>>> Thanks for the patch! I will review the content of the changes. >>>>> >>>>> Please, look at these items: >>>>> - the changes for the build.xml looks like a diff to your local copy and not to the latest repo state: >>>>> http://hg.openjdk.java.net/code-tools/jcov/file/391790f13cfd/build/build.xml#l165 >>>>> (The target was set to 1.7 long time ago) >>>>> - please, send a patch not a diff (I will be able to push it from your name) >>>>> - do you plan to provide any execution mechanism for the /test/unit ? >>>>> >>>>> Thank you. >>>>> >>>>> ?Alexey >>>>> >>>>>> On Apr 4, 2018, at 3:44 PM, Alexandre (Shura) Iline > wrote: >>>>>> >>>>>> >>>>>> >>>>>>> On Apr 4, 2018, at 1:25 PM, Alexandre (Shura) Iline > wrote: >>>>>>> >>>>>>> Hi. >>>>>>> >>>>>>> Please take a look on this new ANC filter: >>>>>>> http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ >>>>>>> >>>>>>> Please notice that beyond actually adding the functionality I am suggesting to >>>>>>> 1. allow to use Java 7 features >>>>>>> 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. >>>>>>> >>>>>>> Shura > From alexey.fedorchenko at oracle.com Tue Apr 10 21:54:22 2018 From: alexey.fedorchenko at oracle.com (Alexey Fedorchenko) Date: Tue, 10 Apr 2018 14:54:22 -0700 Subject: RFR 7902143: Add an ANC filter that takes method list as input In-Reply-To: <4E66D47A-118E-4A32-A1E3-404A342412EC@oracle.com> References: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> <8774E3A6-508E-47AB-9476-FDED07D4AE5F@oracle.com> <5BEB35D2-DD10-4681-919A-797645DF9566@oracle.com> <83A8FEF8-9DE0-4A5D-BD5A-7CFA6DE12E89@oracle.com> <9AB1DC6A-F8E4-40BA-9F54-AD2887B932FB@oracle.com> <5A5AF70B-4133-4B64-A6ED-89828500838E@oracle.com> <4E66D47A-118E-4A32-A1E3-404A342412EC@oracle.com> Message-ID: <56C4278B-9918-433D-BAAF-6BDB21227245@oracle.com> Hello! Looks good to me, thank you! ?Alexey > On Apr 9, 2018, at 11:51 AM, Alexandre (Shura) Iline wrote: > > New version: http://cr.openjdk.java.net/~shurailine/7902143/webrev.02/ > > More inline. > >> On Apr 6, 2018, at 7:15 PM, Alexey Fedorchenko > wrote: >> >> Hello! >> >> Please, take a look at these issues: >> >> - typo in ListANCFilter javadoc: ?of" -> ?or?. >> >> - empty lines in the end of RepGen. >> >> - imports in RepGen is something in the middle between the old and ?optimized" by IDE (we need to chose any side here) > > I have reverted to the old order. You are right that a choice of IDE should not dictate order of imports. > >> >> - typo in the class name: ?ParameterisedAncFilter" -> ?ParameterizedAncFilter? > > Turns out, ?parameterised? is British and ?parameterized? is American. Who knew? Fixed that. > >> >> - The logic if condition in the RepGen is incorrect: >> The code verifies if the filter is ParameterisedAncFilter and if it is not - throws an exception. >> That breaks all default not parameterized filters. > > Yeah, sorry about that. Last minute changes ... That is why tests are needed. Fixed. > >> >> - ListANCFilterTest uses the Files.newBufferedWriter(file) method from 1.8, but minimal version is 7: >> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#newBufferedReader-java.nio.file.Path- >> Charset.defaultCharset() should help. > > I actually do not see a problem with using JDK8 for tests, but this case clearly does not justify the trouble of setting test JDK separately. Fixed. > > Shura > >> >> ?Alexey >> >> >>> On Apr 6, 2018, at 6:44 PM, Alexandre (Shura) Iline > wrote: >>> >>> Updated to the last source and fixed the ?all? filters problem. >>> >>> New web rev: http://cr.openjdk.java.net/~shurailine/7902143/webrev.01/ >>> >>> Thank you >>> >>> Shura >>> >>>> On Apr 6, 2018, at 12:32 PM, Alexey Fedorchenko > wrote: >>>> >>>> The new ?parameterized? filters should be excluded from ?all? filters (because there is no parameter for these filters in this case). >>>> >>>> The idea to fail if default filter is not found looks reasonable (if the filter is listed in the loader, it should be present). >>>> I am not sure that the filter should fail full report generation process if there is an error (but unexpected result is also not the best >>>> choice), anyway the current default anc filters are simple and do not log/throw any errors and we can have this ?full fail? rule. >>>> >>>> ?Alexey >>>> >>>> >>>>> On Apr 5, 2018, at 1:57 PM, Alexandre (Shura) Iline > wrote: >>>>> >>>>> I will fix the web rev to the latest code, thanks. >>>>> >>>>> I do not think you need to commit for me - I will commit myself when you are OK with the changes, putting you as a reviewer. >>>>> >>>>> Are you OK with the actual code changes, though? >>>>> >>>>> Shura >>>>> >>>>> >>>>>> On Apr 5, 2018, at 11:36 AM, Alexey Fedorchenko > wrote: >>>>>> >>>>>> Hello! >>>>>> >>>>>> Thanks for the patch! I will review the content of the changes. >>>>>> >>>>>> Please, look at these items: >>>>>> - the changes for the build.xml looks like a diff to your local copy and not to the latest repo state: >>>>>> http://hg.openjdk.java.net/code-tools/jcov/file/391790f13cfd/build/build.xml#l165 >>>>>> (The target was set to 1.7 long time ago) >>>>>> - please, send a patch not a diff (I will be able to push it from your name) >>>>>> - do you plan to provide any execution mechanism for the /test/unit ? >>>>>> >>>>>> Thank you. >>>>>> >>>>>> ?Alexey >>>>>> >>>>>>> On Apr 4, 2018, at 3:44 PM, Alexandre (Shura) Iline > wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>> On Apr 4, 2018, at 1:25 PM, Alexandre (Shura) Iline > wrote: >>>>>>>> >>>>>>>> Hi. >>>>>>>> >>>>>>>> Please take a look on this new ANC filter: >>>>>>>> http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ >>>>>>>> >>>>>>>> Please notice that beyond actually adding the functionality I am suggesting to >>>>>>>> 1. allow to use Java 7 features >>>>>>>> 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. >>>>>>>> >>>>>>>> Shura >> > From alexandre.iline at oracle.com Wed Apr 11 15:44:51 2018 From: alexandre.iline at oracle.com (alexandre.iline at oracle.com) Date: Wed, 11 Apr 2018 15:44:51 +0000 Subject: hg: code-tools/jcov: 7902143: Add an ANC filter that takes method list as input Message-ID: <201804111544.w3BFipFo029871@aojmv0008.oracle.com> Changeset: b7fab35801d1 Author: shurailine Date: 2018-04-11 01:44 -0700 URL: http://hg.openjdk.java.net/code-tools/jcov/rev/b7fab35801d1 7902143: Add an ANC filter that takes method list as input Reviewed-by: afedorch ! build/build.xml ! src/classes/com/sun/tdk/jcov/RepGen.java + src/classes/com/sun/tdk/jcov/report/ParameterizedAncFilter.java + src/classes/com/sun/tdk/jcov/report/ancfilters/ListANCFilter.java + test/unit/com/sun/tdk/jcov/report/ancfilters/ListANCFilterTest.java From alexey.fedorchenko at oracle.com Thu Apr 12 18:53:17 2018 From: alexey.fedorchenko at oracle.com (alexey.fedorchenko at oracle.com) Date: Thu, 12 Apr 2018 18:53:17 +0000 Subject: hg: code-tools/jcov: CODETOOLS-7902147 RepGen -javap does not work Message-ID: <201804121853.w3CIrHiw029322@aojmv0008.oracle.com> Changeset: 0b9e41807b07 Author: afedorch Date: 2018-04-12 11:49 -0700 URL: http://hg.openjdk.java.net/code-tools/jcov/rev/0b9e41807b07 CODETOOLS-7902147 RepGen -javap does not work ! src/classes/com/sun/tdk/jcov/RepGen.java ! src/classes/com/sun/tdk/jcov/ant/Report.java ! src/classes/com/sun/tdk/jcov/report/javap/JavapRepGen.java From alexandre.iline at oracle.com Wed Apr 4 20:25:19 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Wed, 04 Apr 2018 20:25:19 -0000 Subject: RFR 7902143: Add an ANC filter that takes method list as input Message-ID: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> Hi. Please take a look on this new ANC filter: http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ Please notice that beyond actually adding the functionality I am suggesting to 1. allow to use Java 7 features 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. Shura From alexandre.iline at oracle.com Wed Apr 4 22:44:48 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Wed, 04 Apr 2018 22:44:48 -0000 Subject: RFR 7902143: Add an ANC filter that takes method list as input In-Reply-To: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> References: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> Message-ID: <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> > On Apr 4, 2018, at 1:25 PM, Alexandre (Shura) Iline wrote: > > Hi. > > Please take a look on this new ANC filter: > http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ > > Please notice that beyond actually adding the functionality I am suggesting to > 1. allow to use Java 7 features > 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. > > Shura From alexandre.iline at oracle.com Thu Apr 5 20:57:46 2018 From: alexandre.iline at oracle.com (Alexandre (Shura) Iline) Date: Thu, 05 Apr 2018 20:57:46 -0000 Subject: RFR 7902143: Add an ANC filter that takes method list as input In-Reply-To: <8774E3A6-508E-47AB-9476-FDED07D4AE5F@oracle.com> References: <7D78FD83-1B03-4D10-97A3-3FBF0CA2E618@oracle.com> <55129F16-9D26-47EE-B75A-F155BD29BB93@oracle.com> <8774E3A6-508E-47AB-9476-FDED07D4AE5F@oracle.com> Message-ID: <5BEB35D2-DD10-4681-919A-797645DF9566@oracle.com> I will fix the web rev to the latest code, thanks. I do not think you need to commit for me - I will commit myself when you are OK with the changes, putting you as a reviewer. Are you OK with the actual code changes, though? Shura > On Apr 5, 2018, at 11:36 AM, Alexey Fedorchenko wrote: > > Hello! > > Thanks for the patch! I will review the content of the changes. > > Please, look at these items: > - the changes for the build.xml looks like a diff to your local copy and not to the latest repo state: > http://hg.openjdk.java.net/code-tools/jcov/file/391790f13cfd/build/build.xml#l165 > (The target was set to 1.7 long time ago) > - please, send a patch not a diff (I will be able to push it from your name) > - do you plan to provide any execution mechanism for the /test/unit ? > > Thank you. > > ?Alexey > >> On Apr 4, 2018, at 3:44 PM, Alexandre (Shura) Iline > wrote: >> >> >> >>> On Apr 4, 2018, at 1:25 PM, Alexandre (Shura) Iline > wrote: >>> >>> Hi. >>> >>> Please take a look on this new ANC filter: >>> http://cr.openjdk.java.net/~shurailine/7902143/webrev.00/ >>> >>> Please notice that beyond actually adding the functionality I am suggesting to >>> 1. allow to use Java 7 features >>> 2. change RepGen behavior in regards to errors in ANC filters. It should not just print a message - it should fail. >>> >>> Shura >> >