RFR 7902258: Only one parametrized ANC filter is allowed simultaneously

[Leonid Kuskov]

Hi,

The fix looks good.

Thanks,
Leonid


On 8/2/18 14:21, Alexandre (Shura) Iline wrote:
> Hi,
>
> Please review this fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902258
> Webrev: http://cr.openjdk.java.net/~shurailine/7902258/webrev.01/
>
> The fix adds new concept: AncFilterFactory. Instances of that factory are loaded as services. ANC filters themselves are no longer loaded as services. This makes this change functionally incompatible. Since there is no longer a need to distinguish ANC filters by name, there is no longer any need in DefaultANCFilter (which should have probably been called “named ANC filter” in the first place).
>
> There is one possible additional fix which will need to be done later: get rid of ParameterizedAncFilter class. If the instantiation are done by a factory, there is no need for that class as factory should be able to instantiate the filter using parameter value passed as an additional parameter or just as a part of parameter to instantiate(String) method.
>
> Thank you
>
> Shura
>
>