From lkuskov at openjdk.java.net Wed Jul 15 02:48:19 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 15 Jul 2020 02:48:19 GMT Subject: RFR: 7902535: Code coverage does not work in JDK 8 Message-ID: <39RDmVMwAzQsybd7F68j_VDT4c5lfz_E7lGu1BfVn-s=.436af705-aa34-4d89-b234-861a0459a3b8@github.com> This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902535 In JDK 8 Collect.hit method is called prior to the Collect class initialization. This causes cyclic throwing NPE. Also added cosmetic fix to RepGen to avoid double report about internal failures ------------- Commit messages: - 7902535: Code coverage does not work in JDK 8 Changes: https://git.openjdk.java.net/jcov/pull/1/files Webrev: https://webrevs.openjdk.java.net/jcov/1/webrev.00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902535 Stats: 293 lines in 6 files changed: 76 ins; 120 del; 97 mod Patch: https://git.openjdk.java.net/jcov/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/jcov pull/1/head:pull/1 PR: https://git.openjdk.java.net/jcov/pull/1 From lkuskov at openjdk.java.net Wed Jul 15 03:30:54 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 15 Jul 2020 03:30:54 GMT Subject: RFR: 7902697: Switch jcov to the latest asm lib to support latest classfile Message-ID: This is the fix for the issue https://bugs.openjdk.java.net/browse/CODETOOLS-7902697 ------------- Commit messages: - 7902697: Switch jcov to the latest asm lib to support latest classfile Changes: https://git.openjdk.java.net/jcov/pull/2/files Webrev: https://webrevs.openjdk.java.net/jcov/2/webrev.00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902697 Stats: 43 lines in 4 files changed: 24 ins; 0 del; 19 mod Patch: https://git.openjdk.java.net/jcov/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/jcov pull/2/head:pull/2 PR: https://git.openjdk.java.net/jcov/pull/2 From lkuskov at openjdk.java.net Wed Jul 15 03:30:51 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 15 Jul 2020 03:30:51 GMT Subject: Integrated: 7902535: Code coverage does not work in JDK 8 In-Reply-To: <39RDmVMwAzQsybd7F68j_VDT4c5lfz_E7lGu1BfVn-s=.436af705-aa34-4d89-b234-861a0459a3b8@github.com> References: <39RDmVMwAzQsybd7F68j_VDT4c5lfz_E7lGu1BfVn-s=.436af705-aa34-4d89-b234-861a0459a3b8@github.com> Message-ID: <-sHpCB_q1YhK34-lpoqUE9UvYGde__cNWchb27db__I=.2769d74a-28f3-43b3-ad5c-46f5b9df017b@github.com> On Wed, 15 Jul 2020 02:07:20 GMT, Leonid Kuskov wrote: > This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902535 > > In JDK 8 Collect.hit method is called prior to the Collect class initialization. > This causes cyclic throwing NPE. > Also added cosmetic fix to RepGen to avoid double report about internal failures This pull request has now been integrated. Changeset: 8f838be5 Author: Leonid Kuskov URL: https://git.openjdk.java.net/jcov/commit/8f838be5 Stats: 294 lines in 6 files changed: 120 ins; 76 del; 98 mod 7902535: Code coverage does not work in JDK 8 ------------- PR: https://git.openjdk.java.net/jcov/pull/1 From lkuskov at openjdk.java.net Wed Jul 15 03:30:51 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 15 Jul 2020 03:30:51 GMT Subject: RFR: 7902535: Code coverage does not work in JDK 8 [v2] In-Reply-To: <39RDmVMwAzQsybd7F68j_VDT4c5lfz_E7lGu1BfVn-s=.436af705-aa34-4d89-b234-861a0459a3b8@github.com> References: <39RDmVMwAzQsybd7F68j_VDT4c5lfz_E7lGu1BfVn-s=.436af705-aa34-4d89-b234-861a0459a3b8@github.com> Message-ID: > This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902535 > > In JDK 8 Collect.hit method is called prior to the Collect class initialization. > This causes cyclic throwing NPE. > Also added cosmetic fix to RepGen to avoid double report about internal failures Leonid Kuskov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 7902535: Code coverage does not work in JDK 8 ------------- Changes: - all: https://git.openjdk.java.net/jcov/pull/1/files - new: https://git.openjdk.java.net/jcov/pull/1/files/e45c306d..8d7c7261 Webrevs: - full: https://webrevs.openjdk.java.net/jcov/1/webrev.01 - incr: https://webrevs.openjdk.java.net/jcov/1/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jcov/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/jcov pull/1/head:pull/1 PR: https://git.openjdk.java.net/jcov/pull/1 From lkuskov at openjdk.java.net Wed Jul 15 03:36:34 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 15 Jul 2020 03:36:34 GMT Subject: Integrated: 7902697: Switch jcov to the latest asm lib to support latest classfile In-Reply-To: References: Message-ID: On Wed, 15 Jul 2020 03:16:32 GMT, Leonid Kuskov wrote: > This is the fix for the issue https://bugs.openjdk.java.net/browse/CODETOOLS-7902697 This pull request has now been integrated. Changeset: 467b33c4 Author: Leonid Kuskov URL: https://git.openjdk.java.net/jcov/commit/467b33c4 Stats: 43 lines in 4 files changed: 0 ins; 24 del; 19 mod 7902697: Switch jcov to the latest asm lib to support latest classfile ------------- PR: https://git.openjdk.java.net/jcov/pull/2 From lkuskov at openjdk.java.net Fri Jul 17 02:31:25 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Fri, 17 Jul 2020 02:31:25 GMT Subject: RFR: 7902642: Make JCov runtime to only depend on java.base Message-ID: This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902642 The fix removes the usage of the module java.logging for printing messages ------------- Commit messages: - 7902642: Make JCov runtime to only depend on java.base - Merge branch 'CODETOOLS-7902697' - 7902697: Switch jcov to the latest asm lib to support latest classfile - Merge branch 'master' of https://github.com/lkuskov/jcov - 7902535: Code coverage does not work in JDK 8 Changes: https://git.openjdk.java.net/jcov/pull/3/files Webrev: https://webrevs.openjdk.java.net/jcov/3/webrev.00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902642 Stats: 54 lines in 6 files changed: 24 ins; 5 del; 25 mod Patch: https://git.openjdk.java.net/jcov/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/jcov pull/3/head:pull/3 PR: https://git.openjdk.java.net/jcov/pull/3 From lkuskov at openjdk.java.net Fri Jul 17 19:17:38 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Fri, 17 Jul 2020 19:17:38 GMT Subject: Integrated: 7902642: Make JCov runtime to only depend on java.base In-Reply-To: References: Message-ID: <_wL3hNU-6AKW8AGCj6THggrQhFEfwBO-6RUjNgRyjoI=.120b87af-6e9a-42b1-8079-3ff9defc48b3@github.com> On Fri, 17 Jul 2020 02:20:12 GMT, Leonid Kuskov wrote: > This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902642 > The fix removes the usage of the module java.logging for printing messages This pull request has now been integrated. Changeset: 7dbeb40f Author: Leonid Kuskov URL: https://git.openjdk.java.net/jcov/commit/7dbeb40f Stats: 11 lines in 2 files changed: 5 ins; 0 del; 6 mod 7902642: Make JCov runtime to only depend on java.base ------------- PR: https://git.openjdk.java.net/jcov/pull/3 From lkuskov at openjdk.java.net Wed Jul 22 20:33:17 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 22 Jul 2020 20:33:17 GMT Subject: RFR: 7902724: jcov ignores covariant method overriding while gathering a methods' coverages Message-ID: This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902724 It marks both an original and bridge methods as covered jcov marks a bridge method as covered ignoring an original method called by a JCK test. Now it marks both the original and the bridge methods as covered if the bridge method is called like as follows: I.e. if the method "Bar getObject()" is called then "Foo getObject()" is also covered class Foo extends Bar { Foo getObject() { return foo; } synthetic bridge Bar getObject() { return ((Foo) this).getObject(); } } earlier "Foo getObject()" was not taken into account as covered. ------------- Commit messages: - 7902724: jcov ignores covariant method overriding while gathering a methods' coverages - 7902642: Make JCov runtime to only depend on java.base - Merge branch 'CODETOOLS-7902697' - 7902697: Switch jcov to the latest asm lib to support latest classfile - Merge branch 'master' of https://github.com/lkuskov/jcov - 7902535: Code coverage does not work in JDK 8 Changes: https://git.openjdk.java.net/jcov/pull/4/files Webrev: https://webrevs.openjdk.java.net/jcov/4/webrev.00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902724 Stats: 66 lines in 7 files changed: 29 ins; 6 del; 31 mod Patch: https://git.openjdk.java.net/jcov/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/jcov pull/4/head:pull/4 PR: https://git.openjdk.java.net/jcov/pull/4 From lkuskov at openjdk.java.net Fri Jul 24 20:19:38 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Fri, 24 Jul 2020 20:19:38 GMT Subject: Integrated: 7902724: jcov ignores covariant method overriding while gathering a methods' coverages In-Reply-To: References: Message-ID: On Wed, 22 Jul 2020 20:21:52 GMT, Leonid Kuskov wrote: > This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902724 > It marks both original and bridge methods as covered > > jcov marks a bridge method as covered ignoring an original method called by a JCK test. > Now it marks both the original and the bridge methods as covered if the bridge method is called like as follows: > > I.e. if the method "Bar getObject()" is called then "Foo getObject()" is also covered - > class Foo extends Bar { > Foo getObject() { > return foo; > } > > synthetic bridge Bar getObject() { > return ((Foo) this).getObject(); > } > } > earlier "Foo getObject()" was not taken into account as covered. This pull request has now been integrated. Changeset: 4fd8b8e5 Author: Leonid Kuskov URL: https://git.openjdk.java.net/jcov/commit/4fd8b8e5 Stats: 12 lines in 1 file changed: 1 ins; 5 del; 6 mod 7902724: jcov ignores covariant method overriding while gathering a methods' coverages ------------- PR: https://git.openjdk.java.net/jcov/pull/4