RFR: 7903020: Command line error: Incorrect output filename - can't write

Leonid Kuskov lkuskov at openjdk.java.net
Mon Aug 30 18:50:39 UTC 2021


On Mon, 30 Aug 2021 02:20:31 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7903020
>> The fix extends checking of files as existing as non-existing
>
> src/classes/com/sun/tdk/jcov/Merger.java line 1022:
> 
>> 1020: 
>> 1021:         output = opts.getValue(DSC_OUTPUT);
>> 1022:         Utils.checkFileNotNull(output, "output filename",
> 
> It appears that the set of permissions is the same but in a different order.
> It would help if the changset did not contain any formatting changes

OK, I just truncated code lines according to the java code style and changed the order of checking to get more natural list of reasons for failure. Do you need to restore the "old" fashion?

-------------

PR: https://git.openjdk.java.net/jcov/pull/18


More information about the jcov-dev mailing list