From lkuskov at openjdk.org  Fri Aug  5 23:13:06 2022
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 5 Aug 2022 23:13:06 GMT
Subject: RFR: 7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20
Message-ID: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>

This is the fix for https://bugs.openjdk.org/browse/CODETOOLS-7903240

-------------

Commit messages:
 - 7903240: Unable to gather JCov coverage for JCK19 vs OpenJDK19 b22, JDK 20
 - 7903240: Unable to gather JCov coverage for JCK19 vs OpenJDK19 b22, JDK 20

Changes: https://git.openjdk.org/jcov/pull/20/files
 Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=20&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903240
  Stats: 500 lines in 13 files changed: 127 ins; 85 del; 288 mod
  Patch: https://git.openjdk.org/jcov/pull/20.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/20/head:pull/20

PR: https://git.openjdk.org/jcov/pull/20

From shurailine at openjdk.org  Mon Aug  8 19:46:22 2022
From: shurailine at openjdk.org (Alexandre Iline)
Date: Mon, 8 Aug 2022 19:46:22 GMT
Subject: RFR: 7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20
In-Reply-To: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
References: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
Message-ID: <c96VJ78mxlXSCC7u7L-GIr6bm-9RY2a86FEWDIbkTfA=.e032248d-7782-456a-92b0-4730df74cc13@github.com>

On Fri, 5 Aug 2022 22:35:44 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> This is the fix for https://bugs.openjdk.org/browse/CODETOOLS-7903240

src/classes/com/sun/tdk/jcov/runtime/CollectDetect.java line 162:

> 160:     public static void hit(int slot, int hash, int fullHash) {
> 161:         if (isVMReady()) {
> 162:             Thread t = Thread.currentThread();

Perhaps implement an enhancement later to save into on what coverage is lost because of VM not been ready.

-------------

PR: https://git.openjdk.org/jcov/pull/20

From lkuskov at openjdk.org  Tue Aug  9 19:12:57 2022
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 9 Aug 2022 19:12:57 GMT
Subject: RFR: 7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20
 [v2]
In-Reply-To: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
References: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
Message-ID: <J3tMfcOhguc6VVzOTihDCervT06yF-Z7qNz7c1hBnAk=.3c3e7d51-b046-48f9-b448-51c3abada545@github.com>

> This is the fix for https://bugs.openjdk.org/browse/CODETOOLS-7903240

Leonid Kuskov has updated the pull request incrementally with one additional commit since the last revision:

  7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20

-------------

Changes:
  - all: https://git.openjdk.org/jcov/pull/20/files
  - new: https://git.openjdk.org/jcov/pull/20/files/78ebca3e..9249a4f4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jcov&pr=20&range=01
 - incr: https://webrevs.openjdk.org/?repo=jcov&pr=20&range=00-01

  Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jcov/pull/20.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/20/head:pull/20

PR: https://git.openjdk.org/jcov/pull/20

From shurailine at openjdk.org  Tue Aug  9 19:54:50 2022
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 9 Aug 2022 19:54:50 GMT
Subject: RFR: 7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20
 [v2]
In-Reply-To: <J3tMfcOhguc6VVzOTihDCervT06yF-Z7qNz7c1hBnAk=.3c3e7d51-b046-48f9-b448-51c3abada545@github.com>
References: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
 <J3tMfcOhguc6VVzOTihDCervT06yF-Z7qNz7c1hBnAk=.3c3e7d51-b046-48f9-b448-51c3abada545@github.com>
Message-ID: <_i5LNR_ExXQweqMvwBY65brFlu--xLoGIvTVvbNDEcI=.d71dc6b3-082b-469b-b603-6d3a5134af74@github.com>

On Tue, 9 Aug 2022 19:12:57 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

>> This is the fix for https://bugs.openjdk.org/browse/CODETOOLS-7903240
>
> Leonid Kuskov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20

src/classes/com/sun/tdk/jcov/runtime/Collect.java line 55:

> 53:     private static Class<SaverDecorator> extension = null;
> 54: 
> 55:     protected static boolean isVMReady = false;

should it not be volatile?

-------------

PR: https://git.openjdk.org/jcov/pull/20

From shurailine at openjdk.org  Tue Aug  9 20:28:52 2022
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 9 Aug 2022 20:28:52 GMT
Subject: RFR: 7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20
 [v2]
In-Reply-To: <J3tMfcOhguc6VVzOTihDCervT06yF-Z7qNz7c1hBnAk=.3c3e7d51-b046-48f9-b448-51c3abada545@github.com>
References: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
 <J3tMfcOhguc6VVzOTihDCervT06yF-Z7qNz7c1hBnAk=.3c3e7d51-b046-48f9-b448-51c3abada545@github.com>
Message-ID: <0g8ntmGtdA7cpqvNI-_uN5fhi03L7-VicK6PEIYHjKE=.1dba7d89-bbed-4730-863c-d69a642ba655@github.com>

On Tue, 9 Aug 2022 19:12:57 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

>> This is the fix for https://bugs.openjdk.org/browse/CODETOOLS-7903240
>
> Leonid Kuskov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20

Marked as reviewed by shurailine (Committer).

-------------

PR: https://git.openjdk.org/jcov/pull/20

From shurailine at openjdk.org  Tue Aug  9 20:28:52 2022
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 9 Aug 2022 20:28:52 GMT
Subject: RFR: 7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20
 [v2]
In-Reply-To: <_i5LNR_ExXQweqMvwBY65brFlu--xLoGIvTVvbNDEcI=.d71dc6b3-082b-469b-b603-6d3a5134af74@github.com>
References: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
 <J3tMfcOhguc6VVzOTihDCervT06yF-Z7qNz7c1hBnAk=.3c3e7d51-b046-48f9-b448-51c3abada545@github.com>
 <_i5LNR_ExXQweqMvwBY65brFlu--xLoGIvTVvbNDEcI=.d71dc6b3-082b-469b-b603-6d3a5134af74@github.com>
Message-ID: <1EQ9sJEfYMtf7wH_OgRJ8bNeWGsHuFQImdV0qF54FGk=.763bf244-9b4e-44f9-bd56-f037c3b7cb96@github.com>

On Tue, 9 Aug 2022 19:50:47 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> Leonid Kuskov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20
>
> src/classes/com/sun/tdk/jcov/runtime/Collect.java line 55:
> 
>> 53:     private static Class<SaverDecorator> extension = null;
>> 54: 
>> 55:     protected static boolean isVMReady = false;
> 
> should it not be volatile?

As things stand, none of the Collect class is thread safe. So I withdraw my comment with an idea that there could be an enhancement later to make jcov thread safe. Which would be more than just fixing this var.

-------------

PR: https://git.openjdk.org/jcov/pull/20

From duke at openjdk.org  Tue Aug  9 23:48:08 2022
From: duke at openjdk.org (duke)
Date: Tue, 9 Aug 2022 23:48:08 GMT
Subject: git: openjdk/jcov: 7903240: Unable to gather JCov coverage for JCK19
 vs JDK19/20 (#20)
Message-ID: <e37c30a0-92ed-4fd0-b265-aef666b4aed9@openjdk.org>

Changeset: 872982fb
Author:    Leonid Kuskov <lkuskov at openjdk.org>
Committer: GitHub <noreply at github.com>
Date:      2022-08-09 16:47:09 +0000
URL:       https://git.openjdk.org/jcov/commit/872982fbeeee3a473238068db99e0eac22624fba

7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20 (#20)

* 7903240: Unable to gather JCov coverage for JCK19 vs OpenJDK19 b22, JDK 20

* 7903240: Unable to gather JCov coverage for JCK19 vs OpenJDK19 b22, JDK 20

* 7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20

! build/build.xml
! build/filesaver.replace.properties
! build/networksaver.replace.properties
! build/release.properties
! src/classes/com/sun/tdk/jcov/api/ClassDescr.java
! src/classes/com/sun/tdk/jcov/insert/AbstractUniversalInstrumenter.java
! src/classes/com/sun/tdk/jcov/instrument/ClassMorph.java
! src/classes/com/sun/tdk/jcov/instrument/DeferringMethodClassAdapter.java
! src/classes/com/sun/tdk/jcov/instrument/StaticInvokeMethodAdapter.java
! src/classes/com/sun/tdk/jcov/runtime/Collect.java
! src/classes/com/sun/tdk/jcov/runtime/CollectDetect.java
! src/classes/com/sun/tdk/jcov/runtime/PropertyFinder.java
! src/classes/com/sun/tdk/jcov/util/Utils.java


From lkuskov at openjdk.org  Tue Aug  9 23:50:52 2022
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 9 Aug 2022 23:50:52 GMT
Subject: Withdrawn: 7903240: Unable to gather JCov coverage for JCK19 vs
 JDK19/20
In-Reply-To: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
References: <NPC5GgQI96MMPrjvYgaP5jpGTSea3_b2MYo_CoIQaiY=.177d0aaa-f76f-4404-af63-8b33675d16b7@github.com>
Message-ID: <xKOqmtVRaCJWAS2hOtFIfzYhDtyuHbnVzQtRkf2bRAQ=.fac3560e-1be8-4cda-bb7b-d6295c696ef3@github.com>

On Fri, 5 Aug 2022 22:35:44 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> This is the fix for https://bugs.openjdk.org/browse/CODETOOLS-7903240

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jcov/pull/20

From shurailine at openjdk.org  Wed Aug 31 18:28:54 2022
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 31 Aug 2022 18:28:54 GMT
Subject: RFR: CODETOOLS-7903276: Remove references to ASM from reporting code
Message-ID: <2vr37kut8CN1PxYpuzNiF9gPr9AHfsCdY2EXU5n7qGw=.cdbec0e4-556c-4015-8a74-d1023c00e780@github.com>

This is part of the cleanup to allow pluggable instrumentation in JCov.

Once all usages of ASM are within the instrument package, we will have to think of the SPI for the instrumentation plugin.

-------------

Commit messages:
 - CODETOOLS-7903276: Remove references to ASM from reporting code

Changes: https://git.openjdk.org/jcov/pull/21/files
 Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=21&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903276
  Stats: 376 lines in 28 files changed: 214 ins; 30 del; 132 mod
  Patch: https://git.openjdk.org/jcov/pull/21.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/21/head:pull/21

PR: https://git.openjdk.org/jcov/pull/21

From lkuskov at openjdk.org  Wed Aug 31 18:28:55 2022
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Wed, 31 Aug 2022 18:28:55 GMT
Subject: RFR: CODETOOLS-7903276: Remove references to ASM from reporting
 code
In-Reply-To: <2vr37kut8CN1PxYpuzNiF9gPr9AHfsCdY2EXU5n7qGw=.cdbec0e4-556c-4015-8a74-d1023c00e780@github.com>
References: <2vr37kut8CN1PxYpuzNiF9gPr9AHfsCdY2EXU5n7qGw=.cdbec0e4-556c-4015-8a74-d1023c00e780@github.com>
Message-ID: <77Mzn0Vw_tEa3MmbN8bH318ocIEKe9fnJ-SBCLdv47o=.76dc0ff6-ec23-401c-b91f-28126d1640a3@github.com>

On Tue, 30 Aug 2022 23:26:52 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> This is part of the cleanup to allow pluggable instrumentation in JCov.
> 
> Once all usages of ASM are within the instrument package, we will have to think of the SPI for the instrumentation plugin.

Looks good to me. Please add comments to PR body.

-------------

PR: https://git.openjdk.org/jcov/pull/21

From shurailine at openjdk.org  Wed Aug 31 18:32:38 2022
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 31 Aug 2022 18:32:38 GMT
Subject: Integrated: CODETOOLS-7903276: Remove references to ASM from reporting
 code
In-Reply-To: <2vr37kut8CN1PxYpuzNiF9gPr9AHfsCdY2EXU5n7qGw=.cdbec0e4-556c-4015-8a74-d1023c00e780@github.com>
References: <2vr37kut8CN1PxYpuzNiF9gPr9AHfsCdY2EXU5n7qGw=.cdbec0e4-556c-4015-8a74-d1023c00e780@github.com>
Message-ID: <95NuAdLFHv3zu0uBzy5mFyGrqGwb7K3sQxvVcqR7cnA=.8601a7da-0ad1-43cb-acfc-e61d41178947@github.com>

On Tue, 30 Aug 2022 23:26:52 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> This is part of the cleanup to allow pluggable instrumentation in JCov.
> 
> Once all usages of ASM are within the instrument package, we will have to think of the SPI for the instrumentation plugin.

This pull request has now been integrated.

Changeset: 171c695b
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/171c695bf2efcd931fe3de53396028cd825c08e3
Stats:     376 lines in 28 files changed: 214 ins; 30 del; 132 mod

7903276: Remove references to ASM from reporting code

-------------

PR: https://git.openjdk.org/jcov/pull/21