RFR: 7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20 [v2]

Alexandre Iline shurailine at openjdk.org
Tue Aug 9 20:28:52 UTC 2022


On Tue, 9 Aug 2022 19:50:47 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> Leonid Kuskov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   7903240: Unable to gather JCov coverage for JCK19 vs JDK19/20
>
> src/classes/com/sun/tdk/jcov/runtime/Collect.java line 55:
> 
>> 53:     private static Class<SaverDecorator> extension = null;
>> 54: 
>> 55:     protected static boolean isVMReady = false;
> 
> should it not be volatile?

As things stand, none of the Collect class is thread safe. So I withdraw my comment with an idea that there could be an enhancement later to make jcov thread safe. Which would be more than just fixing this var.

-------------

PR: https://git.openjdk.org/jcov/pull/20


More information about the jcov-dev mailing list