RFR: CODETOOLS-7903277: Remove references to ASM from JREInstr
Leonid Kuskov
lkuskov at openjdk.org
Wed Sep 7 19:18:54 UTC 2022
On Wed, 7 Sep 2022 02:16:46 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:
> Moving ASM dependencies into the instrument package.
> * There is currently a kind of SPI represented by AbstractUniversalInstrumenter. Whether to keep it or to replace it with something else is a subject for further considerations.
> * Relationship between JREInstr and Instrumentation are not implemented clearly. Addition of fixJavaBase field is yet another hack on top of existing code. This is one of the ways to move forward. The whole JREInstr will need to be refactored anyway with the introduction of ASM agnostic SPI, hence the temporary hack.
> * Should the flag be set in the instrumentation, Instr class now does the work on java.base module. It is also a question for further consideration if other modules are allowed to be modified and what SPI or API would control that.
> * Bunch of JREInstr code commented out as no longer supported since the module system introduction.
> * Module file instrumentation moved to ClassMorph for now. Pending further SPI design.
> * A unit test for JREInstr.
> * Rest of the tests are passing.
plugins/data_coverage/test/openjdk/jcov/data/arguments/jreinstr/filepermission/Test.java line 56:
> 54: Files.deleteIfExists(template);
> 55: String runtime = Arrays.stream(System.getProperty("java.class.path").split(File.pathSeparator))
> 56: .peek(System.out::println)
Do we need to print these class paths? It seems line 56 is superfluous.
-------------
PR: https://git.openjdk.org/jcov/pull/22
More information about the jcov-dev
mailing list