RFR: CODETOOLS-7903277: Remove references to ASM from JREInstr [v2]

Alexandre Iline shurailine at openjdk.org
Wed Sep 7 21:53:56 UTC 2022


> Moving ASM dependencies into the instrument package.
>  * There is currently a kind of SPI represented by AbstractUniversalInstrumenter. Whether to keep it or to replace it with something else is a subject for further considerations.
>  * Relationship between JREInstr and Instrumentation are not implemented clearly. Addition of fixJavaBase field is yet another hack on top of existing code. This is one of the ways to move forward. The whole JREInstr will need to be refactored anyway with the introduction of ASM agnostic SPI, hence the temporary hack.
>  * Should the flag be set in the instrumentation, Instr class now does the work on java.base module. It is also a question for further consideration if other modules are allowed to be modified and what SPI or API would control that.
>  * Bunch of JREInstr code commented out as no longer supported since the module system introduction.
>  * Module file instrumentation moved to ClassMorph for now. Pending further SPI design.
>  * A unit test for JREInstr.
>  * Rest of the tests are passing.

Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:

  Addressing feedback:
  a setter method
  removed debug comment

-------------

Changes:
  - all: https://git.openjdk.org/jcov/pull/22/files
  - new: https://git.openjdk.org/jcov/pull/22/files/6d82a14f..d8920fd2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jcov&pr=22&range=01
 - incr: https://webrevs.openjdk.org/?repo=jcov&pr=22&range=00-01

  Stats: 16 lines in 3 files changed: 5 ins; 8 del; 3 mod
  Patch: https://git.openjdk.org/jcov/pull/22.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/22/head:pull/22

PR: https://git.openjdk.org/jcov/pull/22


More information about the jcov-dev mailing list