From jvanek at openjdk.org  Tue Aug 22 18:07:17 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 22 Aug 2023 18:07:17 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies and
 javatest
Message-ID: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>

jcov now:
 - downloads all necessary dependences, unless present
 - is setting up versions of testng and jcommander
 - is not setting version of javatest, simply gets latest tagged binary
 - gitignores build/template.xml

-------------

Commit messages:
 - 7903520 - jcov is missing versions of testing dependencies and javatest

Changes: https://git.openjdk.org/jcov/pull/40/files
 Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=40&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903520
  Stats: 34 lines in 4 files changed: 20 ins; 4 del; 10 mod
  Patch: https://git.openjdk.org/jcov/pull/40.diff
  Fetch: git fetch https://git.openjdk.org/jcov.git pull/40/head:pull/40

PR: https://git.openjdk.org/jcov/pull/40

From jvanek at openjdk.org  Tue Aug 22 18:08:17 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 22 Aug 2023 18:08:17 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <P1LhChWxEFn8Y7nXVKwAkbVabW5DXzRidExPkQcfa5c=.fea8efad-3720-414d-abf1-dd00ce2bd2a6@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

Note, that I had guessed dependece versions fromcodebase and dates of theirs commits.
And they may not be exactly correct, as the tests are now failing:

...
   [testng] /usr/lib/jvm/java-17-openjdk-17.0.7.0.7-5.fc38.x86_64/bin/java -Djcov.data-saver=com.sun.tdk.jcov.instrument.plugin.FieldsPlugin -cp /home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/build/plugin_test:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/build/testng-6.9.10.jar:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/JCOV_BUILD/jcov_3.0/jcov.jar:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/JCOV_BUILD/jcov_3.0/jcov_network_saver.jar:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/JCOV_BUILD/test/classes:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/build/jcommander-1.82.jar com.sun.tdk.jcov.instrument.plugin.FieldsClass
   [testng] Comparing [1,2] with [1,2]
   [testng] Comparing [,one,two] with [,one,two]
   [testng] Removing /home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/build/instr_test
   [testng] Removing /tmp/JDK2364619257894783822
   [testng] Removing /tmp/JDK1946716064096195714
   [testng] Removing user_code
   [testng] PASSED: testInstantiate
   [testng] PASSED: testInstantiateAll
   [testng] PASSED: instrument
   [testng] PASSED: testNested
   [testng] PASSED: testNormal
   [testng] PASSED: testNotRead([Ljava.lang.String;@14a2f921)
   [testng] PASSED: testNotRead([Ljava.lang.String;@2aece37d)
   [testng] PASSED: testNotRead([Ljava.lang.String;@5762806e)
   [testng] PASSED: testNotRead(null)
   [testng] PASSED: testRead([Ljava.lang.String;@5ef60048, "data0", [[Ljava.lang.String;@1d548a08)
   [testng] PASSED: testRead([Ljava.lang.String;@780cb77, "data1", [[Ljava.lang.String;@691a7f8f)
   [testng] PASSED: testRead([Ljava.lang.String;@161b062a, "data2", [[Ljava.lang.String;@17c1bced)
   [testng] PASSED: testRead([Ljava.lang.String;@4034c28c, "data3", [[Ljava.lang.String;@e50a6f6)
   [testng] PASSED: testReasonUninitiated
   [testng] PASSED: testUninitiated
   [testng] PASSED: load
   [testng] PASSED: load
   [testng] PASSED: testNestHostMembers
   [testng] PASSED: fields
   [testng] PASSED: testSaver
   [testng] PASSED: transform
   [testng] PASSED: transform
   [testng] FAILED: instrument
   [testng] java.lang.AssertionError
   [testng] 	at com.sun.tdk.jcov.instrument.asm.BranchCodeMethodAdapter.computeEndBCIsAndFoldInExits(BranchCodeMethodAdapter.java:450)
   [testng] 	at com.sun.tdk.jcov.instrument.asm.BranchCodeMethodAdapter.visitEnd(BranchCodeMethodAdapter.java:524)
   [testng] 	at org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:783)
   [testng] 	at org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:783)
   [testng] 	at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1495)
   [testng] 	at org.objectweb.asm.ClassReader.accept(ClassReader.java:721)
   [testng] 	at com.sun.tdk.jcov.instrument.asm.ClassMorph.morph(ClassMorph.java:275)
   [testng] 	at com.sun.tdk.jcov.Instr$1.instrument(Instr.java:303)
   [testng] 	at com.sun.tdk.jcov.insert.AbstractUniversalInstrumenter.processClassFile(AbstractUniversalInstrumenter.java:186)
   [testng] 	at com.sun.tdk.jcov.insert.AbstractUniversalInstrumenter.instrument(AbstractUniversalInstrumenter.java:620)
   [testng] 	at com.sun.tdk.jcov.insert.AbstractUniversalInstrumenter.instrument(AbstractUniversalInstrumenter.java:546)
   [testng] 	at com.sun.tdk.jcov.Instr.instrumentFiles(Instr.java:241)
   [testng] 	at com.sun.tdk.jcov.Instr.run(Instr.java:576)
   [testng] 	at com.sun.tdk.jcov.tools.JCovCMDTool.run(JCovCMDTool.java:164)
   [testng] 	at com.sun.tdk.jcov.instrument.instr.InstrTest.instrument(Unknown Source)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
   [testng] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [testng] 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
   [testng] 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:86)
   [testng] 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:643)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:820)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1128)
   [testng] 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   [testng] 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
   [testng] 	at org.testng.TestRunner.privateRun(TestRunner.java:782)
   [testng] 	at org.testng.TestRunner.run(TestRunner.java:632)
   [testng] 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:366)
   [testng] 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:361)
   [testng] 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:319)
   [testng] 	at org.testng.SuiteRunner.run(SuiteRunner.java:268)
   [testng] 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   [testng] 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   [testng] 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1244)
   [testng] 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
   [testng] 	at org.testng.TestNG.run(TestNG.java:1064)
   [testng] 	at org.testng.TestNG.privateMain(TestNG.java:1385)
   [testng] 	at org.testng.TestNG.main(TestNG.java:1354)
   [testng] 
   [testng] FAILED: testJREInstr
   [testng] java.util.NoSuchElementException: No value present
   [testng] 	at java.base/java.util.Optional.get(Optional.java:143)
   [testng] 	at com.sun.tdk.jcov.instrument.jreinstr.JREInstrTest.testJREInstr(Unknown Source)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
   [testng] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [testng] 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
   [testng] 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:86)
   [testng] 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:643)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:820)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1128)
   [testng] 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   [testng] 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
   [testng] 	at org.testng.TestRunner.privateRun(TestRunner.java:782)
   [testng] 	at org.testng.TestRunner.run(TestRunner.java:632)
   [testng] 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:366)
   [testng] 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:361)
   [testng] 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:319)
   [testng] 	at org.testng.SuiteRunner.run(SuiteRunner.java:268)
   [testng] 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   [testng] 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   [testng] 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1244)
   [testng] 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
   [testng] 	at org.testng.TestNG.run(TestNG.java:1064)
   [testng] 	at org.testng.TestNG.privateMain(TestNG.java:1385)
   [testng] 	at org.testng.TestNG.main(TestNG.java:1354)
   [testng] 
   [testng] FAILED: testJREInstr
   [testng] java.lang.AssertionError: expected [0] but found [1]
   [testng] 	at org.testng.Assert.fail(Assert.java:94)
   [testng] 	at org.testng.Assert.failNotEquals(Assert.java:513)
   [testng] 	at org.testng.Assert.assertEqualsImpl(Assert.java:135)
   [testng] 	at org.testng.Assert.assertEquals(Assert.java:116)
   [testng] 	at org.testng.Assert.assertEquals(Assert.java:389)
   [testng] 	at org.testng.Assert.assertEquals(Assert.java:399)
   [testng] 	at com.sun.tdk.jcov.instrument.plugin.jreinstr.JREInstrTest.testJREInstr(Unknown Source)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
   [testng] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [testng] 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
   [testng] 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:86)
   [testng] 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:643)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:820)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1128)
   [testng] 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   [testng] 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
   [testng] 	at org.testng.TestRunner.privateRun(TestRunner.java:782)
   [testng] 	at org.testng.TestRunner.run(TestRunner.java:632)
   [testng] 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:366)
   [testng] 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:361)
   [testng] 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:319)
   [testng] 	at org.testng.SuiteRunner.run(SuiteRunner.java:268)
   [testng] 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   [testng] 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   [testng] 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1244)
   [testng] 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
   [testng] 	at org.testng.TestNG.run(TestNG.java:1064)
   [testng] 	at org.testng.TestNG.privateMain(TestNG.java:1385)
   [testng] 	at org.testng.TestNG.main(TestNG.java:1354)
   [testng] 
   [testng] SKIPPED: run
   [testng] java.lang.Throwable: Method InstrTest.run()[pri:0, instance:com.sun.tdk.jcov.instrument.instr.InstrTest at 6500df86] depends on not successfully finished methods
   [testng] 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1037)
   [testng] 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   [testng] 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
 ...
   [testng] 	at org.testng.TestRunner.run(TestRunner.java:632)
   [testng] 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:366)
   [testng] 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:361)
   [testng] 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:319)
   [testng] 	at org.testng.SuiteRunner.run(SuiteRunner.java:268)
   [testng] 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   [testng] 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   [testng] 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1244)
   [testng] 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
   [testng] 	at org.testng.TestNG.run(TestNG.java:1064)
   [testng] 	at org.testng.TestNG.privateMain(TestNG.java:1385)
   [testng] 	at org.testng.TestNG.main(TestNG.java:1354)
   [testng] 
   [testng] 
   [testng] ===============================================
   [testng]     TestNG tests
   [testng]     Tests run: 29, Failures: 3, Skips: 4
   [testng] ===============================================
   [testng] 
   [testng] 
   [testng] ===============================================
   [testng] jcov
   [testng] Total tests run: 29, Failures: 3, Skips: 4
   [testng] ===============================================
   [testng] 
   [testng] [TestNG] Time taken by org.testng.reporters.JUnitReportReporter at 2eafffde: 15 ms
   [testng] [TestNG] Time taken by [FailedReporter passed=0 failed=0 skipped=0]: 8 ms
   [testng] [TestNG] Time taken by org.testng.reporters.XMLReporter at 8807e25: 17 ms
   [testng] [TestNG] Time taken by org.testng.reporters.EmailableReporter2 at 3419866c: 12 ms
   [testng] [TestNG] Time taken by org.testng.reporters.SuiteHTMLReporter at 4f47d241: 12 ms
   [testng] [TestNG] Time taken by org.testng.reporters.jq.Main at 27ddd392: 25 ms
   [testng] The tests failed.

BUILD SUCCESSFUL
Total time: 5 seconds

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1688656666

From lkuskov at openjdk.org  Wed Aug 23 19:49:39 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Wed, 23 Aug 2023 19:49:39 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <9VFgfP8RWlb691fzL6rN6Z3H9mHUAiT3NV8I-DgNsCQ=.72a0a53c-b2ac-47f0-a38b-6e01a312ccb1@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

LGTM. Since the test target is part of the development stage, it's okay to add a dependency on external trusted resources.

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1690542320

From jvanek at openjdk.org  Wed Aug 23 21:47:42 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 23 Aug 2023 21:47:42 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <za0tfdBxPy4bcgZj5B5Z-0n8YD7V-nblZepdHwJeka8=.08e835a3-3eb0-405c-8bd9-469b2a5340cb@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

Thanx! Are you ok with the versions used. despite the test failures?

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1690687064

From lkuskov at openjdk.org  Wed Aug 23 23:50:44 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Wed, 23 Aug 2023 23:50:44 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <0ugXGENpZDPls-EdXoyFQpGQwM6VcLFYFygjH7ag3kM=.39103243-1952-48c8-84e9-9baeb56dd7c0@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

IMO, in this case, failing tests are the subject to analyze tests, implementation, and fix what is necessary. This change doesn't affect jcov at all.

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1690785033

From jvanek at openjdk.org  Thu Aug 24 04:57:43 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Thu, 24 Aug 2023 04:57:43 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <9529bnxsgqg9boQw41fhcZcsiqXRSYlFz_MiPnheAlU=.05850246-a2ba-4ac1-9e12-26e28d4a6e5f@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

You are most likely right. Still with various versions of testng and of jcommander, it was failing in various ways. 

Those failed tests  seems to come from https://github.com/openjdk/jcov/commit/8deab262fdd5087b159e1286de5749dfe5318cac ,  so maybe @shurymury  may confirm?

Bu if you are ok with this as it is, the versions may fixed later.

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1690999894
PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1691000538

From jvanek at openjdk.org  Fri Aug 25 13:23:34 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 25 Aug 2023 13:23:34 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <x2qYq7qSTiQwGXeJWThl332r8-_1za3erXoPMMcoHAA=.3d5b5661-16dd-416f-83ef-7bbcb0e1d3c7@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

Note, that I'm not an commiter, feel free to merge on my behalf

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1693353801

From duke at openjdk.org  Fri Aug 25 16:01:46 2023
From: duke at openjdk.org (duke)
Date: Fri, 25 Aug 2023 16:01:46 GMT
Subject: git: openjdk/jcov: 7903520 - jcov is missing versions of testing
 dependencies and javatest (#40)
Message-ID: <f6287e58-9327-4258-bae3-56a0891cee86@openjdk.org>

Changeset: ce686b19
Author:    judovana <judovana at email.cz>
Committer: GitHub <noreply at github.com>
Date:      2023-08-25 18:00:56 +0000
URL:       https://git.openjdk.org/jcov/commit/ce686b19c5ae0f3937f7622ee0e5ae50ea32da30

7903520 - jcov is missing versions of testing dependencies and javatest (#40)

jcov now:
 - downloads all necessary dependences, unless present
 - is setting up versions of testng and jcommander
 - is not setting version of javatest, simply gets latest tagged binary
 - gitignores build/template.xml

! .gitignore
! build/build.properties
! build/build.xml
! build/check-dependecies.xml


From lkuskov at openjdk.org  Fri Aug 25 16:03:38 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 25 Aug 2023 16:03:38 GMT
Subject: Withdrawn: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <qKTjGi7yNVlD-iLWdeGgzSyomAkv8mZP9UfGyOElB1k=.9fbae0c8-5d07-4fda-b688-b2d8cb94fec6@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jcov/pull/40

From lkuskov at openjdk.org  Fri Aug 25 23:28:27 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 25 Aug 2023 23:28:27 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <tVaMczfUsjgfUmflJ2tQywh1AECwbKmPF2jCS85dnLo=.a2d8239c-b3fb-487f-89c7-4005b709d298@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

the commit is integrated.

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1694028795

From jvanek at openjdk.org  Mon Aug 28 12:05:34 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Mon, 28 Aug 2023 12:05:34 GMT
Subject: RFR: 7903520 - jcov is missing versions of testing dependencies
 and javatest
In-Reply-To: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
References: <ysfUmzm3pSiaMPXpcoo_gMKqMcEpY1jLQozNumFn-Uw=.d65288dd-08da-4881-8a0b-67f40d812014@github.com>
Message-ID: <eE1kEy2ExLI7E4bbuONlz01zP31KOhvXc9h3P6DI1Do=.c5e0fec7-79db-4ad2-bf45-f826b15cf266@github.com>

On Tue, 22 Aug 2023 17:51:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

tyvm!

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1695574190

From shurailine at openjdk.org  Tue Aug 29 23:15:41 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 29 Aug 2023 23:15:41 GMT
Subject: RFR: Reports plugin
Message-ID: <k9O4q4F34JAEqCqSLD4WQP7z-FtB5KWEdlQpunlCKWg=.b9ec3583-158d-4def-9720-1510dbbaf384@github.com>

An initial code for the report plugin.

-------------

Commit messages:
 - README
 - make context lighter
 - The report shoudl really be showing _source_ coverage, not class coverage.
 - remove pres
 - Allow anything in header.
 - Results from the same line ovverride previous results
 - add header and title to the report
 - Initial commit of a report building plugin.

Changes: https://git.openjdk.org/jcov/pull/41/files
 Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=41&range=00
  Stats: 12373 lines in 35 files changed: 12371 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jcov/pull/41.diff
  Fetch: git fetch https://git.openjdk.org/jcov.git pull/41/head:pull/41

PR: https://git.openjdk.org/jcov/pull/41

From shurailine at openjdk.org  Wed Aug 30 02:38:01 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 30 Aug 2023 02:38:01 GMT
Subject: RFR: Reports plugin [v2]
In-Reply-To: <k9O4q4F34JAEqCqSLD4WQP7z-FtB5KWEdlQpunlCKWg=.b9ec3583-158d-4def-9720-1510dbbaf384@github.com>
References: <k9O4q4F34JAEqCqSLD4WQP7z-FtB5KWEdlQpunlCKWg=.b9ec3583-158d-4def-9720-1510dbbaf384@github.com>
Message-ID: <WyLZNCt8Wql7VSJd54pAjGkeyz2rLTbzQW4QD4Nn74E=.2c09ec47-50f4-4102-897c-5ddf0752c668@github.com>

> An initial code for the report plugin.

Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:

  A constant for separator line.

-------------

Changes:
  - all: https://git.openjdk.org/jcov/pull/41/files
  - new: https://git.openjdk.org/jcov/pull/41/files/5147aeac..6b5de03c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jcov&pr=41&range=01
 - incr: https://webrevs.openjdk.org/?repo=jcov&pr=41&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jcov/pull/41.diff
  Fetch: git fetch https://git.openjdk.org/jcov.git pull/41/head:pull/41

PR: https://git.openjdk.org/jcov/pull/41

From lkuskov at openjdk.org  Thu Aug 31 19:28:21 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Thu, 31 Aug 2023 19:28:21 GMT
Subject: RFR: Reports plugin [v2]
In-Reply-To: <WyLZNCt8Wql7VSJd54pAjGkeyz2rLTbzQW4QD4Nn74E=.2c09ec47-50f4-4102-897c-5ddf0752c668@github.com>
References: <k9O4q4F34JAEqCqSLD4WQP7z-FtB5KWEdlQpunlCKWg=.b9ec3583-158d-4def-9720-1510dbbaf384@github.com>
 <WyLZNCt8Wql7VSJd54pAjGkeyz2rLTbzQW4QD4Nn74E=.2c09ec47-50f4-4102-897c-5ddf0752c668@github.com>
Message-ID: <-h_ZJbzBoIfQiOb36qjJqbLchxBLf3pO_CCdDKW81dc=.d1e92c82-b871-4f35-99da-2a92a8fd025b@github.com>

On Wed, 30 Aug 2023 02:38:01 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> An initial code for the report plugin.
>
> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
> 
>   A constant for separator line.

LGTM

-------------

PR Comment: https://git.openjdk.org/jcov/pull/41#issuecomment-1701662303

From shurailine at openjdk.org  Thu Aug 31 20:29:21 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Thu, 31 Aug 2023 20:29:21 GMT
Subject: Integrated: Reports plugin
In-Reply-To: <k9O4q4F34JAEqCqSLD4WQP7z-FtB5KWEdlQpunlCKWg=.b9ec3583-158d-4def-9720-1510dbbaf384@github.com>
References: <k9O4q4F34JAEqCqSLD4WQP7z-FtB5KWEdlQpunlCKWg=.b9ec3583-158d-4def-9720-1510dbbaf384@github.com>
Message-ID: <zlPw2x1WeD2QWlfIVBr7vR3ybou4btTCqVBbrXrvvTY=.320a935a-c1c4-49ec-a04e-400edd83fec2@github.com>

On Tue, 29 Aug 2023 23:08:30 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> An initial code for the report plugin.

This pull request has now been integrated.

Changeset: 2b68120d
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/2b68120d627caac5343549a8b04f436e8ce03f1e
Stats:     12373 lines in 35 files changed: 12371 ins; 0 del; 2 mod

Reports plugin

-------------

PR: https://git.openjdk.org/jcov/pull/41