RFR: 7903520 - jcov is missing versions of testing dependencies and javatest

Jiří Vaněk jvanek at openjdk.org
Tue Aug 22 18:08:17 UTC 2023 

On Tue, 22 Aug 2023 17:51:03 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

> jcov now:
>  - downloads all necessary dependences, unless present
>  - is setting up versions of testng and jcommander
>  - is not setting version of javatest, simply gets latest tagged binary
>  - gitignores build/template.xml

Note, that I had guessed dependece versions fromcodebase and dates of theirs commits.
And they may not be exactly correct, as the tests are now failing:

...
   [testng] /usr/lib/jvm/java-17-openjdk-17.0.7.0.7-5.fc38.x86_64/bin/java -Djcov.data-saver=com.sun.tdk.jcov.instrument.plugin.FieldsPlugin -cp /home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/build/plugin_test:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/build/testng-6.9.10.jar:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/JCOV_BUILD/jcov_3.0/jcov.jar:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/JCOV_BUILD/jcov_3.0/jcov_network_saver.jar:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/JCOV_BUILD/test/classes:/home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/build/jcommander-1.82.jar com.sun.tdk.jcov.instrument.plugin.FieldsClass
   [testng] Comparing [1,2] with [1,2]
   [testng] Comparing [,one,two] with [,one,two]
   [testng] Removing /home/jvanek/git/ci-jenkins-pipelines/tools/code-tools/jcov/build/instr_test
   [testng] Removing /tmp/JDK2364619257894783822
   [testng] Removing /tmp/JDK1946716064096195714
   [testng] Removing user_code
   [testng] PASSED: testInstantiate
   [testng] PASSED: testInstantiateAll
   [testng] PASSED: instrument
   [testng] PASSED: testNested
   [testng] PASSED: testNormal
   [testng] PASSED: testNotRead([Ljava.lang.String;@14a2f921)
   [testng] PASSED: testNotRead([Ljava.lang.String;@2aece37d)
   [testng] PASSED: testNotRead([Ljava.lang.String;@5762806e)
   [testng] PASSED: testNotRead(null)
   [testng] PASSED: testRead([Ljava.lang.String;@5ef60048, "data0", [[Ljava.lang.String;@1d548a08)
   [testng] PASSED: testRead([Ljava.lang.String;@780cb77, "data1", [[Ljava.lang.String;@691a7f8f)
   [testng] PASSED: testRead([Ljava.lang.String;@161b062a, "data2", [[Ljava.lang.String;@17c1bced)
   [testng] PASSED: testRead([Ljava.lang.String;@4034c28c, "data3", [[Ljava.lang.String;@e50a6f6)
   [testng] PASSED: testReasonUninitiated
   [testng] PASSED: testUninitiated
   [testng] PASSED: load
   [testng] PASSED: load
   [testng] PASSED: testNestHostMembers
   [testng] PASSED: fields
   [testng] PASSED: testSaver
   [testng] PASSED: transform
   [testng] PASSED: transform
   [testng] FAILED: instrument
   [testng] java.lang.AssertionError
   [testng] 	at com.sun.tdk.jcov.instrument.asm.BranchCodeMethodAdapter.computeEndBCIsAndFoldInExits(BranchCodeMethodAdapter.java:450)
   [testng] 	at com.sun.tdk.jcov.instrument.asm.BranchCodeMethodAdapter.visitEnd(BranchCodeMethodAdapter.java:524)
   [testng] 	at org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:783)
   [testng] 	at org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:783)
   [testng] 	at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1495)
   [testng] 	at org.objectweb.asm.ClassReader.accept(ClassReader.java:721)
   [testng] 	at com.sun.tdk.jcov.instrument.asm.ClassMorph.morph(ClassMorph.java:275)
   [testng] 	at com.sun.tdk.jcov.Instr$1.instrument(Instr.java:303)
   [testng] 	at com.sun.tdk.jcov.insert.AbstractUniversalInstrumenter.processClassFile(AbstractUniversalInstrumenter.java:186)
   [testng] 	at com.sun.tdk.jcov.insert.AbstractUniversalInstrumenter.instrument(AbstractUniversalInstrumenter.java:620)
   [testng] 	at com.sun.tdk.jcov.insert.AbstractUniversalInstrumenter.instrument(AbstractUniversalInstrumenter.java:546)
   [testng] 	at com.sun.tdk.jcov.Instr.instrumentFiles(Instr.java:241)
   [testng] 	at com.sun.tdk.jcov.Instr.run(Instr.java:576)
   [testng] 	at com.sun.tdk.jcov.tools.JCovCMDTool.run(JCovCMDTool.java:164)
   [testng] 	at com.sun.tdk.jcov.instrument.instr.InstrTest.instrument(Unknown Source)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
   [testng] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [testng] 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
   [testng] 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:86)
   [testng] 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:643)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:820)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1128)
   [testng] 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   [testng] 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
   [testng] 	at org.testng.TestRunner.privateRun(TestRunner.java:782)
   [testng] 	at org.testng.TestRunner.run(TestRunner.java:632)
   [testng] 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:366)
   [testng] 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:361)
   [testng] 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:319)
   [testng] 	at org.testng.SuiteRunner.run(SuiteRunner.java:268)
   [testng] 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   [testng] 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   [testng] 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1244)
   [testng] 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
   [testng] 	at org.testng.TestNG.run(TestNG.java:1064)
   [testng] 	at org.testng.TestNG.privateMain(TestNG.java:1385)
   [testng] 	at org.testng.TestNG.main(TestNG.java:1354)
   [testng] 
   [testng] FAILED: testJREInstr
   [testng] java.util.NoSuchElementException: No value present
   [testng] 	at java.base/java.util.Optional.get(Optional.java:143)
   [testng] 	at com.sun.tdk.jcov.instrument.jreinstr.JREInstrTest.testJREInstr(Unknown Source)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
   [testng] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [testng] 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
   [testng] 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:86)
   [testng] 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:643)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:820)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1128)
   [testng] 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   [testng] 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
   [testng] 	at org.testng.TestRunner.privateRun(TestRunner.java:782)
   [testng] 	at org.testng.TestRunner.run(TestRunner.java:632)
   [testng] 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:366)
   [testng] 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:361)
   [testng] 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:319)
   [testng] 	at org.testng.SuiteRunner.run(SuiteRunner.java:268)
   [testng] 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   [testng] 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   [testng] 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1244)
   [testng] 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
   [testng] 	at org.testng.TestNG.run(TestNG.java:1064)
   [testng] 	at org.testng.TestNG.privateMain(TestNG.java:1385)
   [testng] 	at org.testng.TestNG.main(TestNG.java:1354)
   [testng] 
   [testng] FAILED: testJREInstr
   [testng] java.lang.AssertionError: expected [0] but found [1]
   [testng] 	at org.testng.Assert.fail(Assert.java:94)
   [testng] 	at org.testng.Assert.failNotEquals(Assert.java:513)
   [testng] 	at org.testng.Assert.assertEqualsImpl(Assert.java:135)
   [testng] 	at org.testng.Assert.assertEquals(Assert.java:116)
   [testng] 	at org.testng.Assert.assertEquals(Assert.java:389)
   [testng] 	at org.testng.Assert.assertEquals(Assert.java:399)
   [testng] 	at com.sun.tdk.jcov.instrument.plugin.jreinstr.JREInstrTest.testJREInstr(Unknown Source)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   [testng] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
   [testng] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [testng] 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
   [testng] 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:86)
   [testng] 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:643)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:820)
   [testng] 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1128)
   [testng] 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   [testng] 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
   [testng] 	at org.testng.TestRunner.privateRun(TestRunner.java:782)
   [testng] 	at org.testng.TestRunner.run(TestRunner.java:632)
   [testng] 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:366)
   [testng] 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:361)
   [testng] 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:319)
   [testng] 	at org.testng.SuiteRunner.run(SuiteRunner.java:268)
   [testng] 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   [testng] 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   [testng] 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1244)
   [testng] 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
   [testng] 	at org.testng.TestNG.run(TestNG.java:1064)
   [testng] 	at org.testng.TestNG.privateMain(TestNG.java:1385)
   [testng] 	at org.testng.TestNG.main(TestNG.java:1354)
   [testng] 
   [testng] SKIPPED: run
   [testng] java.lang.Throwable: Method InstrTest.run()[pri:0, instance:com.sun.tdk.jcov.instrument.instr.InstrTest at 6500df86] depends on not successfully finished methods
   [testng] 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1037)
   [testng] 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   [testng] 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
 ...
   [testng] 	at org.testng.TestRunner.run(TestRunner.java:632)
   [testng] 	at org.testng.SuiteRunner.runTest(SuiteRunner.java:366)
   [testng] 	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:361)
   [testng] 	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:319)
   [testng] 	at org.testng.SuiteRunner.run(SuiteRunner.java:268)
   [testng] 	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   [testng] 	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   [testng] 	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1244)
   [testng] 	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
   [testng] 	at org.testng.TestNG.run(TestNG.java:1064)
   [testng] 	at org.testng.TestNG.privateMain(TestNG.java:1385)
   [testng] 	at org.testng.TestNG.main(TestNG.java:1354)
   [testng] 
   [testng] 
   [testng] ===============================================
   [testng]     TestNG tests
   [testng]     Tests run: 29, Failures: 3, Skips: 4
   [testng] ===============================================
   [testng] 
   [testng] 
   [testng] ===============================================
   [testng] jcov
   [testng] Total tests run: 29, Failures: 3, Skips: 4
   [testng] ===============================================
   [testng] 
   [testng] [TestNG] Time taken by org.testng.reporters.JUnitReportReporter at 2eafffde: 15 ms
   [testng] [TestNG] Time taken by [FailedReporter passed=0 failed=0 skipped=0]: 8 ms
   [testng] [TestNG] Time taken by org.testng.reporters.XMLReporter at 8807e25: 17 ms
   [testng] [TestNG] Time taken by org.testng.reporters.EmailableReporter2 at 3419866c: 12 ms
   [testng] [TestNG] Time taken by org.testng.reporters.SuiteHTMLReporter at 4f47d241: 12 ms
   [testng] [TestNG] Time taken by org.testng.reporters.jq.Main at 27ddd392: 25 ms
   [testng] The tests failed.

BUILD SUCCESSFUL
Total time: 5 seconds

-------------

PR Comment: https://git.openjdk.org/jcov/pull/40#issuecomment-1688656666

More information about the jcov-dev mailing list