From shurailine at openjdk.org  Tue Jan  3 19:26:50 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 3 Jan 2023 19:26:50 GMT
Subject: RFR: Separate ASM-dependent code into a separate source tree.
Message-ID: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>

Separate ASM-dependent code into a separate source tree.
Introduce modules.
Changes in test infrastructure and more tests pending.
Build is so far kept compatible with the previous version, only adding creation of two jmods.

-------------

Commit messages:
 - Saparate ASM into a separate source tree.

Changes: https://git.openjdk.org/jcov/pull/35/files
 Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=35&range=00
  Stats: 1169 lines in 57 files changed: 550 ins; 580 del; 39 mod
  Patch: https://git.openjdk.org/jcov/pull/35.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/35/head:pull/35

PR: https://git.openjdk.org/jcov/pull/35

From lkuskov at openjdk.org  Tue Jan  3 21:15:04 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 3 Jan 2023 21:15:04 GMT
Subject: RFR: Separate ASM-dependent code into a separate source tree.
In-Reply-To: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
References: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
Message-ID: <cITJgZhBIYN3armiFMuu3wlZ-98KeltqBCoIZ3ddSLs=.eba621f1-da44-4041-8638-bc061238f718@github.com>

On Tue, 3 Jan 2023 19:21:12 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Separate ASM-dependent code into a separate source tree.
> Introduce modules.
> Changes in test infrastructure and more tests pending.
> Build is so far kept compatible with the previous version, only adding creation of two jmods.

src/classes/com/sun/tdk/jcov/instrument/InstrumentationPlugin.java line 67:

> 65: 
> 66:     static InstrumentationPlugin getPlugin() {
> 67:         return Services.getPlugin();

Result might be `result Optional<InstrumentationPlugin>`

src/classes/com/sun/tdk/jcov/instrument/Services.java line 36:

> 34: 
> 35:     static synchronized InstrumentationPlugin getPlugin() {
> 36:         if (Services.PLUGIN == null) {

Much better to get a result `Optional<InstrumentationPlugin> `

-------------

PR: https://git.openjdk.org/jcov/pull/35

From lkuskov at openjdk.org  Tue Jan  3 21:23:05 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 3 Jan 2023 21:23:05 GMT
Subject: RFR: Separate ASM-dependent code into a separate source tree.
In-Reply-To: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
References: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
Message-ID: <jj5WEhmJqUepzVyqpKG9Sf-ldM9yRN0iv8NsF1XoP5U=.b27f7a40-bff1-4260-a23a-30b8f16fb697@github.com>

On Tue, 3 Jan 2023 19:21:12 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Separate ASM-dependent code into a separate source tree.
> Introduce modules.
> Changes in test infrastructure and more tests pending.
> Build is so far kept compatible with the previous version, only adding creation of two jmods.

test/unit/com/sun/tdk/jcov/instrument/nestHost/IntrumentNestHostTest.java line 211:

> 209:         (byte) 0x00, (byte) 0x0A
> 210:     };
> 211: }

Actually Asmtools could be used here testing

-------------

PR: https://git.openjdk.org/jcov/pull/35

From shurailine at openjdk.org  Tue Jan  3 23:43:14 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 3 Jan 2023 23:43:14 GMT
Subject: RFR: Separate ASM-dependent code into a separate source tree. [v2]
In-Reply-To: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
References: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
Message-ID: <NIKWj8otCs4npPp2AwijBhBeXTV35PdfP3ltSJ_6dDQ=.4cd3a8ef-b9da-4fb3-8f13-9c616451e9ad@github.com>

> Separate ASM-dependent code into a separate source tree.
> Introduce modules.
> Changes in test infrastructure and more tests pending.
> Build is so far kept compatible with the previous version, only adding creation of two jmods.

Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:

  Removed IntrumentNestHostTest.java in the old location

-------------

Changes:
  - all: https://git.openjdk.org/jcov/pull/35/files
  - new: https://git.openjdk.org/jcov/pull/35/files/cccacb78..02362052

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jcov&pr=35&range=01
 - incr: https://webrevs.openjdk.org/?repo=jcov&pr=35&range=00-01

  Stats: 207 lines in 1 file changed: 0 ins; 207 del; 0 mod
  Patch: https://git.openjdk.org/jcov/pull/35.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/35/head:pull/35

PR: https://git.openjdk.org/jcov/pull/35

From shurailine at openjdk.org  Tue Jan  3 23:43:15 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 3 Jan 2023 23:43:15 GMT
Subject: RFR: Separate ASM-dependent code into a separate source tree. [v2]
In-Reply-To: <jj5WEhmJqUepzVyqpKG9Sf-ldM9yRN0iv8NsF1XoP5U=.b27f7a40-bff1-4260-a23a-30b8f16fb697@github.com>
References: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
 <jj5WEhmJqUepzVyqpKG9Sf-ldM9yRN0iv8NsF1XoP5U=.b27f7a40-bff1-4260-a23a-30b8f16fb697@github.com>
Message-ID: <z9jor7oEg7B5UgIV4kkWgewqG4AiqFWBiNuehNMY30A=.a1fab3b8-acae-4373-b22d-ab2c97317030@github.com>

On Tue, 3 Jan 2023 21:20:52 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

>> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed IntrumentNestHostTest.java in the old location
>
> test/unit/com/sun/tdk/jcov/instrument/nestHost/IntrumentNestHostTest.java line 211:
> 
>> 209:         (byte) 0x00, (byte) 0x0A
>> 210:     };
>> 211: }
> 
> Actually Asmtools could be used here testing

as in openjdk/asmtools? That would be fine, only it introduces another dependency.
Let me look closer on this test, but in a separate commit, OK?

-------------

PR: https://git.openjdk.org/jcov/pull/35

From shurailine at openjdk.org  Tue Jan  3 23:43:15 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 3 Jan 2023 23:43:15 GMT
Subject: RFR: Separate ASM-dependent code into a separate source tree. [v2]
In-Reply-To: <z9jor7oEg7B5UgIV4kkWgewqG4AiqFWBiNuehNMY30A=.a1fab3b8-acae-4373-b22d-ab2c97317030@github.com>
References: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
 <jj5WEhmJqUepzVyqpKG9Sf-ldM9yRN0iv8NsF1XoP5U=.b27f7a40-bff1-4260-a23a-30b8f16fb697@github.com>
 <z9jor7oEg7B5UgIV4kkWgewqG4AiqFWBiNuehNMY30A=.a1fab3b8-acae-4373-b22d-ab2c97317030@github.com>
Message-ID: <cNheztdg5LKVqYjBKi50Yq50ve4Bk3GrtCTJB14G4e0=.c67b0776-bb1c-439a-8841-7ac08eff3c4f@github.com>

On Tue, 3 Jan 2023 22:03:35 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> test/unit/com/sun/tdk/jcov/instrument/nestHost/IntrumentNestHostTest.java line 211:
>> 
>>> 209:         (byte) 0x00, (byte) 0x0A
>>> 210:     };
>>> 211: }
>> 
>> Actually Asmtools could be used here testing
>
> as in openjdk/asmtools? That would be fine, only it introduces another dependency.
> Let me look closer on this test, but in a separate commit, OK?

I forgot to mention that the reason this test shows up in the review as a new test is because I moved it incorrectly: by deleting and adding. There are no functional changes.

-------------

PR: https://git.openjdk.org/jcov/pull/35

From lkuskov at openjdk.org  Wed Jan  4 04:21:05 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Wed, 4 Jan 2023 04:21:05 GMT
Subject: RFR: Separate ASM-dependent code into a separate source tree. [v2]
In-Reply-To: <NIKWj8otCs4npPp2AwijBhBeXTV35PdfP3ltSJ_6dDQ=.4cd3a8ef-b9da-4fb3-8f13-9c616451e9ad@github.com>
References: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
 <NIKWj8otCs4npPp2AwijBhBeXTV35PdfP3ltSJ_6dDQ=.4cd3a8ef-b9da-4fb3-8f13-9c616451e9ad@github.com>
Message-ID: <50vIa6jOHywA0-sczrykCvHr8OnSU8OHfl9JjxfP-uA=.8d55dc97-1250-43b2-8ba4-c643cc4a80a2@github.com>

On Tue, 3 Jan 2023 23:43:14 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> Separate ASM-dependent code into a separate source tree.
>> Introduce modules.
>> Changes in test infrastructure and more tests pending.
>> Build is so far kept compatible with the previous version, only adding creation of two jmods.
>
> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed IntrumentNestHostTest.java in the old location

LGTM!

-------------

PR: https://git.openjdk.org/jcov/pull/35

From shurailine at openjdk.org  Wed Jan  4 16:09:14 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 4 Jan 2023 16:09:14 GMT
Subject: Integrated: Separate ASM-dependent code into a separate source tree.
In-Reply-To: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
References: <waSCu0hY3njCSE-0JIJXxjvR0AB2C_M2aRMPELpZ2Vc=.f63f4ba2-0b90-4b42-8b93-072ceffcc3b9@github.com>
Message-ID: <MHgfIGjsokVX78LFCO1Kmbt7dMXMubUeBh6AvTQcH0s=.6aec9c6e-a2ef-491f-8ecc-966f3bbb6fc5@github.com>

On Tue, 3 Jan 2023 19:21:12 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Separate ASM-dependent code into a separate source tree.
> Introduce modules.
> Changes in test infrastructure and more tests pending.
> Build is so far kept compatible with the previous version, only adding creation of two jmods.

This pull request has now been integrated.

Changeset: 5efa2b4e
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/5efa2b4e2c995fa56dfcd52e68b0dc7303f1fa36
Stats:     1169 lines in 57 files changed: 550 ins; 580 del; 39 mod

Separate ASM-dependent code into a separate source tree.

-------------

PR: https://git.openjdk.org/jcov/pull/35

From shurailine at openjdk.org  Thu Jan  5 05:40:48 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Thu, 5 Jan 2023 05:40:48 GMT
Subject: RFR: Now using JTReg to run tests.
Message-ID: <Vc6cmBmkTNnlIP_yE9m69nBzcAsTaYA2p6t-Il0qor8=.6ca25a10-0457-44db-ba30-357374844cc0@github.com>

Closing InputStream in multiple places.
Brought back some of the logic with input/output locations in Instr.

With this change all tests passed been executed through ant.

-------------

Commit messages:
 - Now using JTReg to run tests.

Changes: https://git.openjdk.org/jcov/pull/36/files
 Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=36&range=00
  Stats: 102 lines in 11 files changed: 45 ins; 27 del; 30 mod
  Patch: https://git.openjdk.org/jcov/pull/36.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/36/head:pull/36

PR: https://git.openjdk.org/jcov/pull/36

From lkuskov at openjdk.org  Fri Jan  6 00:36:04 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 6 Jan 2023 00:36:04 GMT
Subject: RFR: Now using JTReg to run tests.
In-Reply-To: <Vc6cmBmkTNnlIP_yE9m69nBzcAsTaYA2p6t-Il0qor8=.6ca25a10-0457-44db-ba30-357374844cc0@github.com>
References: <Vc6cmBmkTNnlIP_yE9m69nBzcAsTaYA2p6t-Il0qor8=.6ca25a10-0457-44db-ba30-357374844cc0@github.com>
Message-ID: <pOL3g1D42CudzoCGs78KAQZxO-KCaOoaawQWZ2LOxpI=.a0c14189-058a-41ad-9bcf-230686a66459@github.com>

On Thu, 5 Jan 2023 05:34:01 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Closing InputStream in multiple places.
> Brought back some of the logic with input/output locations in Instr.
> 
> With this change all tests passed been executed through ant.

Everything is OK.

-------------

PR: https://git.openjdk.org/jcov/pull/36

From shurailine at openjdk.org  Fri Jan  6 17:06:09 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Fri, 6 Jan 2023 17:06:09 GMT
Subject: Integrated: Now using JTReg to run tests.
In-Reply-To: <Vc6cmBmkTNnlIP_yE9m69nBzcAsTaYA2p6t-Il0qor8=.6ca25a10-0457-44db-ba30-357374844cc0@github.com>
References: <Vc6cmBmkTNnlIP_yE9m69nBzcAsTaYA2p6t-Il0qor8=.6ca25a10-0457-44db-ba30-357374844cc0@github.com>
Message-ID: <9OTENYWsGDRIeW-6xc2QTluRsWxrzBK7I_pw_AVV-PI=.bb1e4767-9832-4836-809b-62b35010ff3e@github.com>

On Thu, 5 Jan 2023 05:34:01 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Closing InputStream in multiple places.
> Brought back some of the logic with input/output locations in Instr.
> 
> With this change all tests passed been executed through ant.

This pull request has now been integrated.

Changeset: bdcb8be1
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/bdcb8be1a12a3263517b4781fa0e0bc0465c3cb2
Stats:     102 lines in 11 files changed: 45 ins; 27 del; 30 mod

Now using JTReg to run tests.

-------------

PR: https://git.openjdk.org/jcov/pull/36

From shurailine at openjdk.org  Tue Jan 10 02:50:59 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 10 Jan 2023 02:50:59 GMT
Subject: RFR: Service loading module test
Message-ID: <xDjhArDbHsGYVkH04wrpFwHGyoDc1u5fV3prqmZxClQ=.4894bf06-28f6-46e1-9175-91f325d28446@github.com>

A test framework for module testing will need to be developed later. Just a single test for now.

-------------

Commit messages:
 - Service loading module test

Changes: https://git.openjdk.org/jcov/pull/37/files
 Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=37&range=00
  Stats: 228 lines in 6 files changed: 214 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jcov/pull/37.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/37/head:pull/37

PR: https://git.openjdk.org/jcov/pull/37

From shurailine at openjdk.org  Tue Jan 10 21:52:18 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 10 Jan 2023 21:52:18 GMT
Subject: RFR: Service loading module test [v2]
In-Reply-To: <xDjhArDbHsGYVkH04wrpFwHGyoDc1u5fV3prqmZxClQ=.4894bf06-28f6-46e1-9175-91f325d28446@github.com>
References: <xDjhArDbHsGYVkH04wrpFwHGyoDc1u5fV3prqmZxClQ=.4894bf06-28f6-46e1-9175-91f325d28446@github.com>
Message-ID: <R9GIiEhdw2SlzyPartR8H2TxROIPFs-x2tqms1CbnK0=.34ceefe9-5ca5-4076-abb7-29f7b6dce903@github.com>

> A test framework for module testing will need to be developed later. Just a single test for now.

Alexandre Iline has updated the pull request incrementally with three additional commits since the last revision:

 - JTReg dir names
 - Single JTReg call for all tests.
 - Use orElseGet

-------------

Changes:
  - all: https://git.openjdk.org/jcov/pull/37/files
  - new: https://git.openjdk.org/jcov/pull/37/files/97001ba7..b03d9d9f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jcov&pr=37&range=01
 - incr: https://webrevs.openjdk.org/?repo=jcov&pr=37&range=00-01

  Stats: 36 lines in 2 files changed: 3 ins; 10 del; 23 mod
  Patch: https://git.openjdk.org/jcov/pull/37.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/37/head:pull/37

PR: https://git.openjdk.org/jcov/pull/37

From shurailine at openjdk.org  Wed Jan 11 15:48:42 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 11 Jan 2023 15:48:42 GMT
Subject: Integrated: Service loading module test
In-Reply-To: <xDjhArDbHsGYVkH04wrpFwHGyoDc1u5fV3prqmZxClQ=.4894bf06-28f6-46e1-9175-91f325d28446@github.com>
References: <xDjhArDbHsGYVkH04wrpFwHGyoDc1u5fV3prqmZxClQ=.4894bf06-28f6-46e1-9175-91f325d28446@github.com>
Message-ID: <x0HVEzACYgXELaU-abbxEl3QJSZEgGWGHAXt6puDp2w=.d9f2cf55-9002-463b-b024-daed3096a4b1@github.com>

On Tue, 10 Jan 2023 02:44:38 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> A test framework for module testing will need to be developed later. Just a single test for now.

This pull request has now been integrated.

Changeset: 6fd64408
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/6fd644083ba1a0113e6b3366d7f160a5ec3f5396
Stats:     229 lines in 6 files changed: 207 ins; 0 del; 22 mod

Service loading module test

-------------

PR: https://git.openjdk.org/jcov/pull/37

From shurailine at openjdk.org  Fri Jan 13 04:14:26 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Fri, 13 Jan 2023 04:14:26 GMT
Subject: RFR: Addressing TODOs
Message-ID: <2JygsFOVJ4B9mPF7g5h-or2G5clUKmUnA6RhdL8Uxak=.a701f307-8992-445d-88c8-181f1c8181c6@github.com>

This completes the work on CODETOOLS-7903274.
Remaining are updates to data coverage plugin.

-------------

Commit messages:
 - Addressing TODOs

Changes: https://git.openjdk.org/jcov/pull/38/files
 Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=38&range=00
  Stats: 963 lines in 20 files changed: 628 ins; 292 del; 43 mod
  Patch: https://git.openjdk.org/jcov/pull/38.diff
  Fetch: git fetch https://git.openjdk.org/jcov pull/38/head:pull/38

PR: https://git.openjdk.org/jcov/pull/38

From lkuskov at openjdk.org  Fri Jan 13 04:29:36 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 13 Jan 2023 04:29:36 GMT
Subject: RFR: Addressing TODOs
In-Reply-To: <2JygsFOVJ4B9mPF7g5h-or2G5clUKmUnA6RhdL8Uxak=.a701f307-8992-445d-88c8-181f1c8181c6@github.com>
References: <2JygsFOVJ4B9mPF7g5h-or2G5clUKmUnA6RhdL8Uxak=.a701f307-8992-445d-88c8-181f1c8181c6@github.com>
Message-ID: <FTKm8S_Q4UTB7r-yNsoHv23FGDsk7BbIDSXO1_kmA0g=.6bb31bde-b519-4609-a13a-79341e675a21@github.com>

On Thu, 12 Jan 2023 23:42:06 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> This completes the work on CODETOOLS-7903274.
> Remaining are updates to data coverage plugin.

LGTM, but! one thing which isn't in your TODO list - write descriptions for public classes that wouldn't be removed to highlight their usage and functionality.

-------------

PR: https://git.openjdk.org/jcov/pull/38

From shurailine at openjdk.org  Fri Jan 13 18:48:45 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Fri, 13 Jan 2023 18:48:45 GMT
Subject: RFR: Addressing TODOs
In-Reply-To: <FTKm8S_Q4UTB7r-yNsoHv23FGDsk7BbIDSXO1_kmA0g=.6bb31bde-b519-4609-a13a-79341e675a21@github.com>
References: <2JygsFOVJ4B9mPF7g5h-or2G5clUKmUnA6RhdL8Uxak=.a701f307-8992-445d-88c8-181f1c8181c6@github.com>
 <FTKm8S_Q4UTB7r-yNsoHv23FGDsk7BbIDSXO1_kmA0g=.6bb31bde-b519-4609-a13a-79341e675a21@github.com>
Message-ID: <RM1fkLI35WxFhXoHLQhHeJX-MFA24f-NVnSF2Q5-Qys=.f822428d-2e40-4f81-b9db-ca940f6c5973@github.com>

On Fri, 13 Jan 2023 04:26:54 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> LGTM, but! one thing which isn't in your TODO list - write descriptions for public classes that wouldn't be removed to highlight their usage and functionality.

You mean the javadoc? Of course that would be very useful.

-------------

PR: https://git.openjdk.org/jcov/pull/38

From shurailine at openjdk.org  Fri Jan 13 18:48:46 2023
From: shurailine at openjdk.org (Alexandre Iline)
Date: Fri, 13 Jan 2023 18:48:46 GMT
Subject: Integrated: Addressing TODOs
In-Reply-To: <2JygsFOVJ4B9mPF7g5h-or2G5clUKmUnA6RhdL8Uxak=.a701f307-8992-445d-88c8-181f1c8181c6@github.com>
References: <2JygsFOVJ4B9mPF7g5h-or2G5clUKmUnA6RhdL8Uxak=.a701f307-8992-445d-88c8-181f1c8181c6@github.com>
Message-ID: <yfwH6Sh9ohSahZJtaxFNm6XKwfKhL7XP9wmD61P6lGs=.2fef4a4d-59c0-4ac0-8628-f7a63f250dcb@github.com>

On Thu, 12 Jan 2023 23:42:06 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> This completes the work on CODETOOLS-7903274.
> Remaining are updates to data coverage plugin.

This pull request has now been integrated.

Changeset: e70f4ad5
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/e70f4ad528566cfb832d71005fc89a7d4a28ddf8
Stats:     963 lines in 20 files changed: 628 ins; 292 del; 43 mod

Addressing TODOs

-------------

PR: https://git.openjdk.org/jcov/pull/38

From lkuskov at openjdk.org  Fri Jan 13 23:52:22 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 13 Jan 2023 23:52:22 GMT
Subject: RFR: Addressing TODOs
In-Reply-To: <2JygsFOVJ4B9mPF7g5h-or2G5clUKmUnA6RhdL8Uxak=.a701f307-8992-445d-88c8-181f1c8181c6@github.com>
References: <2JygsFOVJ4B9mPF7g5h-or2G5clUKmUnA6RhdL8Uxak=.a701f307-8992-445d-88c8-181f1c8181c6@github.com>
Message-ID: <Gk6iEeQ4uRa2beZsrEqLaiTLNCpxrqoTStxd4zo9_8I=.2db97ec6-dd44-441a-9f76-57b96e3b1a98@github.com>

On Thu, 12 Jan 2023 23:42:06 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> This completes the work on CODETOOLS-7903274.
> Remaining are updates to data coverage plugin.

Of course  the javadoc is appreciated to be in the reviewed code

-------------

PR: https://git.openjdk.org/jcov/pull/38