RFR: Separate ASM-dependent code into a separate source tree.

Leonid Kuskov lkuskov at openjdk.org
Tue Jan 3 21:15:04 UTC 2023


On Tue, 3 Jan 2023 19:21:12 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Separate ASM-dependent code into a separate source tree.
> Introduce modules.
> Changes in test infrastructure and more tests pending.
> Build is so far kept compatible with the previous version, only adding creation of two jmods.

src/classes/com/sun/tdk/jcov/instrument/InstrumentationPlugin.java line 67:

> 65: 
> 66:     static InstrumentationPlugin getPlugin() {
> 67:         return Services.getPlugin();

Result might be `result Optional<InstrumentationPlugin>`

src/classes/com/sun/tdk/jcov/instrument/Services.java line 36:

> 34: 
> 35:     static synchronized InstrumentationPlugin getPlugin() {
> 36:         if (Services.PLUGIN == null) {

Much better to get a result `Optional<InstrumentationPlugin> `

-------------

PR: https://git.openjdk.org/jcov/pull/35


More information about the jcov-dev mailing list