RFR: 7903711: Rewrite simple methods ANC plugin to classfile API [v2]

[Alexandre Iline]

On Fri, 12 Apr 2024 20:55:46 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

>> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Missing LDC instructions
>
> plugins/simple_methods_anc/src/openjdk/jcov/filter/simplemethods/Delegators.java line 59:
> 
>> 57:             var iter = new InstructionIterator(m.code().get());
>> 58:             var next = iter.next(i -> !isSimpleInstruction(i.opcode()));
>> 59:             if (next == null || !isInvokeInstruction(next.opcode())) return false;
> 
> Bad codestyle - the line should be splitted into 2 ones.
> 
> if (next == null || !isInvokeInstruction(next.opcode())) 
>     return false;

I think OpenJDK style is to only not use curly brackets in statement is on the same line as the if. If the statement is on another line, you were supposed to use the curly brackets. I do not remember where I saw this.

-------------

PR Review Comment: https://git.openjdk.org/jcov/pull/44#discussion_r1566257821