RFR: 7903711: Rewrite simple methods ANC plugin to classfile API [v2]
Alexandre Iline
shurailine at openjdk.org
Mon Apr 15 19:00:10 UTC 2024
On Mon, 15 Apr 2024 18:52:41 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:
>> Jcov uses '2-lines' if statements in many places, which, although more readable, is incorrect. The OpenJDK Java code style recommends using curly braces syntax instead - [https://cr.openjdk.org/~alundblad/styleguide/index-v6.html#toc-braces](https://cr.openjdk.org/~alundblad/styleguide/index-v6.html#toc-braces)
>
> This, then is also against the openjdk code style:
>
> if (m.code().isPresent()) {
> Instruction next = new InstructionIterator(m.code().get()).next(i -> !isSimpleInstruction(i.opcode()));
> return next.opcode() == Opcode.RETURN;
> } else return false;
>
> "If one of the blocks in a if / else statement has braces, the other block must too."
updated all.
-------------
PR Review Comment: https://git.openjdk.org/jcov/pull/44#discussion_r1566297426
More information about the jcov-dev
mailing list