RFR: 7903711: Rewrite simple methods ANC plugin to classfile API [v2]

Alexandre Iline shurailine at openjdk.org
Mon Apr 15 19:00:11 UTC 2024


On Fri, 12 Apr 2024 20:59:38 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

>> Alexandre Iline has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Missing LDC instructions
>
> plugins/simple_methods_anc/src/openjdk/jcov/filter/simplemethods/Delegators.java line 65:
> 
>> 63:                 else if (next instanceof InvokeDynamicInstruction idi) name = idi.name().toString();
>> 64:                 else throw new IllegalStateException(STR."Unknown node type: \{next.getClass().getName()}");
>> 65:                 if (!m.methodName().toString().equals(name)) return false;
> 
> first comment

I assume this is also addressed.

-------------

PR Review Comment: https://git.openjdk.org/jcov/pull/44#discussion_r1566298177


More information about the jcov-dev mailing list