From lkuskov at openjdk.org  Mon Oct  7 20:15:06 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Mon, 7 Oct 2024 20:15:06 GMT
Subject: RFR: 7903842: Negative coverage in report for records
Message-ID: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>

The Javap report had several issues marked in the picture below, which have been fixed:
![defectReport](https://github.com/user-attachments/assets/b8de7fc9-c59b-41f9-8300-700a1e24b533)
The expected report is:
![fixedReport](https://github.com/user-attachments/assets/e7aa1ef4-3bed-46d8-80eb-a6e2c87a6da2)

-------------

Commit messages:
 - 7903842: Negative coverage in report for records

Changes: https://git.openjdk.org/jcov/pull/48/files
  Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=48&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903842
  Stats: 541 lines in 11 files changed: 187 ins; 155 del; 199 mod
  Patch: https://git.openjdk.org/jcov/pull/48.diff
  Fetch: git fetch https://git.openjdk.org/jcov.git pull/48/head:pull/48

PR: https://git.openjdk.org/jcov/pull/48

From shurailine at openjdk.org  Wed Oct 16 20:54:39 2024
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 16 Oct 2024 20:54:39 GMT
Subject: RFR: 7903867: Add a test for RepGen
Message-ID: <VDFWrICP4B8VMlf5MZKy0xY3E4n-SsQ7oh39X5Mv_Ns=.5352ab4b-5b8e-44ac-8bda-a7661857e68a@github.com>

Please note that a test for repine could also be written with just processing of a coverage xml file.
Please also notice that the command line test execution is blocked by https://bugs.openjdk.org/browse/CODETOOLS-7903035

-------------

Commit messages:
 - CODETOOLS-7903867: Add a test for RepGen

Changes: https://git.openjdk.org/jcov/pull/50/files
  Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=50&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903867
  Stats: 148 lines in 2 files changed: 148 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jcov/pull/50.diff
  Fetch: git fetch https://git.openjdk.org/jcov.git pull/50/head:pull/50

PR: https://git.openjdk.org/jcov/pull/50

From shurailine at openjdk.org  Wed Oct 16 20:59:21 2024
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 16 Oct 2024 20:59:21 GMT
Subject: RFR: 7903842: Negative coverage in report for records
In-Reply-To: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
References: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
Message-ID: <S0IkIey1s5tQzLt2gP0SHd-Sz0O-T_8Y_qWsuEgR8nQ=.32ec7a3a-93e2-4533-9d69-13bf03b2bd49@github.com>

On Mon, 7 Oct 2024 20:10:03 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> The Javap report had several issues marked in the picture below, which have been fixed:
> ![defectReport](https://github.com/user-attachments/assets/b8de7fc9-c59b-41f9-8300-700a1e24b533)
> The expected report is:
> ![fixedReport](https://github.com/user-attachments/assets/e7aa1ef4-3bed-46d8-80eb-a6e2c87a6da2)

Can you please add a test similar to one added by https://bugs.openjdk.org/browse/CODETOOLS-7903867?

Please note that the regular report is also showing negative coverage, not only the javap report. 

Does this fix addresses both reports? Is the root cause the same for the two reports or different?

If you will integrate this, you will need to open another bug for the regular report.

-------------

PR Comment: https://git.openjdk.org/jcov/pull/48#issuecomment-2417944661
PR Comment: https://git.openjdk.org/jcov/pull/48#issuecomment-2417948043

From lkuskov at openjdk.org  Thu Oct 17 22:19:03 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Thu, 17 Oct 2024 22:19:03 GMT
Subject: RFR: 7903867: Add a test for RepGen
In-Reply-To: <VDFWrICP4B8VMlf5MZKy0xY3E4n-SsQ7oh39X5Mv_Ns=.5352ab4b-5b8e-44ac-8bda-a7661857e68a@github.com>
References: <VDFWrICP4B8VMlf5MZKy0xY3E4n-SsQ7oh39X5Mv_Ns=.5352ab4b-5b8e-44ac-8bda-a7661857e68a@github.com>
Message-ID: <TP_tbvN1jBT5xwDI5FnUR2F93esvbkvgQGrKHqrWTHw=.ce6d8772-9cff-469b-9fe0-7a8fd368ea20@github.com>

On Wed, 16 Oct 2024 20:49:03 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Please note that a test for repine could also be written with just processing of a coverage xml file.
> Please also notice that the command line test execution is blocked by https://bugs.openjdk.org/browse/CODETOOLS-7903035

LGTM. Thank you for creating a template for report testing.

-------------

PR Comment: https://git.openjdk.org/jcov/pull/50#issuecomment-2420706377

From lkuskov at openjdk.org  Thu Oct 17 22:21:40 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Thu, 17 Oct 2024 22:21:40 GMT
Subject: RFR: 7903867: Add a test for RepGen
In-Reply-To: <VDFWrICP4B8VMlf5MZKy0xY3E4n-SsQ7oh39X5Mv_Ns=.5352ab4b-5b8e-44ac-8bda-a7661857e68a@github.com>
References: <VDFWrICP4B8VMlf5MZKy0xY3E4n-SsQ7oh39X5Mv_Ns=.5352ab4b-5b8e-44ac-8bda-a7661857e68a@github.com>
Message-ID: <V6y1ruSs9s1P4cDQnu4Xguv8dwymhk-m66BOB8nX75I=.990a006b-da98-43ab-9637-fa1191da7690@github.com>

On Wed, 16 Oct 2024 20:49:03 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Please note that a test for repine could also be written with just processing of a coverage xml file.
> Please also notice that the command line test execution is blocked by https://bugs.openjdk.org/browse/CODETOOLS-7903035

Marked as reviewed by lkuskov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jcov/pull/50#pullrequestreview-2376418531

From shurailine at openjdk.org  Mon Oct 21 19:30:23 2024
From: shurailine at openjdk.org (Alexandre Iline)
Date: Mon, 21 Oct 2024 19:30:23 GMT
Subject: Integrated: 7903867: Add a test for RepGen
In-Reply-To: <VDFWrICP4B8VMlf5MZKy0xY3E4n-SsQ7oh39X5Mv_Ns=.5352ab4b-5b8e-44ac-8bda-a7661857e68a@github.com>
References: <VDFWrICP4B8VMlf5MZKy0xY3E4n-SsQ7oh39X5Mv_Ns=.5352ab4b-5b8e-44ac-8bda-a7661857e68a@github.com>
Message-ID: <3dhQ09xhNz0DJFRf-1KYhgOjvvBqsBBvPK7PuupFi9Q=.eb6247a5-ada6-4b54-b366-4eb6afc80369@github.com>

On Wed, 16 Oct 2024 20:49:03 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Please note that a test for repine could also be written with just processing of a coverage xml file.
> Please also notice that the command line test execution is blocked by https://bugs.openjdk.org/browse/CODETOOLS-7903035

This pull request has now been integrated.

Changeset: 285d7e70
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/285d7e703a7672dde95aa2324844af7bd16eee89
Stats:     148 lines in 2 files changed: 148 ins; 0 del; 0 mod

7903867: Add a test for RepGen

Reviewed-by: lkuskov

-------------

PR: https://git.openjdk.org/jcov/pull/50

From shurailine at openjdk.org  Tue Oct 22 00:05:52 2024
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 22 Oct 2024 00:05:52 GMT
Subject: RFR: 7903874: Create a test for CODETOOLS-7903842
Message-ID: <jwbBOO9I-wxNrWYwSRziDn2MjIhkIHBn-SyV_SAWFYE=.14e208f7-5698-46cb-9d05-970e7b75fa72@github.com>

To help with testing.

-------------

Commit messages:
 - Uncomment cleanup
 - CODETOOLS-7903874: Create a test for CODETOOLS-7903842

Changes: https://git.openjdk.org/jcov/pull/52/files
  Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=52&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903874
  Stats: 217 lines in 4 files changed: 180 ins; 34 del; 3 mod
  Patch: https://git.openjdk.org/jcov/pull/52.diff
  Fetch: git fetch https://git.openjdk.org/jcov.git pull/52/head:pull/52

PR: https://git.openjdk.org/jcov/pull/52

From shurailine at openjdk.org  Tue Oct 22 00:08:41 2024
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 22 Oct 2024 00:08:41 GMT
Subject: RFR: 7903842: Negative coverage in report for records
In-Reply-To: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
References: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
Message-ID: <UQXF5ztmHdGI3mO3_0yP5eS35_DagKlEEHPmzgiRvz0=.333e42c8-fdf9-4b4d-836b-cf2cb69e3642@github.com>

On Mon, 7 Oct 2024 20:10:03 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> The Javap report had several issues marked in the picture below, which have been fixed:
> ![defectReport](https://github.com/user-attachments/assets/b8de7fc9-c59b-41f9-8300-700a1e24b533)
> The expected report is:
> ![fixedReport](https://github.com/user-attachments/assets/e7aa1ef4-3bed-46d8-80eb-a6e2c87a6da2)

FYI: I have created a test for this problem (only javap report, for now): https://github.com/openjdk/jcov/pull/52

-------------

PR Comment: https://git.openjdk.org/jcov/pull/48#issuecomment-2427953432

From lkuskov at openjdk.org  Tue Oct 22 00:57:44 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 22 Oct 2024 00:57:44 GMT
Subject: RFR: 7903874: Create a test for CODETOOLS-7903842
In-Reply-To: <jwbBOO9I-wxNrWYwSRziDn2MjIhkIHBn-SyV_SAWFYE=.14e208f7-5698-46cb-9d05-970e7b75fa72@github.com>
References: <jwbBOO9I-wxNrWYwSRziDn2MjIhkIHBn-SyV_SAWFYE=.14e208f7-5698-46cb-9d05-970e7b75fa72@github.com>
Message-ID: <t5hlO8651TeapaUPk1du4y0yhYV9Xp2kFYBbogJyTis=.8fb4d578-8d1f-462b-a37d-4b0c0d7f11f2@github.com>

On Tue, 22 Oct 2024 00:00:36 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> To help with testing.

LGTM

-------------

Marked as reviewed by lkuskov (Reviewer).

PR Review: https://git.openjdk.org/jcov/pull/52#pullrequestreview-2383543621

From shurailine at openjdk.org  Tue Oct 22 01:17:42 2024
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 22 Oct 2024 01:17:42 GMT
Subject: Integrated: 7903874: Create a test for CODETOOLS-7903842
In-Reply-To: <jwbBOO9I-wxNrWYwSRziDn2MjIhkIHBn-SyV_SAWFYE=.14e208f7-5698-46cb-9d05-970e7b75fa72@github.com>
References: <jwbBOO9I-wxNrWYwSRziDn2MjIhkIHBn-SyV_SAWFYE=.14e208f7-5698-46cb-9d05-970e7b75fa72@github.com>
Message-ID: <DFO5jCFZRCpnc_mCGFlVq041BjgGk7j4rFEaPTKYUZ4=.a8f521fd-6f45-4c51-9214-ac9bed7413c3@github.com>

On Tue, 22 Oct 2024 00:00:36 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> To help with testing.

This pull request has now been integrated.

Changeset: 48ce2bc2
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/48ce2bc24fa31306a0d60e08ae788a7f4f14e058
Stats:     217 lines in 4 files changed: 180 ins; 34 del; 3 mod

7903874: Create a test for CODETOOLS-7903842

Reviewed-by: lkuskov

-------------

PR: https://git.openjdk.org/jcov/pull/52

From shurailine at openjdk.org  Tue Oct 22 21:34:27 2024
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 22 Oct 2024 21:34:27 GMT
Subject: RFR: 7903875: Extend RecordContainerTest to also verify plain coverage
 report
Message-ID: <-hMevtmBu9R501gbYsuZOhst-XCSvyRVeu9AB3wzBhE=.3f38c26e-48ad-4251-92d0-6ab4616a1070@github.com>

?verage report

-------------

Commit messages:
 - CODETOOLS-7903875: Extend RecordContainerTest to also verify plain coverage report

Changes: https://git.openjdk.org/jcov/pull/53/files
  Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=53&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903875
  Stats: 22 lines in 1 file changed: 20 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jcov/pull/53.diff
  Fetch: git fetch https://git.openjdk.org/jcov.git pull/53/head:pull/53

PR: https://git.openjdk.org/jcov/pull/53